luanti-org/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-10-14 00:55:20 +02:00
Code Activity

Schematic: Properly deal with before/after node resolving and document (#11011)

Browse Source 
This fixes an out-of-bounds index access when the node resolver was already applied to the schematic (i.e. biome decoration).
Also improves the handling of the two cases: prior node resolving (m_nodenames), and after node resolving (manual lookup)
This commit is contained in:
SmallJoker
2021-03-20 13:02:15 +01:00
committed by GitHub
parent a8cc3bdb08
commit 05719913ac
7 changed files with 154 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/script/lua_api/l_mapgen.cpp
View File

@@ -1734,11 +1734,10 @@ int ModApiMapgen::l_serialize_schematic(lua_State *L)
std::ostringstream os(std::ios_base::binary);
switch (schem_format) {
case SCHEM_FMT_MTS:
schem->serializeToMts(&os, schem->m_nodenames);
schem->serializeToMts(&os);
break;
case SCHEM_FMT_LUA:
schem->serializeToLua(&os, schem->m_nodenames,
use_comments, indent_spaces);
schem->serializeToLua(&os, use_comments, indent_spaces);
break;
default:
return 0;