luanti-org/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-10-13 08:35:20 +02:00
Code Activity

Refactor local time getter functions (#12221)

Browse Source 
This commit introduces mt_localtime() in src/gettime.h, a wrapper
around the OS-specific thread-safe versions of localtime()
(resp. localtime_s on Windows and localtime_r in other systems).

Per the Open Group recommendation,
«portable applications should call tzset() explicitly before using
ctime_r() or localtime_r() because setting timezone information is
optional for those functions», so we also do a one-shot
call of tzset() (_tzset() on Windows to avoid warning C4996).

The function is used to replace the localtime() calls in
getTimestamp() and makeScreenshot().

(The only reminaing call to localtime() in the tree now is the one in
the local copy of the Lua source code.)
This commit is contained in:
Oblomov
2022-04-28 18:53:33 +02:00
committed by GitHub
parent 7e18a1f1be
commit 0d91ef78dd
2 changed files with 29 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/client/client.cpp
View File

@@ -1810,11 +1810,10 @@ void Client::makeScreenshot()
if (!raw_image)
return;
time_t t = time(NULL);
struct tm *tm = localtime(&t);
const struct tm tm = mt_localtime();
char timetstamp_c[64];
strftime(timetstamp_c, sizeof(timetstamp_c), "%Y%m%d_%H%M%S", tm);
strftime(timetstamp_c, sizeof(timetstamp_c), "%Y%m%d_%H%M%S", &tm);
std::string screenshot_dir;