luanti-org/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-12-18 12:55:25 +01:00
Code Activity

Fix various performance issues reported by cppcheck (#5628)

Browse Source 
* Also remove 1 non declared but defined functions
This commit is contained in:
Loïc Blot
2017-04-21 10:06:08 +02:00
committed by GitHub
parent de5ecc9fa3
commit 370354cc87
8 changed files with 57 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/network/connection.cpp
View File

@@ -930,7 +930,7 @@ void Peer::DecUseCount()
delete this;
}
void Peer::RTTStatistics(float rtt, std::string profiler_id,
void Peer::RTTStatistics(float rtt, const std::string &profiler_id,
unsigned int num_samples) {
if (m_last_rtt > 0) {
@@ -969,8 +969,7 @@ void Peer::RTTStatistics(float rtt, std::string profiler_id,
m_rtt.jitter_avg = m_rtt.jitter_avg * (num_samples/(num_samples-1)) +
jitter * (1/num_samples);
if (profiler_id != "")
{
if (profiler_id != "") {
g_profiler->graphAdd(profiler_id + "_rtt", rtt);
g_profiler->graphAdd(profiler_id + "_jitter", jitter);
}

4
src/network/connection.h
View File

@@ -732,8 +732,8 @@ class Peer {
virtual void reportRTT(float rtt) {};
void RTTStatistics(float rtt,
std::string profiler_id="",
unsigned int num_samples=1000);
const std::string &profiler_id = "",
unsigned int num_samples = 1000);
bool IncUseCount();
void DecUseCount();