luanti-org/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-10-13 16:45:20 +02:00
Code Activity

Don't pass non-const references to collision methods

Browse Source 
Non const references cause a lot of confusion with behaviour of code,
and are disallowed by minetest style guide.
This commit is contained in:
est31
2016-01-25 00:06:01 +01:00
parent ad884f23d4
commit 4e93ba06a7
7 changed files with 98 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/localplayer.cpp
View File

@@ -214,8 +214,8 @@ void LocalPlayer::move(f32 dtime, Environment *env, f32 pos_max_d,
v3f accel_f = v3f(0,0,0);
collisionMoveResult result = collisionMoveSimple(env, m_gamedef,
pos_max_d, m_collisionbox, player_stepheight, dtime,
position, m_speed, accel_f);
pos_max_d, m_collisionbox, player_stepheight, dtime,
&position, &m_speed, accel_f);
/*
If the player's feet touch the topside of any node, this is