From 9564da4a0450f32bbc84762ef7bee86c2777971e Mon Sep 17 00:00:00 2001
From: OgelGames <olliverdc28@gmail.com>
Date: Fri, 26 Apr 2024 01:00:40 +1000
Subject: [PATCH] add unittests for inventory

---
 games/devtest/mods/unittests/init.lua      |  1 +
 games/devtest/mods/unittests/inventory.lua | 69 ++++++++++++++++++++++
 2 files changed, 70 insertions(+)
 create mode 100644 games/devtest/mods/unittests/inventory.lua

diff --git a/games/devtest/mods/unittests/init.lua b/games/devtest/mods/unittests/init.lua
index b01a6271ce..6b2cd7a790 100644
--- a/games/devtest/mods/unittests/init.lua
+++ b/games/devtest/mods/unittests/init.lua
@@ -184,6 +184,7 @@ dofile(modpath .. "/itemstack_equals.lua")
 dofile(modpath .. "/content_ids.lua")
 dofile(modpath .. "/metadata.lua")
 dofile(modpath .. "/raycast.lua")
+dofile(modpath .. "/inventory.lua")
 
 --------------
 
diff --git a/games/devtest/mods/unittests/inventory.lua b/games/devtest/mods/unittests/inventory.lua
new file mode 100644
index 0000000000..c645e3544d
--- /dev/null
+++ b/games/devtest/mods/unittests/inventory.lua
@@ -0,0 +1,69 @@
+
+local item_with_meta = ItemStack({name = "air", meta = {test = "abc"}})
+
+local test_list = {
+	ItemStack("air"),
+	ItemStack(""),
+	ItemStack(item_with_meta),
+}
+
+local function compare_lists(a, b)
+	if not a or not b or #a ~= #b then
+		return false
+	end
+	for i=1, #a do
+		if not ItemStack(a[i]):equals(ItemStack(b[i])) then
+			return false
+		end
+	end
+	return true
+end
+
+local function test_inventory()
+	local inv = minetest.create_detached_inventory("test")
+
+	inv:set_lists({test = {""}})
+	assert(inv:get_list("test"))
+
+	assert(inv:get_size("test") == 1)
+	assert(inv:set_size("test", 3))
+	assert(not inv:set_size("test", -1))
+
+	assert(inv:get_width("test") == 0)
+	assert(inv:set_width("test", 3))
+	assert(not inv:set_width("test", -1))
+	
+	inv:set_stack("test", 1, "air")
+	inv:set_stack("test", 3, item_with_meta)
+	assert(not inv:is_empty("test"))
+	assert(compare_lists(inv:get_list("test"), test_list))
+	
+	assert(inv:add_item("test", "air") == ItemStack())
+	assert(inv:add_item("test", item_with_meta) == ItemStack())
+	assert(inv:get_stack("test", 1) == ItemStack("air 2"))
+	
+	assert(inv:room_for_item("test", "air 99"))
+	inv:set_stack("test", 2, "air 99")
+	assert(not inv:room_for_item("test", "air 99"))
+	inv:set_stack("test", 2, "")
+
+	assert(inv:contains_item("test", "air"))
+	assert(not inv:contains_item("test", "air 99"))
+	assert(inv:contains_item("test", item_with_meta, true))
+	
+	-- Items should be removed in reverse and combine with first stack removed
+	assert(inv:remove_item("test", "air") == item_with_meta)
+	item_with_meta:set_count(2)
+	assert(inv:remove_item("test", "air 2") == item_with_meta)
+	assert(inv:remove_item("test", "air") == ItemStack("air"))
+	assert(inv:is_empty("test"))
+	
+	-- Failure of set_list(s) should not change inventory
+	local before = inv:get_list("test")
+	pcall(inv.set_lists, inv, {test = true})
+	pcall(inv.set_list, inv, "test", true)
+	local after = inv:get_list("test")
+	assert(compare_lists(before, after))
+end
+
+unittests.register("test_inventory", test_inventory)