luanti-org/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-10-15 09:25:37 +02:00
Code Activity

Clamp client-sent movement speed control (#15721)

Browse Source 
Results in the `movement_x` and `movement_y` fields of `player:get_player_control()` being safe to use
(otherwise users would need to compute the length as `(x^2 + y^2)^0.5` and clamp that to 1 themselves).
This commit is contained in:
Lars Müller
2025-02-04 12:19:00 +01:00
committed by GitHub
parent b2a6c3ba23
commit a73e71510a
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/serverpackethandler.cpp
View File

@@ -30,6 +30,8 @@
#include "util/srp.h" #include "util/srp.h"
#include "clientdynamicinfo.h" #include "clientdynamicinfo.h"
#include <algorithm>
void Server::handleCommand_Deprecated(NetworkPacket* pkt) void Server::handleCommand_Deprecated(NetworkPacket* pkt)
{ {
infostream << "Server: " << toServerCommandTable[pkt->getCommand()].name infostream << "Server: " << toServerCommandTable[pkt->getCommand()].name
@@ -468,7 +470,11 @@ void Server::process_PlayerPos(RemotePlayer *player, PlayerSAO *playersao,
*pkt >> bits; *pkt >> bits;
if (pkt->getRemainingBytes() >= 8) { if (pkt->getRemainingBytes() >= 8) {
*pkt >> player->control.movement_speed; f32 movement_speed;
*pkt >> movement_speed;
if (movement_speed != movement_speed) // NaN
movement_speed = 0.0f;
player->control.movement_speed = std::clamp(movement_speed, 0.0f, 1.0f);
*pkt >> player->control.movement_direction; *pkt >> player->control.movement_direction;
} else { } else {
player->control.movement_speed = 0.0f; player->control.movement_speed = 0.0f;