luanti-org/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-10-19 03:05:29 +02:00
Code Activity

Sanitize formspec fields server-side (#14878)

Browse Source
This commit is contained in:
sfan5
2024-08-21 21:34:46 +02:00
committed by GitHub
parent ab7af5d15a
commit c6ef5ab259
5 changed files with 99 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/unittest/test_utilities.cpp
View File

@@ -61,6 +61,7 @@ public:
void testSanitizeDirName();
void testIsBlockInSight();
void testColorizeURL();
void testSanitizeUntrusted();
};
static TestUtilities g_test_instance;
@@ -95,6 +96,7 @@ void TestUtilities::runTests(IGameDef *gamedef)
TEST(testSanitizeDirName);
TEST(testIsBlockInSight);
TEST(testColorizeURL);
TEST(testSanitizeUntrusted);
}
////////////////////////////////////////////////////////////////////////////////
@@ -743,3 +745,28 @@ void TestUtilities::testColorizeURL()
warningstream << "Test skipped." << std::endl;
#endif
}
void TestUtilities::testSanitizeUntrusted()
{
std::string_view t1{u8"Anästhesieausrüstung"};
UASSERTEQ(auto, sanitize_untrusted(t1), t1);
std::string_view t2{"stop\x00here", 9};
UASSERTEQ(auto, sanitize_untrusted(t2), "stop");
UASSERTEQ(auto, sanitize_untrusted("\x01\x08\x13\x1dhello\r\n\tworld"), "hello\n\tworld");
std::string_view t3{"some \x1b(T@whatever)text\x1b" "E here"};
UASSERTEQ(auto, sanitize_untrusted(t3), t3);
auto t3_sanitized = sanitize_untrusted(t3, false);
UASSERT(str_starts_with(t3_sanitized, "some ") && str_ends_with(t3_sanitized, " here"));
UASSERT(t3_sanitized.find('\x1b') == std::string::npos);
UASSERTEQ(auto, sanitize_untrusted("\x1b[31m"), "[31m");
// edge cases
for (bool keep : {true, false}) {
UASSERTEQ(auto, sanitize_untrusted("\x1b", keep), "");
UASSERTEQ(auto, sanitize_untrusted("\x1b(", keep), "(");
}
}