luanti-org/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-10-14 09:05:19 +02:00
Code Activity

LINT: add clang-tidy step (#6295)

Browse Source 
* Implement new travis clang-tidy build step

* This step enable some rules and enforce one rule as error
* This permits to have some C++ quality rules based on clang & clang contributor guidelines

* Fix clang-tidy reported problems on push_back -> emplace_back
This commit is contained in:
Loïc Blot
2018-04-01 23:57:55 +02:00
committed by GitHub
parent 93eb0794d6
commit d88c4e1822
8 changed files with 319 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/script/cpp_api/s_env.cpp
View File

@@ -116,12 +116,12 @@ void ScriptApiEnv::initializeEnvironment(ServerEnvironment *env)
while (lua_next(L, table)) {
// key at index -2 and value at index -1
luaL_checktype(L, -1, LUA_TSTRING);
trigger_contents.push_back(lua_tostring(L, -1));
trigger_contents.emplace_back(lua_tostring(L, -1));
// removes value, keeps key for next iteration
lua_pop(L, 1);
}
} else if (lua_isstring(L, -1)) {
trigger_contents.push_back(lua_tostring(L, -1));
trigger_contents.emplace_back(lua_tostring(L, -1));
}
lua_pop(L, 1);
@@ -133,12 +133,12 @@ void ScriptApiEnv::initializeEnvironment(ServerEnvironment *env)
while (lua_next(L, table)) {
// key at index -2 and value at index -1
luaL_checktype(L, -1, LUA_TSTRING);
required_neighbors.push_back(lua_tostring(L, -1));
required_neighbors.emplace_back(lua_tostring(L, -1));
// removes value, keeps key for next iteration
lua_pop(L, 1);
}
} else if (lua_isstring(L, -1)) {
required_neighbors.push_back(lua_tostring(L, -1));
required_neighbors.emplace_back(lua_tostring(L, -1));
}
lua_pop(L, 1);