1
0
mirror of https://github.com/luanti-org/luanti.git synced 2025-10-21 20:05:45 +02:00

Fix various performance issues reported by cppcheck + code style (CI) (#5635)

* Make CI happy with code style on master
* guiFileSelectMenu: remove useless includes
* some performance fixes pointed by cppcheck
* remove some useless casts
* TextDest: remove unused setFormSpec function
This commit is contained in:
Loïc Blot
2017-04-21 23:40:48 +02:00
committed by GitHub
parent f151b23220
commit dc0e9097d3
7 changed files with 70 additions and 67 deletions

View File

@@ -32,8 +32,7 @@ class GUIFileSelectMenu: public GUIModalMenu
public:
GUIFileSelectMenu(gui::IGUIEnvironment* env, gui::IGUIElement* parent,
s32 id, IMenuManager *menumgr,
std::string title,
std::string formid);
const std::string &title, const std::string &formid);
~GUIFileSelectMenu();
void removeChildren();
@@ -47,9 +46,7 @@ public:
bool OnEvent(const SEvent& event);
bool isRunning() {
return m_running;
}
bool isRunning() const { return m_running; }
void setTextDest(TextDest * dest) {
m_text_dst = dest;