mirror of
				https://github.com/luanti-org/luanti.git
				synced 2025-11-04 09:15:29 +01:00 
			
		
		
		
	Drop valgrind from CI and instead enable ASan
The recently added ioctl use is reported as a false-positive by valgrind. I tried moving it to different compilers/versions two times and only hit further issues that were valgrind's fault. Also includes a tiny fix.
This commit is contained in:
		
							
								
								
									
										7
									
								
								.github/workflows/build.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										7
									
								
								.github/workflows/build.yml
									
									
									
									
										vendored
									
									
								
							@@ -83,7 +83,7 @@ jobs:
 | 
			
		||||
      - name: Install deps
 | 
			
		||||
        run: |
 | 
			
		||||
          source ./util/ci/common.sh
 | 
			
		||||
          install_linux_deps clang-7 valgrind
 | 
			
		||||
          install_linux_deps clang-7 llvm
 | 
			
		||||
 | 
			
		||||
      - name: Build
 | 
			
		||||
        run: |
 | 
			
		||||
@@ -91,15 +91,12 @@ jobs:
 | 
			
		||||
        env:
 | 
			
		||||
          CC: clang-7
 | 
			
		||||
          CXX: clang++-7
 | 
			
		||||
          CMAKE_FLAGS: '-DCMAKE_C_FLAGS="-fsanitize=address" -DCMAKE_CXX_FLAGS="-fsanitize=address"'
 | 
			
		||||
 | 
			
		||||
      - name: Unittest
 | 
			
		||||
        run: |
 | 
			
		||||
          ./bin/minetest --run-unittests
 | 
			
		||||
 | 
			
		||||
      - name: Valgrind
 | 
			
		||||
        run: |
 | 
			
		||||
          valgrind --leak-check=full --leak-check-heuristics=all --undef-value-errors=no --error-exitcode=9 ./bin/minetest --run-unittests
 | 
			
		||||
 | 
			
		||||
  # Current clang version
 | 
			
		||||
  clang_14:
 | 
			
		||||
    runs-on: ubuntu-22.04
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user