mirror of
https://github.com/luanti-org/luanti.git
synced 2025-10-18 18:55:29 +02:00
0cde03254a
Because the count is serialized as u16, this would cause overflow. If minetest later deserialized a mapblock with an incorrect static object count, it would be unable to find the NameIdMapping (which comes after the StaticObjectList) and abort with an error such as "Invalid block data in database: unsupported NameIdMapping version" (issue #2610).
89 lines
2.3 KiB
C++
89 lines
2.3 KiB
C++
/*
|
|
Minetest
|
|
Copyright (C) 2010-2013 celeron55, Perttu Ahola <celeron55@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU Lesser General Public License as published by
|
|
the Free Software Foundation; either version 2.1 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public License along
|
|
with this program; if not, write to the Free Software Foundation, Inc.,
|
|
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#include "staticobject.h"
|
|
#include "util/serialize.h"
|
|
#include "log.h"
|
|
|
|
void StaticObject::serialize(std::ostream &os)
|
|
{
|
|
// type
|
|
writeU8(os, type);
|
|
// pos
|
|
writeV3F1000(os, pos);
|
|
// data
|
|
os<<serializeString(data);
|
|
}
|
|
void StaticObject::deSerialize(std::istream &is, u8 version)
|
|
{
|
|
// type
|
|
type = readU8(is);
|
|
// pos
|
|
pos = readV3F1000(is);
|
|
// data
|
|
data = deSerializeString(is);
|
|
}
|
|
|
|
void StaticObjectList::serialize(std::ostream &os)
|
|
{
|
|
// version
|
|
u8 version = 0;
|
|
writeU8(os, version);
|
|
|
|
// count
|
|
size_t count = m_stored.size() + m_active.size();
|
|
// Make sure it fits into u16, else it would get truncated and cause e.g.
|
|
// issue #2610 (Invalid block data in database: unsupported NameIdMapping version).
|
|
if (count > (u16)-1) {
|
|
errorstream << "StaticObjectList::serialize(): "
|
|
<< "too many objects (" << count << ") in list, "
|
|
<< "not writing them to disk." << std::endl;
|
|
writeU16(os, 0); // count = 0
|
|
return;
|
|
}
|
|
writeU16(os, count);
|
|
|
|
for(std::vector<StaticObject>::iterator
|
|
i = m_stored.begin();
|
|
i != m_stored.end(); ++i) {
|
|
StaticObject &s_obj = *i;
|
|
s_obj.serialize(os);
|
|
}
|
|
for(std::map<u16, StaticObject>::iterator
|
|
i = m_active.begin();
|
|
i != m_active.end(); ++i)
|
|
{
|
|
StaticObject s_obj = i->second;
|
|
s_obj.serialize(os);
|
|
}
|
|
}
|
|
void StaticObjectList::deSerialize(std::istream &is)
|
|
{
|
|
// version
|
|
u8 version = readU8(is);
|
|
// count
|
|
u16 count = readU16(is);
|
|
for(u16 i = 0; i < count; i++) {
|
|
StaticObject s_obj;
|
|
s_obj.deSerialize(is, version);
|
|
m_stored.push_back(s_obj);
|
|
}
|
|
}
|
|
|