From ab633710ff8977426f0a89693f93ddc1f4c23e3e Mon Sep 17 00:00:00 2001
From: David Leal <halfpacho@gmail.com>
Date: Wed, 25 Nov 2020 22:41:41 -0600
Subject: [PATCH] Fix LuaCheck warnings

---
 .luacheckrc   | 15 ++++++++-------
 internal.lua  |  8 ++++----
 inventory.lua |  2 +-
 lcd.lua       | 11 +++++++----
 4 files changed, 20 insertions(+), 16 deletions(-)

diff --git a/.luacheckrc b/.luacheckrc
index b356748..f99ebe5 100644
--- a/.luacheckrc
+++ b/.luacheckrc
@@ -1,12 +1,13 @@
 
 read_globals = {
-	"vector",
-	"screwdriver",
-	"minetest",
-	"default",
-	"pipeworks",
-	"dump",
-	"VoxelArea",
+    "vector",
+    "screwdriver",
+    "minetest",
+    "default",
+    "pipeworks",
+    "dump",
+    "VoxelArea",
+    "ItemStack",
 }
 
 globals = {
diff --git a/internal.lua b/internal.lua
index 05c93fa..c9860b6 100644
--- a/internal.lua
+++ b/internal.lua
@@ -92,7 +92,7 @@ function digilines.transmit(pos, channel, msg, checked)
 		return
 	end
 	checked[checkedID] = true
-	
+
 	digilines.vm_begin()
 	local queue = queue_new()
 	queue_enqueue(queue, pos)
@@ -112,9 +112,9 @@ function digilines.transmit(pos, channel, msg, checked)
 				for _, rule in ipairs(rules) do
 					local nextPos = digilines.addPosRule(curPos, rule)
 					if digilines.rules_link(curPos, nextPos) then
-						local checkedID = minetest.hash_node_position(nextPos)
-						if not checked[checkedID] then
-							checked[checkedID] = true
+						local checkedID2 = minetest.hash_node_position(nextPos)
+						if not checked[checkedID2] then
+							checked[checkedID2] = true
 							queue_enqueue(queue, nextPos)
 						end
 					end
diff --git a/inventory.lua b/inventory.lua
index 86b1536..8af786f 100644
--- a/inventory.lua
+++ b/inventory.lua
@@ -229,7 +229,7 @@ minetest.register_node("digilines:chest", {
 		last_inventory_take_index = index
 		return stack:get_count()
 	end,
-	on_metadata_inventory_move = function(pos, from_list, from_index, to_list, to_index, count, player)
+	on_metadata_inventory_move = function(pos, _, from_index, _, to_index, count, player)
 		-- See what would happen if we were to move the items back from in the
 		-- opposite direction. In the event of a normal move, this must
 		-- succeed, because a normal move subtracts some items from the from
diff --git a/lcd.lua b/lcd.lua
index 37ce3e0..4541d4b 100644
--- a/lcd.lua
+++ b/lcd.lua
@@ -173,7 +173,7 @@ local prepare_writing = function(pos)
 	if entity then
 		set_texture(entity)
 		rotate_text(pos)
-	end	
+	end
 end
 
 local spawn_entity = function(pos)
@@ -225,12 +225,12 @@ minetest.register_node("digilines:lcd", {
 	end,
 	on_construct = reset_meta,
 	on_destruct = clearscreen,
-	on_punch = function(pos, node, puncher, pointed_thing)
+	on_punch = function(pos, _, puncher, _)
 		if minetest.is_player(puncher) then
 			spawn_entity(pos)
 		end
 	end,
-	on_rotate = function(pos, node, user, mode, new_param2)
+	on_rotate = function(pos, _, _, mode, new_param2)
 		if mode ~= screwdriver.ROTATE_FACE then
 			return false
 		end
@@ -273,7 +273,10 @@ minetest.register_craft({
 	output = "digilines:lcd 2",
 	recipe = {
 		{"default:steel_ingot", "digilines:wire_std_00000000", "default:steel_ingot"},
-		{"mesecons_lightstone:lightstone_green_off","mesecons_lightstone:lightstone_green_off","mesecons_lightstone:lightstone_green_off"},
+		{"mesecons_lightstone:lightstone_green_off",
+		"mesecons_lightstone:lightstone_green_off",
+		"mesecons_lightstone:lightstone_green_off"},
+
 		{"default:glass","default:glass","default:glass"}
 	}
 })