From 302b3521b522665d059be879ff479a365d8ed973 Mon Sep 17 00:00:00 2001 From: Jude Melton-Houghton Date: Sun, 3 Apr 2022 21:04:45 -0400 Subject: [PATCH] Add tests for mesecons_mvps --- .github/workflows/check-release.yml | 3 + mesecons_mvps/spec/fixtures/mesecons_mvps.lua | 45 +++ mesecons_mvps/spec/mineunit.conf | 1 + mesecons_mvps/spec/node_spec.lua | 275 ++++++++++++++++++ mesecons_mvps/spec/object_spec.lua | 3 + 5 files changed, 327 insertions(+) create mode 100644 mesecons_mvps/spec/fixtures/mesecons_mvps.lua create mode 100644 mesecons_mvps/spec/mineunit.conf create mode 100644 mesecons_mvps/spec/node_spec.lua create mode 100644 mesecons_mvps/spec/object_spec.lua diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml index 0b3903e..368507f 100644 --- a/.github/workflows/check-release.yml +++ b/.github/workflows/check-release.yml @@ -30,3 +30,6 @@ jobs: - name: run mesecons tests working-directory: ./mesecons/ run: $HOME/.luarocks/bin/mineunit -q + - name: run mesecons_mvps tests + working-directory: ./mesecons_mvps/ + run: $HOME/.luarocks/bin/mineunit -q diff --git a/mesecons_mvps/spec/fixtures/mesecons_mvps.lua b/mesecons_mvps/spec/fixtures/mesecons_mvps.lua new file mode 100644 index 0000000..e65d0fe --- /dev/null +++ b/mesecons_mvps/spec/fixtures/mesecons_mvps.lua @@ -0,0 +1,45 @@ +mineunit("protection") + +fixture("mesecons") + +mineunit:set_current_modname("mesecons_mvps") +mineunit:set_modpath("mesecons_mvps", "../mesecons_mvps") +sourcefile("../mesecons_mvps/init") + +minetest.register_node("mesecons_mvps:test_stopper", { + description = "Test Stopper", +}) +mesecon.register_mvps_stopper("mesecons_mvps:test_stopper") + +minetest.register_node("mesecons_mvps:test_stopper_cond", { + description = "Test Stopper (Conditional)", +}) +mesecon.register_mvps_stopper("mesecons_mvps:test_stopper_cond", function(node) + return node.param2 == 0 +end) + +minetest.register_node("mesecons_mvps:test_sticky", { + description = "Test Sticky", + mvps_sticky = function(pos) + local connected = {} + for i, rule in ipairs(mesecon.rules.alldirs) do + connected[i] = vector.add(pos, rule) + end + return connected + end, +}) + +mesecon._test_moves = {} +minetest.register_node("mesecons_mvps:test_on_move", { + description = "Test Moveable", + mesecon = { + on_mvps_move = function(pos, node, oldpos, meta) + table.insert(mesecon._test_moves, {pos, oldpos, meta}) + end + }, +}) +local old_reset = mesecon._test_reset +function mesecon._test_reset() + mesecon._test_moves = {} + old_reset() +end diff --git a/mesecons_mvps/spec/mineunit.conf b/mesecons_mvps/spec/mineunit.conf new file mode 100644 index 0000000..b6d7b31 --- /dev/null +++ b/mesecons_mvps/spec/mineunit.conf @@ -0,0 +1 @@ +fixture_paths = {"../mesecons/spec/fixtures"} diff --git a/mesecons_mvps/spec/node_spec.lua b/mesecons_mvps/spec/node_spec.lua new file mode 100644 index 0000000..19008f1 --- /dev/null +++ b/mesecons_mvps/spec/node_spec.lua @@ -0,0 +1,275 @@ +require("mineunit") + +fixture("mesecons_mvps") + +world.set_default_node("air") + +describe("node movement", function() + after_each(function() + mesecon._test_reset() + world.clear() + end) + + it("works with no nodes", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 1, y = 0, z = 0} + + assert.same({true, {}, {}}, {mesecon.mvps_push(pos, dir, 1, "")}) + assert.same({true, {}, {}}, {mesecon.mvps_pull_all(pos, dir, 1, "")}) + assert.same({true, {}, {}}, {mesecon.mvps_pull_single(pos, dir, 1, "")}) + end) + + it("works with simple stack", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 1, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + world.set_node(vector.add(pos, dir), "mesecons:test_conductor_off") + + assert.is_true((mesecon.mvps_push(pos, dir, 2, ""))) + assert.equal("air", world.get_node(pos).name) + assert.equal("mesecons:test_conductor_off", world.get_node(vector.add(pos, dir)).name) + assert.equal("mesecons:test_conductor_off", world.get_node(vector.add(pos, vector.multiply(dir, 2))).name) + + assert.is_true((mesecon.mvps_pull_all(vector.add(pos, dir), vector.multiply(dir, -1), 2, ""))) + assert.equal("mesecons:test_conductor_off", world.get_node(pos).name) + assert.equal("mesecons:test_conductor_off", world.get_node(vector.add(pos, dir)).name) + assert.equal("air", world.get_node(vector.add(pos, vector.multiply(dir, 2))).name) + + assert.is_true((mesecon.mvps_pull_single(pos, vector.multiply(dir, -1), 1, ""))) + assert.equal("mesecons:test_conductor_off", world.get_node(vector.subtract(pos, dir)).name) + assert.equal("air", world.get_node(pos).name) + assert.equal("mesecons:test_conductor_off", world.get_node(vector.add(pos, dir)).name) + end) + + it("works with sticky nodes", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 0, y = 1, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + world.set_node(vector.offset(pos, 0, 1, 0), "mesecons_mvps:test_sticky") + world.set_node(vector.offset(pos, 1, 1, 0), "mesecons:test_conductor_off") + world.set_node(vector.offset(pos, 1, 2, 0), "mesecons:test_conductor_off") + + assert.is_true((mesecon.mvps_push(pos, dir, 4, ""))) + assert.equal("air", world.get_node(vector.offset(pos, 1, 1, 0)).name) + assert.equal("mesecons:test_conductor_off", world.get_node(vector.offset(pos, 1, 2, 0)).name) + assert.equal("mesecons:test_conductor_off", world.get_node(vector.offset(pos, 1, 3, 0)).name) + + assert.is_true((mesecon.mvps_pull_all(vector.add(pos, dir), vector.multiply(dir, -1), 4, ""))) + assert.equal("air", world.get_node(vector.offset(pos, 1, 0, 0)).name) + assert.equal("mesecons:test_conductor_off", world.get_node(vector.offset(pos, 1, 1, 0)).name) + assert.equal("mesecons:test_conductor_off", world.get_node(vector.offset(pos, 1, 2, 0)).name) + + assert.is_true((mesecon.mvps_pull_single(pos, vector.multiply(dir, -1), 3, ""))) + assert.equal("air", world.get_node(vector.offset(pos, 1, -1, 0)).name) + assert.equal("mesecons:test_conductor_off", world.get_node(vector.offset(pos, 1, 0, 0)).name) + assert.equal("air", world.get_node(vector.offset(pos, 1, 1, 0)).name) + end) + + it("respects maximum", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 1, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + world.set_node(vector.add(pos, dir), "mesecons:test_conductor_off") + + assert.is_true(not mesecon.mvps_push(pos, dir, 1, "")) + end) + + it("is blocked by basic stopper", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 1, y = 0, z = 0} + world.set_node(pos, "mesecons_mvps:test_stopper") + + assert.is_true(not mesecon.mvps_push(pos, dir, 1, "")) + end) + + it("is blocked by conditional stopper", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 1, y = 0, z = 0} + + world.set_node(pos, {name = "mesecons_mvps:test_stopper_cond", param2 = 0}) + assert.is_true(not mesecon.mvps_push(pos, dir, 1, "")) + + world.set_node(pos, {name = "mesecons_mvps:test_stopper_cond", param2 = 1}) + assert.is_true((mesecon.mvps_push(pos, dir, 1, ""))) + end) + + -- TODO: I think this is supposed to work? + pending("is blocked by ignore", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 1, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + world.set_node(vector.add(pos, dir), "ignore") + + assert.is_true(not mesecon.mvps_push(pos, dir, 1, "")) + end) + + it("moves metadata", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 1, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + minetest.get_meta(pos):set_string("foo", "bar") + minetest.get_node_timer(pos):set(12, 34) + + mesecon.mvps_push(pos, dir, 1, "") + local moved_meta = minetest.get_meta(vector.add(pos, dir)) + local moved_timer = minetest.get_node_timer(vector.add(pos, dir)) + assert.equal("bar", moved_meta:get("foo")) + assert.equal(12, moved_timer:get_timeout()) + assert.equal(34, moved_timer:get_elapsed()) + moved_timer:stop() + end) + + it("calls move callbacks", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 1, y = 0, z = 0} + world.set_node(pos, "mesecons_mvps:test_on_move") + minetest.get_meta(pos):set_string("foo", "bar") + local move_info = {vector.add(pos, dir), pos, minetest.get_meta(pos):to_table()} + + mesecon.mvps_push(pos, dir, 1, "") + assert.equal(1, #mesecon._test_moves) + assert.same(move_info, mesecon._test_moves[1]) + end) + + it("executes autoconnect hooks", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 1, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + + mesecon.mvps_push(pos, dir, 1, "") + mineunit:execute_globalstep() + assert.equal(2, #mesecon._test_autoconnects) + end) + + it("updates moved receptors", function() + local pos1 = {x = 0, y = 0, z = 0} + local pos2 = vector.offset(pos1, 0, 1, 0) + local pos3 = vector.offset(pos1, 2, 0, 0) + local pos4 = vector.offset(pos1, 0, 0, 1) + local dir = {x = 1, y = 0, z = 0} + mesecon._test_place(pos1, "mesecons:test_receptor_on") + mesecon._test_place(pos2, "mesecons:test_conductor_off") + mesecon._test_place(pos3, "mesecons:test_conductor_off") + mesecon._test_place(pos4, "mesecons:test_conductor_off") + mesecon._test_place(vector.add(pos4, dir), "mesecons:test_conductor_off") + mineunit:execute_globalstep() + + mesecon.mvps_push(pos1, dir, 1, "") + mineunit:execute_globalstep() + assert.equal("mesecons:test_conductor_off", world.get_node(pos2).name) + assert.equal("mesecons:test_conductor_on", world.get_node(pos3).name) + assert.equal("mesecons:test_conductor_on", world.get_node(pos4).name) + end) + + it("updates moved conductors", function() + local pos1 = {x = 0, y = 0, z = 0} + local pos2 = vector.offset(pos1, 0, 1, 0) + local pos3 = vector.offset(pos1, 0, -1, 0) + local dir = {x = 1, y = 0, z = 0} + mesecon._test_place(pos1, "mesecons:test_conductor_off") + mesecon._test_place(pos2, "mesecons:test_receptor_on") + mesecon._test_place(pos3, "mesecons:test_conductor_off") + mineunit:execute_globalstep() + + mesecon.mvps_push(pos1, dir, 1, "") + mineunit:execute_globalstep() + assert.equal("mesecons:test_conductor_off", world.get_node(vector.add(pos1, dir)).name) + assert.equal("mesecons:test_conductor_off", world.get_node(pos3).name) + + mesecon.mvps_pull_all(vector.add(pos1, dir), vector.multiply(dir, -1), 1, "") + mineunit:execute_globalstep() + assert.equal("mesecons:test_conductor_on", world.get_node(pos1).name) + assert.equal("mesecons:test_conductor_on", world.get_node(pos3).name) + end) + + it("updates moved effectors", function() + local pos = {x = 0, y = 0, z = 0} + local dir = {x = 1, y = 0, z = 0} + mesecon._test_place(pos, "mesecons:test_effector") + mesecon._test_place(vector.offset(pos, 0, 1, 0), "mesecons:test_receptor_on") + mesecon._test_place(vector.add(pos, dir), "mesecons:test_receptor_on") + mineunit:execute_globalstep() + + mesecon.mvps_push(pos, dir, 2, "") + mineunit:execute_globalstep() + assert.equal(tonumber("10000001", 2), world.get_node(vector.add(pos, dir)).param2) + + mesecon.mvps_pull_single(vector.add(pos, dir), vector.multiply(dir, -1), 1, "") + mineunit:execute_globalstep() + assert.equal(tonumber("10000100", 2), world.get_node(pos).param2) + end) + + -- mineunit doesn't yet implement minetest.check_for_falling. + pending("causes nodes to fall", function() + end) +end) + +describe("protection", function() + teardown(function() + minetest.settings:remove("mesecon.mvps_protection_mode") + end) + + after_each(function() + mesecon._test_reset() + world.clear() + end) + + local protected_pos = {x = 1, y = 0, z = 0} + mineunit:protect(protected_pos, "Joe") + + it("blocks movement", function() + minetest.settings:set("mesecon.mvps_protection_mode", "restrict") + + local pos = {x = 0, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + + assert.same({false, "protected"}, {mesecon.mvps_push(pos, {x = 1, y = 0, z = 0}, 1, "Bob")}) + end) + + it("allows owner's movement", function() + minetest.settings:set("mesecon.mvps_protection_mode", "restrict") + + local pos = {x = 0, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + + assert.is_true((mesecon.mvps_push(pos, {x = 1, y = 0, z = 0}, 1, "Joe"))) + end) + + it("'ignore'", function() + minetest.settings:set("mesecon.mvps_protection_mode", "ignore") + + local pos = {x = 0, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + + assert.is_true((mesecon.mvps_push(pos, {x = 1, y = 0, z = 0}, 1, "Bob"))) + end) + + it("'normal'", function() + minetest.settings:set("mesecon.mvps_protection_mode", "normal") + + local pos = {x = 0, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + + assert.same({false, "protected"}, {mesecon.mvps_push(pos, {x = 1, y = 0, z = 0}, 1, "")}) + + assert.is_true((mesecon.mvps_push(pos, {x = 0, y = 1, z = 0}, 1, ""))) + end) + + it("'compat'", function() + minetest.settings:set("mesecon.mvps_protection_mode", "compat") + + local pos = {x = 0, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + + assert.is_true((mesecon.mvps_push(pos, {x = 1, y = 0, z = 0}, 1, ""))) + end) + + it("'restrict'", function() + minetest.settings:set("mesecon.mvps_protection_mode", "restrict") + + local pos = {x = 0, y = 0, z = 0} + world.set_node(pos, "mesecons:test_conductor_off") + + assert.same({false, "protected"}, {mesecon.mvps_push(pos, {x = 0, y = 1, z = 0}, 1, "")}) + end) +end) diff --git a/mesecons_mvps/spec/object_spec.lua b/mesecons_mvps/spec/object_spec.lua new file mode 100644 index 0000000..cc2ca8d --- /dev/null +++ b/mesecons_mvps/spec/object_spec.lua @@ -0,0 +1,3 @@ +-- mineunit doesn't yet implement minetest.get_objects_inside_radius +pending("object movement", function() +end)