From a03375c5a449855a9acaefe4ae691d34198a9d09 Mon Sep 17 00:00:00 2001
From: Treer <treer.git@gmail.com>
Date: Sun, 11 Sep 2022 22:51:23 +1000
Subject: [PATCH] Use Minetest_game fences API if it's available (#57)

Fixes #56, and adds netherbrick rails (for consistency with MTG) if the fences API is found.
Using the MTG fence system adds interop between different fence types, and support for the "Tall fences and walls" option.

I've left the nether's register_craft() call unchanged, it overrides the recipe that default.register_fence() registers, granting 6 fences per crafting instead of MTG's 4.
---
 README.md           |  2 +-
 locale/nether.fr.tr |  1 +
 locale/template.txt |  1 +
 nodes.lua           | 48 ++++++++++++++++++++++++++-------------------
 4 files changed, 31 insertions(+), 21 deletions(-)

diff --git a/README.md b/README.md
index f938389..3f20e49 100644
--- a/README.md
+++ b/README.md
@@ -26,7 +26,7 @@ the nether first, or basalt might be a crafting ingredient required to reach
 a particular branch of the tech-tree.
 
 Netherbrick tools are provided (pick, shovel, axe, & sword), see tools.lua
-The Nether pickaxe has a 10x bonus again wear when mining netherrack.
+The Nether pickaxe has a 10x bonus against wear when mining netherrack.
 
 
 ## License of source code:
diff --git a/locale/nether.fr.tr b/locale/nether.fr.tr
index 24488ed..12ce386 100644
--- a/locale/nether.fr.tr
+++ b/locale/nether.fr.tr
@@ -66,6 +66,7 @@ Lava crust is strong enough to walk on, but still hot enough to inflict burns.=
 Nether Basalt=
 Nether Brick=Brique du Nether
 Nether Brick Fence=Barrière en briques du Nether
+Nether Brick Fence Rail=Clôture en briques du Nether
 Nether Slab=Dalle du Nether
 Nether Stair=Escalier du Nether
 Netherrack=Roche du Nether
diff --git a/locale/template.txt b/locale/template.txt
index 701eef3..fa3d032 100644
--- a/locale/template.txt
+++ b/locale/template.txt
@@ -65,6 +65,7 @@ Lava crust is strong enough to walk on, but still hot enough to inflict burns.=
 Nether Basalt=
 Nether Brick=
 Nether Brick Fence=
+Nether Brick Fence Rail=
 Nether Slab=
 Nether Stair=
 Netherrack=
diff --git a/nodes.lua b/nodes.lua
index b5cda2d..ebef598 100644
--- a/nodes.lua
+++ b/nodes.lua
@@ -249,26 +249,6 @@ minetest.register_node("nether:brick_cracked", {
 	sounds = default.node_sound_stone_defaults(),
 })
 
-local fence_texture =
-	"default_fence_overlay.png^nether_brick.png^default_fence_overlay.png^[makealpha:255,126,126"
-
-minetest.register_node("nether:fence_nether_brick", {
-	description = S("Nether Brick Fence"),
-	drawtype = "fencelike",
-	tiles = {"nether_brick.png"},
-	inventory_image = fence_texture,
-	wield_image = fence_texture,
-	paramtype = "light",
-	sunlight_propagates = true,
-	is_ground_content = false,
-	selection_box = {
-		type = "fixed",
-		fixed = {-1/7, -1/2, -1/7, 1/7, 1/2, 1/7},
-	},
-	groups = {cracky = 2, level = 2},
-	sounds = default.node_sound_stone_defaults(),
-})
-
 minetest.register_node("nether:brick_deep", {
 	description = S("Deep Nether Brick"),
 	tiles = {{
@@ -281,6 +261,34 @@ minetest.register_node("nether:brick_deep", {
 	sounds = default.node_sound_stone_defaults()
 })
 
+-- Register fence and rails
+
+local fence_texture =
+	"default_fence_overlay.png^nether_brick.png^default_fence_overlay.png^[makealpha:255,126,126"
+
+local rail_texture =
+	"default_fence_rail_overlay.png^nether_brick.png^default_fence_rail_overlay.png^[makealpha:255,126,126"
+
+default.register_fence("nether:fence_nether_brick", {
+	description = S("Nether Brick Fence"),
+	texture = "nether_brick.png",
+	inventory_image = fence_texture,
+	wield_image = fence_texture,
+	material = "nether:brick",
+	groups = {cracky = 2, level = 2},
+	sounds = default.node_sound_stone_defaults()
+})
+
+default.register_fence_rail("nether:fence_rail_nether_brick", {
+	description = S("Nether Brick Fence Rail"),
+	texture = "nether_brick.png",
+	inventory_image = rail_texture,
+	wield_image = rail_texture,
+	material = "nether:brick",
+	groups = {cracky = 2, level = 2},
+	sounds = default.node_sound_stone_defaults()
+})
+
 -- Register stair and slab
 
 -- Nether bricks can be made into stairs, slabs, inner stairs, and outer stairs