minetest/irrlicht
1
0
Fork 0
mirror of https://github.com/minetest/irrlicht.git synced 2025-02-22 13:50:25 +01:00
Code Issues Projects Releases Wiki Activity

Deprecate old implementation & note

Browse Source
This commit is contained in:
jordan4ibanez 2023-11-28 05:43:22 -05:00
parent 3cfb2a7323
commit dc886332b5
1 changed files with 33 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
source/Irrlicht/CB3DJSONMeshFileLoader.cpp
View File

@ -60,6 +60,9 @@ const char* buildVec3fError(std::string key) {
* Returns true if failure occurs. * Returns true if failure occurs.
*/ */
bool grabVec3f(json data, std::string key, irr::core::vector3df& refVec) { bool grabVec3f(json data, std::string key, irr::core::vector3df& refVec) {
// todo: make a CurrentElement thing in the class header so that we can print nice debug info.
if (data.contains(key) && data[key].is_array() && data[key].size() == 3) { if (data.contains(key) && data[key].is_array() && data[key].size() == 3) {
auto jsonVec3 = data[key]; auto jsonVec3 = data[key];
int i = 0; int i = 0;
@ -170,27 +173,7 @@ std::tuple<bool, std::string> CB3DJSONMeshFileLoader::load() {
return {false, "Wrong version in B3D JSON! Expected: 1"}; return {false, "Wrong version in B3D JSON! Expected: 1"};
} }
//! Remember: This is basically a linked tree.
// SMesh* baseMesh(new SMesh {});
// SMeshBuffer* meshBuffer(new SMeshBuffer {});
// And now we begin the recursion!
// std::cout << data["NODE"] << "\n";
// if (data.contains("NODE") && data["NODE"].is_object()) {
// println("Yep, that's a node!");
// // If it fails, give up basically.
// if (parseNode(data["NODE"], meshBuffer)) {
// return nullptr;
// }
// }
// SAnimatedMesh* animatedMesh(new SAnimatedMesh {});
// animatedMesh->addMesh(baseMesh);
// return animatedMesh; // return animatedMesh;
return {true, nullptr}; return {true, nullptr};
@ -275,4 +258,32 @@ IAnimatedMesh* CB3DJSONMeshFileLoader::createMesh(io::IReadFile* file) {
} }
} // namespace scene } // namespace scene
} // namespace irr } // namespace irr
/*
? This is old reference material. Remember to remove this before PR is made.
//! Remember: This is basically a linked tree.
// SMesh* baseMesh(new SMesh {});
// SMeshBuffer* meshBuffer(new SMeshBuffer {});
// And now we begin the recursion!
// std::cout << data["NODE"] << "\n";
// if (data.contains("NODE") && data["NODE"].is_object()) {
// println("Yep, that's a node!");
// // If it fails, give up basically.
// if (parseNode(data["NODE"], meshBuffer)) {
// return nullptr;
// }
// }
// SAnimatedMesh* animatedMesh(new SAnimatedMesh {});
// animatedMesh->addMesh(baseMesh);
*/