minetest
/
minetest
mirror of https://github.com/minetest/minetest.git
1
0
Fork 0
Code Issues Releases Wiki Activity

OpenALSoundManager: Fix a buffer overflow

This commit is contained in:
Desour 2023-06-20 18:54:36 +02:00 committed by sfan5
parent 531122ee86
commit 03dda13910
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/client/sound_openal_internal.cpp
View File

@ -730,10 +730,13 @@ f32 PlayingSound::getGain() noexcept
void OpenALSoundManager::stepStreams(f32 dtime)
{
// spread work across steps
int num_issued_sounds = std::ceil(m_sounds_streaming_current_bigstep.size()
* dtime / m_stream_timer);
const size_t num_issued_sounds = std::min(
m_sounds_streaming_current_bigstep.size(),
(size_t)std::ceil(m_sounds_streaming_current_bigstep.size()
* dtime / m_stream_timer)
);
for (; num_issued_sounds > 0; --num_issued_sounds) {
for (size_t i = 0; i < num_issued_sounds; ++i) {
auto wptr = std::move(m_sounds_streaming_current_bigstep.back());
m_sounds_streaming_current_bigstep.pop_back();