Fix warnings reported by clang

src/clientobject.h

@@ -61,27 +61,27 @@ public:
 	virtual scene::IMeshSceneNode *getMeshSceneNode(){return NULL;}
 	virtual scene::IAnimatedMeshSceneNode *getAnimatedMeshSceneNode(){return NULL;}
 	virtual scene::IBillboardSceneNode *getSpriteSceneNode(){return NULL;}
-	virtual bool isPlayer(){return false;}
+	virtual bool isPlayer() const {return false;}
-	virtual bool isLocalPlayer(){return false;}
+	virtual bool isLocalPlayer() const {return false;}
 	virtual void setAttachments(){}
 	virtual bool doShowSelectionBox(){return true;}
 	virtual void updateCameraOffset(v3s16 camera_offset){};
-	
+
 	// Step object in time
 	virtual void step(float dtime, ClientEnvironment *env){}
-	
+
 	// Process a message sent by the server side object
 	virtual void processMessage(const std::string &data){}
 
 	virtual std::string infoText() {return "";}
 	virtual std::string debugInfoText() {return "";}
-	
+
 	/*
 		This takes the return value of
 		ServerActiveObject::getClientInitializationData
 	*/
 	virtual void initialize(const std::string &data){}
-	
+
 	// Create a certain type of ClientActiveObject
 	static ClientActiveObject* create(u8 type, IGameDef *gamedef,
 			ClientEnvironment *env);
@@ -120,4 +120,3 @@ struct DistanceSortedActiveObject
 };
 
 #endif
-

src/content_cao.h

@@ -197,4 +197,3 @@ public:
 
 
 #endif
-

src/jthread/jsemaphore.h

@@ -54,10 +54,10 @@ private:
 	HANDLE m_hSemaphore;
 #elif __MACH__
 	semaphore_t m_semaphore;
+	int semcount;
 #else
 	sem_t m_semaphore;
 #endif
-    int semcount;
 };
 
 

src/main.cpp

@@ -381,8 +381,6 @@ public:
 #endif
 
 private:
-	IrrlichtDevice *m_device;
-
 	// The current state of keys
 	KeyList keyIsDown;
 	// Whether a key has been pressed or not

src/shader.cpp

@@ -211,8 +211,7 @@ public:
 class MainShaderConstantSetter : public IShaderConstantSetter
 {
 public:
-	MainShaderConstantSetter(IrrlichtDevice *device):
+	MainShaderConstantSetter(IrrlichtDevice *device)
-		m_device(device)
 	{}
 	~MainShaderConstantSetter() {}
 
@@ -256,9 +255,6 @@ public:
 			services->setVertexShaderConstant(world.pointer(), 8, 4);
 
 	}
-
-private:
-	IrrlichtDevice *m_device;
 };
 
 /*