From 3f8e2e8c38c8f4fc2ba5d044ef445123db454d99 Mon Sep 17 00:00:00 2001 From: shivajiva101 Date: Sat, 18 Nov 2017 13:58:08 +0000 Subject: [PATCH] Fix mousewheel behaviour in textarea (#6641) Allowing scrolling with the mousewheel when the vertical scrollbar is hidden, unnecessarily exposes oversized containers and newlines at the end of the text. For example try scrolling over the textareas in the pause menu. This PR addresses the issue by requiring the scrollbar to be visible before allowing the scrolling with the mousewheel. --- src/gui/intlGUIEditBox.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gui/intlGUIEditBox.cpp b/src/gui/intlGUIEditBox.cpp index 279e7a48a..c03256ede 100644 --- a/src/gui/intlGUIEditBox.cpp +++ b/src/gui/intlGUIEditBox.cpp @@ -1087,7 +1087,7 @@ bool intlGUIEditBox::processMouse(const SEvent& event) } break; case EMIE_MOUSE_WHEEL: - if (m_vscrollbar) { + if (m_vscrollbar && m_vscrollbar->isVisible()) { s32 pos = m_vscrollbar->getPos(); s32 step = m_vscrollbar->getSmallStep(); m_vscrollbar->setPos(pos - event.MouseInput.Wheel * step);