From 9f19b7d9367c5dc2758a9d4690b091b745fc821d Mon Sep 17 00:00:00 2001 From: Vitaliy Date: Sat, 30 Jun 2018 16:13:53 +0300 Subject: [PATCH] Fix world deletion (#7494) * Fix world deletion --- src/script/lua_api/l_mainmenu.cpp | 31 +++++++++---------------------- 1 file changed, 9 insertions(+), 22 deletions(-) diff --git a/src/script/lua_api/l_mainmenu.cpp b/src/script/lua_api/l_mainmenu.cpp index a5b211bc7..238e3e32f 100644 --- a/src/script/lua_api/l_mainmenu.cpp +++ b/src/script/lua_api/l_mainmenu.cpp @@ -594,31 +594,18 @@ int ModApiMainMenu::l_create_world(lua_State *L) /******************************************************************************/ int ModApiMainMenu::l_delete_world(lua_State *L) { - int worldidx = luaL_checkinteger(L,1) -1; - + int world_id = luaL_checkinteger(L, 1) - 1; std::vector worlds = getAvailableWorlds(); - - if ((worldidx >= 0) && - (worldidx < (int) worlds.size())) { - - WorldSpec spec = worlds[worldidx]; - - std::vector paths; - paths.push_back(spec.path); - fs::GetRecursiveSubPaths(spec.path, paths, true); - - // Delete files - if (!fs::DeletePaths(paths)) { - lua_pushstring(L, "Failed to delete world"); - } - else { - lua_pushnil(L); - } - } - else { + if (world_id < 0 || world_id >= (int) worlds.size()) { lua_pushstring(L, "Invalid world index"); + return 1; } - return 1; + const WorldSpec &spec = worlds[world_id]; + if (!fs::RecursiveDelete(spec.path)) { + lua_pushstring(L, "Failed to delete world"); + return 1; + } + return 0; } /******************************************************************************/