minetest/minetest
1
0
Fork 0
mirror of https://github.com/minetest/minetest.git synced 2025-07-04 00:40:24 +02:00
Code Issues Releases Wiki Activity

Various code improvements

Browse Source 
* Camera: Fix division by 0 after view bobbing
* Remove ignored constness
* Connection: Improve window size range limits
This commit is contained in:
SmallJoker
2021-09-27 17:45:44 +02:00
committed by GitHub
parent 918fbe3ec1
commit d51d0f3a5a
11 changed files with 40 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/client/camera.cpp
View File

@ -378,7 +378,8 @@ void Camera::update(LocalPlayer* player, f32 frametime, f32 busytime, f32 tool_r
// Smoothen and invert the above
fall_bobbing = sin(fall_bobbing * 0.5 * M_PI) * -1;
// Amplify according to the intensity of the impact
fall_bobbing *= (1 - rangelim(50 / player->camera_impact, 0, 1)) * 5;
if (player->camera_impact > 0.0f)
fall_bobbing *= (1 - rangelim(50 / player->camera_impact, 0, 1)) * 5;
fall_bobbing *= m_cache_fall_bobbing_amount;
}

8
src/client/client.h
View File

@ -334,13 +334,13 @@ public:
// disconnect client when CSM failed.
const std::string &accessDeniedReason() const { return m_access_denied_reason; }
const bool itemdefReceived() const
bool itemdefReceived() const
{ return m_itemdef_received; }
const bool nodedefReceived() const
bool nodedefReceived() const
{ return m_nodedef_received; }
const bool mediaReceived() const
bool mediaReceived() const
{ return !m_media_downloader; }
const bool activeObjectsReceived() const
bool activeObjectsReceived() const
{ return m_activeobjects_received; }
u16 getProtoVersion()

2
src/client/gameui.h
View File

@ -84,7 +84,7 @@ public:
void showTranslatedStatusText(const char *str);
inline void clearStatusText() { m_statustext.clear(); }
const bool isChatVisible()
bool isChatVisible()
{
return m_flags.show_chat && m_recent_chat_count != 0 && m_profiler_current_page == 0;
}