From e7f33ee2f1c57b2b5c48d1a54a5f9e4c72a3275c Mon Sep 17 00:00:00 2001
From: SmallJoker <mk939@ymail.com>
Date: Mon, 21 Sep 2020 19:10:44 +0200
Subject: [PATCH] Settings: Fix crash on exit due to group double-free

---
 src/settings.cpp | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/settings.cpp b/src/settings.cpp
index 55404319e..473a216bf 100644
--- a/src/settings.cpp
+++ b/src/settings.cpp
@@ -824,13 +824,21 @@ bool Settings::setDefault(const std::string &name, const std::string &value)
 
 bool Settings::setGroup(const std::string &name, Settings *group)
 {
-	return setEntry(name, &group, true, false);
+	// Settings must own the group pointer
+	// avoid double-free by copying the source
+	Settings *copy = new Settings();
+	*copy = *group;
+	return setEntry(name, &copy, true, false);
 }
 
 
 bool Settings::setGroupDefault(const std::string &name, Settings *group)
 {
-	return setEntry(name, &group, true, true);
+	// Settings must own the group pointer
+	// avoid double-free by copying the source
+	Settings *copy = new Settings();
+	*copy = *group;
+	return setEntry(name, &copy, true, true);
 }