Commit Graph

17 Commits

Author SHA1 Message Date
kilbith 8cf26bb0bb Mainmenu: Code cleaning 2016-04-20 21:31:40 +10:00
kilbith 65db88d24e Mainmenu: Unify favorite servers with main serverlist 2016-04-20 21:31:40 +10:00
est31 bc4dc80c01 Mainmenu: Still support favorites if send_pre_v25_init is disabled
@SmallJoker has noted a bug that servers from the (local) main menu
favorites list can't be opened.

This commit fixes the bug by disabling any main menu based protocol
checks for servers from the favorite list.

Also, it fixes a second bug that happens when a server from the
public serverlist doesn't send its supported protocol versions,
most likely because its running a minetest older than commit [1].
Then we have shown an error msg that the server has enforced
one specific protocol version. This was most likely not the case.

Of course, we can't do anything better than do an assumption on
the protocol versions if they are not known. That assumption
should however be closest to the most often occuring case as
possible.

Also, some little cleanups.

[1]: 5a0ed780f5 "Server: announce MIN/MAX protocol version supported to serverlist. Client: check serverlist"
2016-04-15 14:40:31 +02:00
Rui914 92d4a73843 Mainmenu: Refactor tab UI code
- Use local variables for tabs in place of globals
 - Merge together if statements where possible
 - Replace manual table searching code with indexof where possible
2016-04-08 02:25:04 -04:00
est31 af30183124 Add option to not send pre v25 init packet
The legacy init packet (pre v25) sends information about the client's
password that a server could use to log in to other servers if the
username and password are the same. All the other benefits of SRP of
protocol v25 are missed if the legacy init packet is still sent during
connection creation.

This patch adds an option to not send the v25 init packet. Not sending
the v25 packet means breaking compat with pre v25 servers, but as the
option is not enabled by default, no servers are affected unless the
user explicitly flips the switch. More than 90% of the servers on the
serverlist support post v25 protocols.

The patch also fixes a bug with greying out of non compliant servers
being done wrongly, the min and max params were mixed.
2016-03-15 17:20:09 +01:00
est31 5a0ed780f5 Server: announce MIN/MAX protocol version supported to serverlist. Client: check serverlist
Client now informs about incompatible servers from the list, this permits to prevent the protocol movements.
Server announces its supported protocol versions to master server
2015-02-18 16:09:59 +01:00
Loic Blot 346652a809 Fix issue #2278, Connection sent before address data loading 2015-02-14 23:23:54 +01:00
ngosang c7a7803780 Minor fixes in translations 2015-02-12 16:41:40 +01:00
kilbith 5cf911ffe1 Small tweaking (alignement - client tab) 2015-01-15 23:25:31 +10:00
jeanpatrick.guerrero@gmail.com 227e4807b4 Reorganizing client and server tabs 2015-01-15 00:50:23 +10:00
sapier 663e42ca3f Fix forgotten favourite list image update of simple menu 2015-01-04 17:37:45 +01:00
Kahrl 581efea60e Remove vertlabels from main menu and relayout a bit 2014-12-13 00:33:38 +01:00
Kahrl 733d3182bd Display serverlist flags as icons 2014-12-13 00:33:38 +01:00
Kahrl d0be823807 Always escape user provided data in mainmenu fields 2014-12-08 07:48:51 +01:00
sapier 2625323f25 Fix menu crash due to lack of favourites list 2014-06-22 14:00:57 +02:00
sapier 1c7cc2665b Fix broken serverdescription in multiplayer tab 2014-06-19 22:03:49 +02:00
sapier c3984569c0 Add formspec toolkit and refactor mainmenu to use it
Fix crash on using cursor keys in client menu without selected server
Add support for non fixed size tabviews
2014-05-16 22:57:14 +02:00