Version MFF.

.gitignore

@@ -1,4 +0,0 @@
-## Generic ignorable patterns and files
-*~
-.*.swp
-debug.txt

.luacheckrc

@@ -1,2 +0,0 @@
-read_globals = {"minetest", "table", "default", "pipeworks"}
-globals = {"connected_chests"}

LICENSE.txt

@@ -1,2 +0,0 @@
-connected_chest_open from default
-Content which is not copied from minetest_game is licensed under MIT.

README.md

@@ -1,20 +0,0 @@
-[Mod] Connected Chests [connected_chests]
-
-This mod allows making bigger default chests.<br/>
-Hold shift and place a chest onto another one's side to get a big chest.<br/>
-This is not the first mod which adds big chests.
-
-**Depends:** see [depends.txt](https://raw.githubusercontent.com/HybridDog/connected_chests/master/depends.txt)<br/>
-**License:** see [LICENSE.txt](https://raw.githubusercontent.com/HybridDog/connected_chests/master/LICENSE.txt)<br/>
-**Download:** [zip](https://github.com/HybridDog/connected_chests/archive/master.zip), [tar.gz](https://github.com/HybridDog/connected_chests/archive/master.tar.gz)
-
-![I'm a screenshot!](http://wiki.minetest.net/images/d/d1/Connected_chest.png)
-
-If you got ideas or found bugs, please tell them to me.
-
-[How to install a mod?](http://wiki.minetest.net/Installing_Mods)
-
-
-TODO:
-* Fix open big chest back side texture: The current .obj mesh model uses a side
-  texture for the back side, so the model needs change.

README.txt

@@ -0,0 +1,2 @@
+TODO:
+— disallow rotating the chest with a screwdriver

depends.txt

@@ -0,0 +1,3 @@
+default
+pipeworks?
+technic?

init.lua

@@ -1,76 +1,48 @@
--- param_tab maps the x and z offset to a param2 value
-local param_tab = {
-	["-1 0"] = 0,
-	 ["1 0"] = 2,
-	["0 -1"] = 3,
-	 ["0 1"] = 1,
+local load_time_start = os.clock()
+
+local creative_enabled = minetest.setting_getbool("creative_mode")
+
+local big_formspec = "size[13,9]"..
+	"list[current_name;main;0,0;13,5;]"..
+	"list[current_player;main;2.5,5.2;8,4;]"..
+	"listring[current_name;main]"..
+	"listring[current_player;main]"
+
+local chests = {
+	["default:chest"] = function(pu, pa, par, stuff)
+		minetest.add_node(pu, {name="connected_chests:chest_left", param2=par})
+		minetest.add_node(pa, {name="connected_chests:chest_right", param2=par})
+
+		local meta = minetest.get_meta(pu)
+		meta:set_string("formspec", big_formspec)
+		meta:set_string("infotext", "Big Chest")
+		local inv = meta:get_inventory()
+		inv:set_size("main", 65)
+		inv:set_list("main", stuff)
+	end,
+	["default:chest_locked"] = function(pu, pa, par, stuff, name, owner)
+		local owner = owner or name
+		minetest.add_node(pu, {name="connected_chests:chest_locked_left", param2=par})
+		minetest.add_node(pa, {name="connected_chests:chest_locked_right", param2=par})
+
+		local meta = minetest.get_meta(pu)
+		meta:set_string("owner", owner)
+		meta:set_string("formspec", big_formspec)
+		meta:set_string("infotext", "Big Locked Chest (owned by "..
+				meta:get_string("owner")..")")
+		local inv = meta:get_inventory()
+		inv:set_size("main", 65)
+		inv:set_list("main", stuff)
+	end,
 }
 
--- param_tab2 maps the other way round
-local param_tab2 = {}
-for n,i in pairs(param_tab) do
-	param_tab2[i] = n:split" "
-end
 
-local function return_remove_next(allowed_name, add_open)
-	local function remove_next(pos, oldnode)
-		-- if the left node had an unexpected rotation, the right one can't be
-		-- found, in this case simply do nothing
-		if oldnode.param2 > 3 then
+local function get_pointed_info(pointed_thing, name)
+	if not pointed_thing then
 		return
 	end
-
-		-- remove the right one if there is one
-		-- (the left one is already removed)
-		local x, z = unpack(param_tab2[oldnode.param2])
-		pos.x = pos.x-x
-		pos.z = pos.z-z
-		local right_n = minetest.get_node(pos).name
-		if right_n == allowed_name
-		or (add_open and right_n == allowed_name .. "_open") then
-			minetest.remove_node(pos)
-		end
-	end
-	return remove_next
-end
-
-
--- used when constructing the left node
-local function return_add_next(right_name)
-	local function add_next(pos, node)
-		node = node or minetest.get_node(pos)
-		local par = node.param2
-
-		-- if the left node is set with an unexpected rotation, put the chest
-		-- with default rotation
-		if par > 3 then
-			minetest.log("action",
-				node.name .. " with invalid param2 found, pos: " ..
-				minetest.pos_to_string(pos) .. ", param2: " .. par)
-			node.param2 = 0
-			minetest.set_node(pos, node)
-			return
-		end
-
-		-- put the right chest if possible
-		local x, z = unpack(param_tab2[par])
-		pos.x = pos.x-x
-		pos.z = pos.z-z
-		if minetest.get_node(pos).name == "air" then
-			minetest.set_node(pos, {name=right_name, param2=par})
-		end
-	end
-	return add_next
-end
-
-
--- gives information about the positions and param to place the nodes
-local function get_pointed_info(pt, name)
-	if not pt then
-		return
-	end
-	local pu = minetest.get_pointed_thing_position(pt)
-	local pa = minetest.get_pointed_thing_position(pt, true)
+	local pu = minetest.get_pointed_thing_position(pointed_thing)
+	local pa = minetest.get_pointed_thing_position(pointed_thing, true)
 	if not pu
 	or not pa
 	or pu.y ~= pa.y then
@@ -83,17 +55,24 @@ local function get_pointed_info(pt, name)
 	return pu, pa, nd_u.param2
 end
 
+local param_tab = {
+	["-1 0"] = 0,
+	 ["1 0"] = 2,
+	["0 -1"] = 3,
+	 ["0 1"] = 1,
+}
 
-
+local param_tab2 = {}
+for n,i in pairs(param_tab) do
+	param_tab2[i] = n
+end
 
 local pars = {[0]=2, 3, 0, 1}
 
-local chestdata = {}
-
-
--- executed when connecting the chests
-local function connect_chests(pu, pa, old_param2, data)
-	local metatable = minetest.get_meta(pu):to_table()
+local function connect_chests(pu, pa, old_param2, name)
+	local oldmeta = minetest.get_meta(pu)
+	local stuff = oldmeta:get_inventory():get_list("main")
+	local owner = oldmeta:get_string("owner")
 
 	local par = param_tab[pu.x-pa.x.." "..pu.z-pa.z]
 	local par_inverted = pars[par]
@@ -102,22 +81,160 @@ local function connect_chests(pu, pa, old_param2, data)
 		par = par_inverted
 	end
 
-	data.on_connect(pu, pa, par, metatable)
+	chests[name](pu, pa, par, stuff, name, owner)
+end
+
+for name,_ in pairs(chests) do
+	local place_chest = minetest.registered_nodes[name].on_place
+	minetest.override_item(name, {
+		on_place = function(itemstack, placer, pointed_thing)
+			if not placer then
+				return
+			end
+			local pu, pa, par2 = get_pointed_info(pointed_thing, name)
+			if not pu
+			or not placer:get_player_control().sneak then
+				return place_chest(itemstack, placer, pointed_thing)
+			end
+			if minetest.is_protected(pa, placer:get_player_name()) then
+				return
+			end
+			connect_chests(pu, pa, par2, name)
+			if not creative_enabled then
+				itemstack:take_item()
+				return itemstack
+			end
+		end
+	})
+end
+
+local function return_remove_next(allowed_name)
+	local function remove_next(pos, oldnode)
+		if oldnode.param2 > 3 then
+			return
+		end
+		local x, z = unpack(string.split(param_tab2[oldnode.param2], " "))
+		pos.x = pos.x-x
+		pos.z = pos.z-z
+		if minetest.get_node(pos).name == allowed_name then
+			minetest.remove_node(pos)
+		end
+	end
+	return remove_next
+end
+
+local function return_add_next(right_name)
+	local function add_next(pos, node)
+		node = node or minetest.get_node(pos)
+		local par = node.param2
+		if par > 3 then
+			node.param2 = 0
+			minetest.set_node(pos, node)
+			return
+		end
+		local x, z = unpack(string.split(param_tab2[par], " "))
+		pos.x = pos.x-x
+		pos.z = pos.z-z
+		if minetest.get_node(pos).name == "air" then
+			minetest.set_node(pos, {name=right_name, param2=par})
+		end
+	end
+	return add_next
 end
 
 
+local function log_access(pos, player, text)
+	minetest.log("action", player:get_player_name()..
+		" moves stuff "..text.." at "..minetest.pos_to_string(pos))
+end
+
+
+-- Adds the big chests
+
+local top_texture = "connected_chests_top.png^default_chest_top.png^([combine:16x16:5,0=default_chest_top.png^connected_chests_frame.png^[makealpha:255,126,126)^connected_chests_top.png"
+local side_texture = "connected_chests_side.png^default_chest_side.png^([combine:16x16:5,0=default_chest_side.png^connected_chests_frame.png^[makealpha:255,126,126)^connected_chests_side.png"
+
+local chest = table.copy(minetest.registered_nodes["default:chest"])
+chest.description = nil
+chest.legacy_facedir_simple = nil
+chest.after_place_node = nil
+chest.on_receive_fields = nil
+chest.tiles = {top_texture, top_texture, "default_obsidian_glass.png",
+	"default_chest_side.png", side_texture.."^[transformFX", side_texture.."^connected_chests_front.png"}
+chest.drop = "default:chest 2"
+chest.selection_box = {
+	type = "fixed",
+	fixed = {
+		{-0.5, -0.5, -0.5, 1.5, 0.5, 0.5},
+	},
+}
+chest.on_construct = return_add_next("connected_chests:chest_right")
+chest.after_destruct = return_remove_next("connected_chests:chest_right")
+chest.on_metadata_inventory_move = function(pos, _, _, _, _, _, player)
+	log_access(pos, player, "in a big chest")
+end
+chest.on_metadata_inventory_put = function(pos, _, _, _, player)
+	log_access(pos, player, "to a big chest")
+end
+chest.on_metadata_inventory_take = function(pos, _, _, _, player)
+	log_access(pos, player, "from a big chest")
+end
+
+minetest.register_node("connected_chests:chest_left", chest)
+
+
+local chest_locked = table.copy(minetest.registered_nodes["default:chest_locked"])
+chest_locked.description = nil
+chest_locked.legacy_facedir_simple = nil
+chest_locked.after_place_node = nil
+chest_locked.on_construct = nil
+chest_locked.on_receive_fields = nil
+chest_locked.tiles = {top_texture, top_texture, "default_obsidian_glass.png",
+	"default_chest_side.png", side_texture.."^[transformFX", side_texture.."^connected_chests_front.png^connected_chests_lock.png"}
+chest_locked.drop = "default:chest_locked 2"
+chest_locked.selection_box = {
+	type = "fixed",
+	fixed = {
+		{-0.5, -0.5, -0.5, 1.5, 0.5, 0.5},
+	},
+}
+chest_locked.on_construct = return_add_next("connected_chests:chest_locked_right")
+chest_locked.after_destruct = return_remove_next("connected_chests:chest_locked_right")
+chest_locked.on_metadata_inventory_move = function(pos, _, _, _, _, _, player)
+	log_access(pos, player, "in a big locked chest")
+end
+chest_locked.on_metadata_inventory_put = function(pos, _, _, _, player)
+	log_access(pos, player, "to a big locked chest")
+end
+chest_locked.on_metadata_inventory_take = function(pos, _, _, _, player)
+	log_access(pos, player, "from a big locked chest")
+end
+chest_locked.on_rightclick = function(pos, _, clicker)
+	local meta = minetest.get_meta(pos)
+	if clicker:get_player_name() == meta:get_string("owner") or clicker:get_player_name() == minetest.setting_get("name") then
+		minetest.show_formspec(
+			clicker:get_player_name(),
+			"connected_chests:chest_locked_left",
+			"size[13,9]"..
+			"list[nodemeta:".. pos.x .. "," .. pos.y .. "," ..pos.z .. ";main;0,0;13,5;]"..
+			"list[current_player;main;2.5,5.2;8,4;]"
+		)
+	end
+end
+
+minetest.register_node("connected_chests:chest_locked_left", chest_locked)
+
+
 local tube_to_left, tube_to_left_locked, tube_update, tube_groups
-if minetest.global_exists"pipeworks" then
+if minetest.global_exists("pipeworks") then
 	tube_to_left_locked = {
 		insert_object = function(pos, node, stack)
-			local x, z = unpack(param_tab2[node.param2])
-			return minetest.get_meta{x=pos.x+x, y=pos.y, z=pos.z+z
-				}:get_inventory():add_item("main", stack)
+			local x, z = unpack(string.split(param_tab2[node.param2], " "))
+			return minetest.get_meta({x=pos.x+x, y=pos.y, z=pos.z+z}):get_inventory():add_item("main", stack)
 		end,
 		can_insert = function(pos, node, stack)
-			local x, z = unpack(param_tab2[node.param2])
-			return minetest.get_meta{x=pos.x+x, y=pos.y, z=pos.z+z
-				}:get_inventory():room_for_item("main", stack)
+			local x, z = unpack(string.split(param_tab2[node.param2], " "))
+			return minetest.get_meta({x=pos.x+x, y=pos.y, z=pos.z+z}):get_inventory():room_for_item("main", stack)
 		end,
 		connect_sides = {right = 1, back = 1, front = 1, bottom = 1, top = 1}
 	}
@@ -132,506 +249,121 @@ else
 	function tube_update() end
 end
 
-
-connected_chests = {chestdata = chestdata}
---[[
-connected_chests.register_chest(<original_node>, {
-	get_formspec = function(metatable, pos)
-		return <formspec_of_big>
-	end,
-	lock = true, -- indicates whether a lock should be added to the texture
-		-- and has an impact on the tube function
-	front = <keyhole_texture>, -- if present, this texture is added to the chest
-		-- front
-	on_rightclick = <func>, -- sets an on_rightclick (some chests need this)
-})
-]]
-
-function connected_chests.register_chest(fromname, data)
-	chestdata[fromname] = data
-
-	--~ local mod, name = fromname:split":"
-	local name_left = fromname .. "_connected_left"
-	local name_right = fromname .. "_connected_right"
-	data.left = name_left
-	data.right = name_right
-
-	-- executed when connecting the chest
-	data.on_connect = function(pu, pa, par, metatable)
-		minetest.add_node(pu, {name=name_left, param2=par})
-		minetest.add_node(pa, {name=name_right, param2=par})
-
-		if not data.add_open_chest then
-			metatable.fields.formspec = data.get_formspec(metatable, pu)
-		end
-		metatable.fields.infotext = "Big " .. metatable.fields.infotext
-		local meta = minetest.get_meta(pu)
-		meta:from_table(metatable)
-		local inv = meta:get_inventory()
-		inv:set_size("main", 65)
-
-	end
-
-	-- override the original node to support connecting
-	local place_chest = minetest.registered_nodes[fromname].on_place
-	local creative_mode = minetest.settings:get_bool"creative_mode"
-	minetest.override_item(fromname, {
-		on_place = function(itemstack, placer, pointed_thing)
-			if not placer
-			or not placer:get_player_control().sneak then
-				return place_chest(itemstack, placer, pointed_thing)
-			end
-			local pu, pa, par2 = get_pointed_info(pointed_thing, fromname)
-			if not pu then
-				return place_chest(itemstack, placer, pointed_thing)
-			end
-			if minetest.is_protected(pa, placer:get_player_name()) then
-				return
-			end
-			connect_chests(pu, pa, par2, data)
-			if not creative_mode then
-				itemstack:take_item()
-				return itemstack
-			end
-		end
-	})
-
-
-	-- Adds the big chest nodes
-
-	-- the left one contains inventory
-	local chest = {}
-	local origdef = minetest.registered_nodes[fromname]
-	for i in pairs(origdef) do
-		chest[i] = rawget(origdef, i)
-	end
-
-	local top = chest.tiles[1]
-	local side = chest.tiles[4]
-	local top_texture = top .. "^([combine:16x16:5,0=" .. top ..
-		"^connected_chests_frame.png^[makealpha:255,126,126)"
-	local side_texture = side .. "^([combine:16x16:5,0=" .. side ..
-		"^connected_chests_frame.png^[makealpha:255,126,126)"
-	local inside_texture
-
-
-	chest.description = "Big " .. chest.description
-	chest.groups = table.copy(chest.groups)
-	chest.groups.not_in_creative_inventory = 1
-	chest.legacy_facedir_simple = nil
-	chest.after_place_node = nil
-	chest.on_receive_fields = nil
-	if data.on_rightclick then
-		chest.on_rightclick = data.on_rightclick
-	end
-
-	-- disallow rotating a connected chest using a screwdriver
-	function chest.on_rotate()
-		return false
-	end
-
-	-- copy pipeworks tube data (if requisite)
-	if chest.tube then
-		chest.tube = table.copy(chest.tube)
-		chest.tube.connect_sides = {left = 1, -- no connection to the right.
-			back = 1, front = 1, bottom = 1, top = 1}
-	end
-
-	if not data.front then
-		data.front = "connected_chests_front.png"
-		if data.lock then
-			data.front = data.front .. "^connected_chests_lock.png"
-		end
-	end
-	chest.tiles = {top_texture, top_texture, "default_obsidian_glass.png",
-		side, side_texture.."^[transformFX", side_texture.."^" .. data.front}
-	chest.drop = (chest.drop or fromname) .. " 2"
-	chest.selection_box = {
-		type = "fixed",
-		fixed = {
-			{-0.5, -0.5, -0.5, 1.5, 0.5, 0.5},
-		},
-	}
-	chest.on_construct = return_add_next(name_right)
-	chest.after_destruct = return_remove_next(name_right, data.add_open_chest)
-
-	if data.add_open_chest then
-		-- mostly copied from default
-		local def_opened = table.copy(chest)
-
-		def_opened.mesh = "connected_chest_open.obj"
-		def_opened.drawtype = "mesh"
-		def_opened.paramtype = "light"
-		for i = 1, #def_opened.tiles do
-			if type(def_opened.tiles[i]) == "string" then
-				def_opened.tiles[i] =
-					{name = def_opened.tiles[i], backface_culling = true}
-			elseif def_opened.tiles[i].backface_culling == nil then
-				def_opened.tiles[i].backface_culling = true
-			end
-		end
-		def_opened.selection_box = {
-			type = "fixed",
-			fixed = {-0.5, -0.5, -0.5, 1.5, 3/16, 0.5},
-		}
-		def_opened.diggable = false
-		def_opened.on_blast = function() end
-		inside_texture = "default_chest_inside.png^([combine:16x32:5,0=" ..
-			"default_chest_inside.png^connected_chests_inside_frame.png^[" ..
-			"makealpha:255,126,126)"
-		-- TODO, see right chest
-		-- here 3 and 4 are swapped and no mirroring is needed…
-		def_opened.tiles[3] = def_opened.tiles[4]
-		def_opened.tiles[3].name = def_opened.tiles[3].name
-		def_opened.tiles[5] = def_opened.tiles[6]
-
-		def_opened.tiles[6] = inside_texture
-
-		minetest.register_node(":" .. name_left.. "_open", def_opened)
-	end
-
-	--~ minetest.register_node("connected_chests:chest_left", chest)
-	minetest.register_node(":" .. name_left, chest)
-
-
-	-- the right one is the deco one
-	local tiles = {top_texture.."^[transformFX", top_texture.."^[transformFX",
-		side, "default_obsidian_glass.png", side_texture, side_texture
-		.. "^" .. data.front .. "^[transformFX"}
-	local right_def = {
-		tiles = tiles,
+minetest.register_node("connected_chests:chest_right", {
+	tiles = {top_texture.."^[transformFX", top_texture.."^[transformFX", "default_chest_side.png",
+		"default_obsidian_glass.png", side_texture, side_texture.."^connected_chests_front.png^[transformFX"},
 	paramtype2 = "facedir",
 	drop = "",
 	pointable = false,
 	diggable = false,
 	on_construct = function(pos)
 		local node = minetest.get_node(pos)
-
-			-- if the right node has an unexpected rotation, try to set it with
-			-- a valid one
 		if node.param2 > 3 then
 			node.param2 = node.param2%4
 			minetest.set_node(pos, node)
 			return
 		end
-
-			-- remove it if the left node can't be found
-			local x, z = unpack(param_tab2[node.param2])
-			local node_left = minetest.get_node{x=pos.x+x, y=pos.y, z=pos.z+z}
-			if node_left.name ~= name_left
+		local x, z = unpack(string.split(param_tab2[node.param2], " "))
+		local node_left = minetest.get_node({x=pos.x+x, y=pos.y, z=pos.z+z})
+		if node_left.name ~= "connected_chests:chest_left"
 		or node_left.param2 ~= node.param2 then
 			minetest.remove_node(pos)
 			return
 		end
-
-			-- connect pipework tubes if there are any
 		tube_update(pos)
 	end,
 	after_destruct = function(pos, oldnode)
-			-- simply remove the right node if it has an unexpected rotation
 		if oldnode.param2 > 3 then
 			return
 		end
-
-			-- add it back if the left node is still there
-			local x, z = unpack(param_tab2[oldnode.param2])
-			local node_left = minetest.get_node{x=pos.x+x, y=pos.y, z=pos.z+z}
-			if node_left.name == name_left
+		local x, z = unpack(string.split(param_tab2[oldnode.param2], " "))
+		local node_left = minetest.get_node({x=pos.x+x, y=pos.y, z=pos.z+z})
+		if node_left.name == "connected_chests:chest_left"
 		and node_left.param2 == oldnode.param2
 		and minetest.get_node(pos).name == "air" then
 			minetest.set_node(pos, oldnode)
 			return
 		end
-
-			-- disconnect pipework tubes if there are any
 		tube_update(pos)
 	end,
-		tube = data.lock and tube_to_left_locked or tube_to_left,
+	tube = tube_to_left,
 	groups = tube_groups,
-	}
+})
 
-	if data.add_open_chest then
-		local def_opened = table.copy(right_def)
-
-		def_opened.mesh = "connected_chest_open.obj"
-		def_opened.drawtype = "mesh"
-		def_opened.paramtype = "light"
-		for i = 1, #def_opened.tiles do
-			if type(def_opened.tiles[i]) == "string" then
-				def_opened.tiles[i] =
-					{name = def_opened.tiles[i], backface_culling = true}
-			elseif def_opened.tiles[i].backface_culling == nil then
-				def_opened.tiles[i].backface_culling = true
+minetest.register_node("connected_chests:chest_locked_right", {
+	tiles = {top_texture.."^[transformFX", top_texture.."^[transformFX", "default_chest_side.png",
+		"default_obsidian_glass.png", side_texture, side_texture.."^connected_chests_front.png^connected_chests_lock.png^[transformFX"},
+	paramtype2 = "facedir",
+	drop = "",
+	pointable = false,
+	diggable = false,
+	on_construct = function(pos)
+		local node = minetest.get_node(pos)
+		if node.param2 > 3 then
+			node.param2 = node.param2%4
+			-- ↓ calls the on_construct from the beginning again
+			minetest.set_node(pos, node)
+			return
 		end
+		local x, z = unpack(string.split(param_tab2[node.param2], " "))
+		local node_left = minetest.get_node({x=pos.x+x, y=pos.y, z=pos.z+z})
+		if node_left.name ~= "connected_chests:chest_locked_left"
+		or node_left.param2 ~= node.param2 then
+			minetest.remove_node(pos)
+			return
 		end
-
-		--~ def_opened.tiles[1] = "default_mese.png" -- top, passt
-		--~ def_opened.tiles[2] = "default_wood.png" -- bottom
-		--~ def_opened.tiles[3] = "default_stone.png" -- right and left side or so
-		--~ def_opened.tiles[4] = "default_obsidian.png" -- back side
-
-		--~ def_opened.tiles[5] = "default_cobble.png" -- front side
-		--~ def_opened.tiles[6] = "default_leaves.png" -- inside
-
-		-- fix right side, somehow
-		def_opened.tiles[4] = def_opened.tiles[3]
-		def_opened.tiles[4].name = def_opened.tiles[4].name .. "^[transformFX"
-
-		-- fix front side
-		def_opened.tiles[5] = def_opened.tiles[6]
-
-		-- add inside
-		def_opened.tiles[6] = inside_texture .. "^[transformFX"
-
-		-- TODO: back side looks like right side
-
-		minetest.register_node(":" .. name_right .. "_open", def_opened)
+		tube_update(pos)
+	end,
+	after_destruct = function(pos, oldnode)
+		if oldnode.param2 > 3 then
+			return
 		end
+		local x, z = unpack(string.split(param_tab2[oldnode.param2], " "))
+		local node_left = minetest.get_node({x=pos.x+x, y=pos.y, z=pos.z+z})
+		if node_left.name == "connected_chests:chest_locked_left"
+		and node_left.param2 == oldnode.param2
+		and minetest.get_node(pos).name == "air" then
+			minetest.set_node(pos, oldnode)
+			return
+		end
+		tube_update(pos)
+	end,
+	tube = tube_to_left_locked,
+	groups = tube_groups,
+})
 
-	minetest.register_node(":" .. name_right, right_def)
-
-
-	-- LBMs to fix half chests if they occur for some reason
-	minetest.register_lbm{
-		label = "Connected Chest fixer " .. name_right,
-		name = ":" .. name_right .. "_reconnect_lbm",
-		nodenames = {name_right},
-		run_at_every_load = true,
+-- abms to fix half chests
+for _,i in pairs({"chest", "chest_locked"}) do
+	minetest.register_abm ({
+		nodenames = {"connected_chests:"..i.."_right"},
+		interval = 10,
+		chance = 1,
 		action = function (pos, node)
 			if node.param2 > 3 then
 				node.param2 = node.param2%4
 				minetest.set_node(pos, node)
 				return
 			end
-			local x, z = unpack(param_tab2[node.param2])
-			local left_node = minetest.get_node{x=pos.x+x, y=pos.y, z=pos.z+z}
-			if left_node.name ~= name_left
+			local x, z = unpack(string.split(param_tab2[node.param2], " "))
+			local left_node = minetest.get_node({x=pos.x+x, y=pos.y, z=pos.z+z})
+			if left_node.name ~= "connected_chests:"..i.."_left"
 			or left_node.param2 ~= node.param2 then
 				minetest.remove_node(pos)
 			end
 		end,
-	}
-	minetest.register_lbm{
-		label = "Connected Chest fixer " .. name_left,
-		name = ":" .. name_left .. "_reconnect_lbm",
-		nodenames = {name_left},
-		run_at_every_load = true,
-		action = return_add_next(name_right),
-	}
-end
-
-
-local function get_chest_formspec(pos)
-	local spos = pos.x .. "," .. pos.y .. "," .. pos.z
-	local formspec =
-		"size[13,9]" ..
-		"list[nodemeta:" .. spos .. ";main;0,0;13,5;]" ..
-		"list[current_player;main;2.5,5.2;8,4;]" ..
-		"listring[nodemeta:" .. spos .. ";main]" ..
-		"listring[current_player;main]"
-	return formspec
-end
-
-local open_chests = {} -- counter for players viewing the chest
-local accessed_chests = {} -- position of the chest a player views
-
--- a hacky way to close open connected default chests
--- vi: vector index of the position of the left chest
-local function close_chest(vi)
-	local pos = minetest.get_position_from_hash(vi)
-	local node = minetest.get_node(pos)
-	local is_locked = node.name == "default:chest_locked_connected_left_open"
-	if node.name ~= "default:chest_connected_left_open"
-	and not is_locked then
-		return
-	end
-	if is_locked then
-		node.name = "default:chest_locked_connected_left"
-	else
-		node.name = "default:chest_connected_left"
-	end
-	minetest.swap_node(pos, node)
-
-	-- close the right chest
-	-- TODO: test for valid rotation
-	local x, z = unpack(param_tab2[node.param2])
-	pos.x = pos.x-x
-	pos.z = pos.z-z
-	node = minetest.get_node(pos)
-	if is_locked then
-		if node.name == "default:chest_locked_connected_right_open" then
-			node.name = "default:chest_locked_connected_right"
-			minetest.swap_node(pos, node)
-		end
-	else
-		if node.name == "default:chest_connected_right_open" then
-			node.name = "default:chest_connected_right"
-			minetest.swap_node(pos, node)
-		end
-	end
-	pos.x = pos.x + x * 0.5
-	pos.z = pos.z + z * 0.5
-	minetest.sound_play("default_chest_close",
-		{gain = 0.3, pos = pos, max_hear_distance = 10, pitch = 0.7}, true)
-end
-
--- close all remaining open chest on shutdown
-minetest.register_on_shutdown(function()
-	for vi in pairs(open_chests) do
-		close_chest(vi)
-	end
-	open_chests = nil
-end)
-
--- close open chests when the last player exits formspec
-minetest.register_on_player_receive_fields(function(player, formname, fields)
-	if formname ~= "default:chest_connected"
-	and formname ~= "default:chest_locked_connected" then
-		return
-	end
-	if not player
-	or not fields.quit then
-		return
-	end
-	local pn = player:get_player_name()
-	local vi = accessed_chests[pn]
-	if not vi then
-		minetest.log("warning", pn .. " opened a chest without lid?")
-		return
-	end
-	accessed_chests[pn] = nil
-
-	local cnt = open_chests[vi]
-	if cnt == 1 then
-		close_chest(vi)
-		open_chests[vi] = nil
-	else
-		open_chests[vi] = cnt-1
-	end
-
-	return true
-end)
-
-local chest_lid_obstructed = default.chest
-	and default.chest.chest_lid_obstructed
-connected_chests.register_chest("default:chest", {
-	add_open_chest = true,
-	on_rightclick = function(pos, _, player)
-		minetest.sound_play("default_chest_open",
-			{gain = 0.3, pos = pos, max_hear_distance = 10, pitch = 0.7}, true)
-
-		local vi = minetest.hash_node_position(pos)
-		if not open_chests[vi]
-		and not chest_lid_obstructed(pos) then
-			local left_param2 = minetest.get_node(pos).param2
-
-			-- TODO: test for invalid param2 values
-			local x, z = unpack(param_tab2[left_param2])
-			local pos_right = {x=pos.x-x, y=pos.y, z=pos.z-z}
-			local node = minetest.get_node(pos_right)
-			if node.name == "default:chest_connected_right"
-			and not chest_lid_obstructed(pos_right) then
-				minetest.swap_node(pos, {
-					name = "default:chest_connected_left_open",
-					param2 = left_param2})
-				minetest.swap_node(pos_right, {
-					name = "default:chest_connected_right_open",
-					param2 = node.param2})
-			end
-		end
-
-		local pname = player:get_player_name()
-		local spec = get_chest_formspec(pos)
-
-		minetest.after(0.2, minetest.show_formspec, pname,
-			"default:chest_connected", spec)
-
-		if not accessed_chests[pname] then
-			open_chests[vi] = open_chests[vi] or 0
-			open_chests[vi] = open_chests[vi]+1
-
-			accessed_chests[pname] = vi
-		end
-	end
 	})
-
-connected_chests.register_chest("default:chest_locked", {
-	lock = true,
-	add_open_chest = true,
-	on_rightclick = function(pos, _, player)
-		if not default.can_interact_with_node(player, pos) then
-			minetest.sound_play("default_chest_locked", {pos = pos}, true)
-			return
-		end
-
-		minetest.sound_play("default_chest_open",
-			{gain = 0.32, pos = pos, max_hear_distance = 10, pitch = 0.7}, true)
-
-		local vi = minetest.hash_node_position(pos)
-		-- TODO: somehow avoid using the chest node names here
-		if not open_chests[vi]
-		and not chest_lid_obstructed(pos) then
-			local left_param2 = minetest.get_node(pos).param2
-
-			-- TODO: test for invalid param2 values
-			local x, z = unpack(param_tab2[left_param2])
-			local pos_right = {x=pos.x-x, y=pos.y, z=pos.z-z}
-			local node = minetest.get_node(pos_right)
-			if node.name == "default:chest_locked_connected_right"
-			and not chest_lid_obstructed(pos_right) then
-				minetest.swap_node(pos_right, {
-					name = "default:chest_locked_connected_right_open",
-					param2 = node.param2})
-				minetest.swap_node(pos, {
-					name = "default:chest_locked_connected_left_open",
-					param2 = left_param2})
-			end
-		end
-
-		local pname = player:get_player_name()
-		local spec = get_chest_formspec(pos)
-
-		minetest.after(0.2, minetest.show_formspec, pname,
-			"default:chest_locked_connected", spec)
-
-		if not accessed_chests[pname] then
-			open_chests[vi] = open_chests[vi] or 0
-			open_chests[vi] = open_chests[vi]+1
-
-			accessed_chests[pname] = vi
-		end
-	end
+	minetest.register_abm ({
+		nodenames = {"connected_chests:"..i.."_left"},
+		interval = 3,
+		chance = 1,
+		action = return_add_next("connected_chests:"..i.."_right"),
 	})
-
-
-
--- legacy
-
--- the default chest lid obstruction function wasn't exposed in minetest 0.4.16
-if not chest_lid_obstructed then
-	-- copied from default's nodes.lua
-	function chest_lid_obstructed(pos)
-		local above = {x = pos.x, y = pos.y + 1, z = pos.z}
-		local def = minetest.registered_nodes[minetest.get_node(above).name]
-		-- allow ladders, signs, wallmounted things and torches to not obstruct
-		if def and
-				(def.drawtype == "airlike" or
-				def.drawtype == "signlike" or
-				def.drawtype == "torchlike" or
-				(def.drawtype == "nodebox" and def.paramtype2 == "wallmounted")) then
-			return false
-		end
-		return true
-	end
 end
 
--- once the connected_chests mod supported only default chests and used
--- different node names
-minetest.register_alias("connected_chests:chest_left",
-	"default:chest_connected_left")
-minetest.register_alias("connected_chests:chest_right",
-	"default:chest_connected_right")
-minetest.register_alias("connected_chests:chest_left_locked", "default:chest_locked_connected_left")
-minetest.register_alias("connected_chests:chest_right_locked", "default:chest_locked_connected_right")
-minetest.register_alias("connected_chests:chest_locked_left", "default:chest_locked_connected_left")
-minetest.register_alias("connected_chests:chest_locked_right", "default:chest_locked_connected_right")
+local time = math.floor(tonumber(os.clock()-load_time_start)*100+0.5)/100
+local msg = "[connected_chests] loaded after ca. "..time
+if time > 0.05 then
+	print(msg)
+else
+	minetest.log("info", msg)
+end

mod.conf

@@ -1,3 +0,0 @@
-name = connected_chests
-depends = default
-optional_depends = pipeworks,technic

models/connected_chest_open.obj

@@ -1,79 +0,0 @@
-# Blender v2.78 (sub 0) OBJ File: 'chest-open.blend'
-# www.blender.org
-o Top_Cube.002_None_Top_Cube.002_None_bottom
-v -0.500000 0.408471 0.720970
-v -0.500000 1.115578 0.013863
-v -0.500000 0.894607 -0.207108
-v -0.500000 0.187501 0.499999
-v 0.500000 1.115578 0.013863
-v 0.500000 0.408471 0.720970
-v 0.500000 0.187501 0.499999
-v 0.500000 0.894607 -0.207108
-v -0.500000 0.187500 -0.500000
-v -0.500000 -0.500000 -0.500000
-v -0.500000 -0.500000 0.500000
-v 0.500000 0.187500 -0.500000
-v 0.500000 -0.500000 0.500000
-v 0.500000 -0.500000 -0.500000
-vt 0.0000 1.0000
-vt 0.0000 0.0000
-vt 1.0000 0.0000
-vt 1.0000 1.0000
-vt 1.0000 0.0000
-vt 1.0000 1.0000
-vt 0.0000 1.0000
-vt 0.0000 0.0000
-vt 0.0000 1.0000
-vt 1.0000 1.0000
-vt 1.0000 0.6875
-vt 0.0000 0.6875
-vt 1.0000 1.0000
-vt 0.0000 0.6875
-vt 1.0000 0.6875
-vt 1.0000 0.6875
-vt 1.0000 0.0000
-vt 0.0000 0.0000
-vt 1.0000 0.6875
-vt 1.0000 0.0000
-vt 1.0000 1.0000
-vt 1.0000 0.6875
-vt 1.0000 0.0000
-vt 0.0000 1.0000
-vt 0.0000 0.6875
-vt 0.0000 0.6875
-vt 0.0000 0.0000
-vt 1.0000 0.5000
-vt 1.0000 1.0000
-vt 0.0000 1.0000
-vt 0.0000 0.5000
-vt 0.0000 0.0000
-vt 1.0000 0.0000
-vn 0.0000 0.7071 0.7071
-vn -0.0000 -1.0000 -0.0000
-vn -1.0000 0.0000 0.0000
-vn 1.0000 0.0000 -0.0000
-vn 0.0000 -0.7071 0.7071
-vn 0.0000 0.0000 1.0000
-vn -0.0000 0.7071 -0.7071
-vn -0.0000 0.0000 -1.0000
-vn -0.0000 -0.7071 -0.7071
-vn -0.0000 1.0000 -0.0000
-g Top_Cube.002_None_Top_Cube.002_None_bottom_Top_Cube.002_None_Top_Cube.002_None_bottom_Top
-s off
-f 6/1/1 5/2/1 2/3/1 1/4/1
-g Top_Cube.002_None_Top_Cube.002_None_bottom_Top_Cube.002_None_Top_Cube.002_None_bottom_Bottom
-f 11/5/2 10/6/2 14/7/2 13/8/2
-g Top_Cube.002_None_Top_Cube.002_None_bottom_Top_Cube.002_None_Top_Cube.002_None_bottom_Right-Left
-f 1/9/3 2/10/3 3/11/3 4/12/3
-f 5/13/4 6/1/4 7/14/4 8/15/4
-f 4/12/3 9/16/3 10/17/3 11/18/3
-f 12/19/4 7/14/4 13/8/4 14/20/4
-g Top_Cube.002_None_Top_Cube.002_None_bottom_Top_Cube.002_None_Top_Cube.002_None_bottom_Back
-f 6/21/5 1/9/5 4/12/5 7/22/5
-f 7/22/6 4/12/6 11/18/6 13/23/6
-g Top_Cube.002_None_Top_Cube.002_None_bottom_Top_Cube.002_None_Top_Cube.002_None_bottom_Front
-f 2/10/7 5/24/7 8/25/7 3/11/7
-f 9/16/8 12/26/8 14/27/8 10/17/8
-g Top_Cube.002_None_Top_Cube.002_None_bottom_Top_Cube.002_None_Top_Cube.002_None_bottom_Inside
-f 4/28/9 3/29/9 8/30/9 7/31/9
-f 7/31/10 12/32/10 9/33/10 4/28/10