Mineclone compatibility (#36)

* latest versions of mapgen_helper and subterrane

* initial work

* call it "minetest_game" compatibility instead of "default" compatibility

* Getting started on moving all default dependencies to a single root mod

* distilling out more dependencies

* fix some typos

* more default dependencies

* beds

* start getting some MCL equivalents set up

* mine gas dependencies

* reorganize

* add some mapgen stuff

* getting close to actually being able to run mineclone with this

* it actually runs! Crashes with out-of-memory error when you try to go below -64, but it's a start.

* hide flowing pit plasma from creative inventory

* mineclone 5 settings

* Update subterrane

* get rid of meselamp dependency, bring in ancient lanterns from deep roads

* stair dependencies

* add mcl fences

* add mcl blast resistance and hardness to everything. Also an alternate name for Nethercap in MCL, since "nether" has another meaning there.

* buckets of oil and syrup should work in mineclone now

* 'splosions!

* make hunters avoid repaired ancient lanterns

* mapgen torchspine wasn't having its timer set

* split mapgen compatibility code into its own file

* bypass dependency indirection for df_farming.

* apply threshold alpha to food items, they look better that way

* bypass dependency indirection for df_mapitems

* bypass dependency indirection for df_primordial_items

* bypass dependency indirection for df_trees

* bypass dependency indirection for df_underworld_items

* bypass dependency indirection for df_caverns

* fixing up the puzzle seal to work in both

* fix puzzle seal formspec for mcl

* create built-in substitutes for fireflies and bones mods for when those aren't available

* set up mcl dungeon loot for underworld warriors, port over some translations from default

* overlooked a debug

* add itemslot backgrounds for mcl

* added mineclone groups to all registered nodes. TODO: craftitems.

This was extremely tedious. Completely untested, aside from simply running the game.

* minor fixes to the built-in bones node

* eatable group for edibles

* clean up some TODOs

* adjust pit plasma abm conditions

* add df_ambience

* fixing up explosions. Also make slade sand diggable in mcl, and fix a bug in web generators

* make tower cap caves less chirpy, fix bigger goblin hut schematic, allow glowing spindlestem extract bottles

* avoid an undeclared global check

* alas, cave pearls aren't set up right for attached_node_facedir.

* bunch of work on mineclone ores, moved main config into df_dependencies

* add a few more ores

* update depends in mod.conf

* add opaque group to light-sensitive dirt types

Mineclone adds the "opaque" group only to non-light nodes, and torches check for the opaque group to decide whether they can be placed there. light-sensitive nodes need the "light" paramtype to work, though. So adding the opaque group manually to these.

* add a touch of reverb to one of the whisper tracks, it didn't fit with the others without it

* bloodthorn also needs to be set opaque

* add sound to torchspines

* isolate Nethercap translation name to make it easier to swap out in Mineclone contexts

* ambience tweak

* fix dirt spreads

https://github.com/FaceDeer/dfcaverns/issues/35

* adding achievements! Almost all untested yet.

* fix a few achievements glitches

* tweak some more achievements, add delay when achievements unlock other achievements

* fix farming achievements, fix spindlestem callbacks on place

* icons for farming achievements

* more achievement icons, fix ancient lantern achievement

* two more icons, update text

* add icons for upper cavern layers

* all achievements have icons now. Also add another sound to the magma sea ambience

* hook into awards' trigger system to get "x/y" progress displayed for the multi-achievement achievements

* ironically, Mineclone has an old version of awards that is incompatible with my trigger work.

* every award should now have a description and a difficulty.

* removing leftovers

* missing callbacks for farmables

* put growth restrictions on farmables so the achievement doesn't trigger inappropriately.

* enable ores in MCL2, fix some undeclared globals, fix icecap growth in MCL (achievements are a good debugging tool)

* get *all* the copper and iron containing nodes

* fix old awards mod's handling of grouped dig items

* Add a little bonus for players who activate a slade breacher - a handheld 'splosion tool

* used the wrong drop method

* beef up explosions in MCL, make slade brick craftable from slade sand and lava

* better creative mode checks, fix crash when digging walls in MCL

* Update subterrane

* various bugfixes and tweaks

* whipping up a simple puzzle chest to give a clue about ancient numbering

The coding is done, but UI and a node mesh need to be done

* prepare for some art tomorrow

* chest node and sounds

* images for the combination dials

* add puzzle chests to the underworld buildings

* update translations

* oops, can't initialize the contents of puzzle chests every time or players get endless stuff

* add backgrounds to item slots in MCL

* wrap the existing function rather than copy and pasting it

* fix bucket dependency in cooking recipes

* add _mcl_saturation to edibles

df_trees/spindlestem.lua

@@ -1,12 +1,22 @@
 local S = minetest.get_translator(minetest.get_current_modname())
 
-local vessels = minetest.get_modpath("vessels")
+local glass_bottle = df_dependencies.node_name_glass_bottle
 
 -- pre-declare
 local get_spindlestem_cap_type
 
 -- Copied from subterrane's features.lua
 -- Figured that was nicer than adding a dependency for just this little bit
+
+local function copy_pointed_thing(pointed_thing)
+	return {
+		type  = pointed_thing.type,
+		above = pointed_thing.above and vector.copy(pointed_thing.above),
+		under = pointed_thing.under and vector.copy(pointed_thing.under),
+		ref   = pointed_thing.ref,
+	}
+end
+
 local stem_on_place = function(itemstack, placer, pointed_thing)
 	local pt = pointed_thing
 	-- check if pointing at a node
@@ -43,8 +53,24 @@ local stem_on_place = function(itemstack, placer, pointed_thing)
 	end
 
 	-- add the node and remove 1 item from the itemstack
-	minetest.add_node(pt.above, {name = itemstack:get_name(), param2 = new_param2})
-	if not minetest.settings:get_bool("creative_mode", false) then
+	local newnode= {name = itemstack:get_name(), param2 = new_param2, param1=0}
+	local oldnode= minetest.get_node(pt.above)
+	minetest.add_node(pt.above, newnode)
+	
+	-- Run script hook
+	local take_item = true
+	for _, callback in ipairs(core.registered_on_placenodes) do
+		-- Deepcopy pos, node and pointed_thing because callback can modify them
+		local place_to_copy = vector.copy(pt.above)
+		local newnode_copy = {name=newnode.name, param1=newnode.param1, param2=newnode.param2}
+		local oldnode_copy = {name=oldnode.name, param1=oldnode.param1, param2=oldnode.param2}
+		local pointed_thing_copy = copy_pointed_thing(pointed_thing)
+		if callback(place_to_copy, newnode_copy, placer, oldnode_copy, itemstack, pointed_thing_copy) then
+			take_item = false
+		end
+	end
+	
+	if not minetest.is_creative_enabled(placer:get_player_name()) and take_item then
 		itemstack:take_item()
 	end
 	return itemstack
@@ -63,8 +89,8 @@ minetest.register_node("df_trees:spindlestem_stem", {
 	_doc_items_longdesc = df_trees.doc.spindlestem_desc,
 	_doc_items_usagehelp = df_trees.doc.spindlestem_usage,
 	is_ground_content = false,
-	groups = {wood = 1, choppy = 2, oddly_breakable_by_hand = 1, flammable = 2, spindlestem = 1},
-	sounds = df_trees.sounds.wood,
+	groups = {wood = 1, choppy = 2, oddly_breakable_by_hand = 1, flammable = 2, spindlestem = 1, handy=1,axey=1, building_block=1, material_wood=1, fire_encouragement=5, fire_flammability=5},
+	sounds = df_dependencies.sound_wood(),
 	tiles = {
 		"dfcaverns_tower_cap.png",
 	},
@@ -80,6 +106,8 @@ minetest.register_node("df_trees:spindlestem_stem", {
 		}
 	},
 	on_place = stem_on_place,
+	_mcl_blast_resistance = 2,
+	_mcl_hardness = 2,
 })
 
 minetest.register_craft({
@@ -97,8 +125,8 @@ local register_spindlestem_type = function(item_suffix, colour_name, colour_code
 		is_ground_content = false,
 		_doc_items_longdesc = df_trees.doc["spindlestem_cap_"..item_suffix.."_desc"],
 		_doc_items_usagehelp = df_trees.doc["spindlestem_cap_"..item_suffix.."_usage"],
-		groups = {wood = 1, choppy = 2, oddly_breakable_by_hand = 1, flammable = 2, spindlestem = 1, not_in_creative_inventory = 1},
-		sounds = df_trees.sounds.wood,
+		groups = {wood = 1, choppy = 2, oddly_breakable_by_hand = 1, flammable = 2, spindlestem = 1, not_in_creative_inventory = 1, handy=1,axey=1, building_block=1, material_wood=1, fire_encouragement=5, fire_flammability=5},
+		sounds = df_dependencies.sound_wood(),
 		tiles = {
 			"dfcaverns_tower_cap.png^[multiply:#"..colour_code,
 			"dfcaverns_spindlestem_cap.png^[multiply:#"..colour_code,
@@ -121,6 +149,8 @@ local register_spindlestem_type = function(item_suffix, colour_name, colour_code
 				{-0.1875+disp, -0.3125, -0.1875+disp, 0.3125+disp, -0.1875, 0.3125+disp},
 			}
 		},
+		_mcl_blast_resistance = 2,
+		_mcl_hardness = 2,
 		
 		drop = {
             -- Maximum number of items to drop
@@ -201,11 +231,11 @@ local register_spindlestem_type = function(item_suffix, colour_name, colour_code
 		burntime = 10,
 	})
 	
-	if vessels and light_level > 0 then
-		local tex = "dfcaverns_vessels_glowing_liquid.png^[multiply:#"..colour_code.."^vessels_glass_bottle.png"
+	if glass_bottle and light_level > 0 then
+		local tex = "dfcaverns_vessels_glowing_liquid.png^[multiply:#"..colour_code.."^"..df_dependencies.texture_glass_bottle
 		local new_light = light_level + math.floor((minetest.LIGHT_MAX-light_level)/2)
 		
-		local groups = {vessel = 1, dig_immediate = 3, attached_node = 1}
+		local groups = {vessel = 1, dig_immediate = 3, attached_node = 1, material_glass = 1, destroy_by_lava_flow=1}
 		if extract_color_group then
 			groups[extract_color_group] = 1
 		end
@@ -226,23 +256,25 @@ local register_spindlestem_type = function(item_suffix, colour_name, colour_code
 				fixed = {-0.25, -0.5, -0.25, 0.25, 0.3, 0.25}
 			},
 			groups = groups,
-			sounds = df_trees.sounds.glass,
+			sounds = df_dependencies.sound_glass(),
 			light_source = new_light,
+			_mcl_blast_resistance = 0.5,
+			_mcl_hardness = 0.5,
 		})
 		
 		minetest.register_craft( {
 			output = "df_trees:glowing_bottle_"..item_suffix.." 3",
 			type = "shapeless",
 			recipe = {
-				"vessels:glass_bottle",
-				"vessels:glass_bottle",
-				"vessels:glass_bottle",
+				glass_bottle,
+				glass_bottle,
+				glass_bottle,
 				cap_item_harvested,
 			}
 		})
 
 		minetest.register_craft( {
-			output = "vessels:glass_bottle",
+			output = glass_bottle,
 			type = "shapeless",
 			recipe = {
 				"df_trees:glowing_bottle_"..item_suffix,
@@ -258,7 +290,7 @@ minetest.register_node("df_trees:spindlestem_seedling", {
 	tiles = {
 		"dfcaverns_tower_cap.png",
 	},
-	groups = {snappy = 3, flammable = 2, plant = 1, attached_node = 1, light_sensitive_fungus = 11, digtron_on_place=1},
+	groups = {snappy = 3, flammable = 2, plant = 1, attached_node = 1, light_sensitive_fungus = 11, digtron_on_place=1, dig_immediate=3,dig_by_piston=1,destroy_by_lava_flow=1,deco_block=1, compostability=30},
 	drawtype = "nodebox",
 	paramtype = "light",
 	paramtype2 = "facedir",
@@ -271,6 +303,8 @@ minetest.register_node("df_trees:spindlestem_seedling", {
 			{-0.0625 + 0.125, -0.5, -0.125 + 0.125, 0.125 + 0.125, -0.375, 0.0625 + 0.125},
 		}
 	},
+	_mcl_blast_resistance = 0.2,
+	_mcl_hardness = 0.2,
 	
 	on_place = stem_on_place,
 	on_construct = function(pos)
@@ -351,6 +385,10 @@ local c_green = minetest.get_content_id("df_trees:spindlestem_cap_green")
 local c_cyan = minetest.get_content_id("df_trees:spindlestem_cap_cyan")
 local c_golden = minetest.get_content_id("df_trees:spindlestem_cap_golden")
 
+local iron_nodes = df_dependencies.data_iron_containing_nodes
+local copper_nodes = df_dependencies.data_copper_containing_nodes
+local mese_nodes = df_dependencies.data_mese_containing_nodes
+
 get_spindlestem_cap_type = function(pos)
 	if minetest.find_node_near(pos, 15, "group:tower_cap") then
 		return c_white
@@ -359,9 +397,9 @@ get_spindlestem_cap_type = function(pos)
 		return c_red
 	end
 	
-	local iron = minetest.find_node_near(pos, 5, df_trees.iron_containing_nodes)
-	local copper = minetest.find_node_near(pos, 5, df_trees.copper_containing_nodes)
-	local mese = minetest.find_node_near(pos, 5, df_trees.mese_containing_nodes)
+	local iron = minetest.find_node_near(pos, 5, iron_nodes)
+	local copper = minetest.find_node_near(pos, 5, copper_nodes)
+	local mese = minetest.find_node_near(pos, 5, mese_nodes)
 	local possibilities = {}
 
 	if mese then table.insert(possibilities, c_golden) end