Mineclone compatibility (#36)

* latest versions of mapgen_helper and subterrane

* initial work

* call it "minetest_game" compatibility instead of "default" compatibility

* Getting started on moving all default dependencies to a single root mod

* distilling out more dependencies

* fix some typos

* more default dependencies

* beds

* start getting some MCL equivalents set up

* mine gas dependencies

* reorganize

* add some mapgen stuff

* getting close to actually being able to run mineclone with this

* it actually runs! Crashes with out-of-memory error when you try to go below -64, but it's a start.

* hide flowing pit plasma from creative inventory

* mineclone 5 settings

* Update subterrane

* get rid of meselamp dependency, bring in ancient lanterns from deep roads

* stair dependencies

* add mcl fences

* add mcl blast resistance and hardness to everything. Also an alternate name for Nethercap in MCL, since "nether" has another meaning there.

* buckets of oil and syrup should work in mineclone now

* 'splosions!

* make hunters avoid repaired ancient lanterns

* mapgen torchspine wasn't having its timer set

* split mapgen compatibility code into its own file

* bypass dependency indirection for df_farming.

* apply threshold alpha to food items, they look better that way

* bypass dependency indirection for df_mapitems

* bypass dependency indirection for df_primordial_items

* bypass dependency indirection for df_trees

* bypass dependency indirection for df_underworld_items

* bypass dependency indirection for df_caverns

* fixing up the puzzle seal to work in both

* fix puzzle seal formspec for mcl

* create built-in substitutes for fireflies and bones mods for when those aren't available

* set up mcl dungeon loot for underworld warriors, port over some translations from default

* overlooked a debug

* add itemslot backgrounds for mcl

* added mineclone groups to all registered nodes. TODO: craftitems.

This was extremely tedious. Completely untested, aside from simply running the game.

* minor fixes to the built-in bones node

* eatable group for edibles

* clean up some TODOs

* adjust pit plasma abm conditions

* add df_ambience

* fixing up explosions. Also make slade sand diggable in mcl, and fix a bug in web generators

* make tower cap caves less chirpy, fix bigger goblin hut schematic, allow glowing spindlestem extract bottles

* avoid an undeclared global check

* alas, cave pearls aren't set up right for attached_node_facedir.

* bunch of work on mineclone ores, moved main config into df_dependencies

* add a few more ores

* update depends in mod.conf

* add opaque group to light-sensitive dirt types

Mineclone adds the "opaque" group only to non-light nodes, and torches check for the opaque group to decide whether they can be placed there. light-sensitive nodes need the "light" paramtype to work, though. So adding the opaque group manually to these.

* add a touch of reverb to one of the whisper tracks, it didn't fit with the others without it

* bloodthorn also needs to be set opaque

* add sound to torchspines

* isolate Nethercap translation name to make it easier to swap out in Mineclone contexts

* ambience tweak

* fix dirt spreads

https://github.com/FaceDeer/dfcaverns/issues/35

* adding achievements! Almost all untested yet.

* fix a few achievements glitches

* tweak some more achievements, add delay when achievements unlock other achievements

* fix farming achievements, fix spindlestem callbacks on place

* icons for farming achievements

* more achievement icons, fix ancient lantern achievement

* two more icons, update text

* add icons for upper cavern layers

* all achievements have icons now. Also add another sound to the magma sea ambience

* hook into awards' trigger system to get "x/y" progress displayed for the multi-achievement achievements

* ironically, Mineclone has an old version of awards that is incompatible with my trigger work.

* every award should now have a description and a difficulty.

* removing leftovers

* missing callbacks for farmables

* put growth restrictions on farmables so the achievement doesn't trigger inappropriately.

* enable ores in MCL2, fix some undeclared globals, fix icecap growth in MCL (achievements are a good debugging tool)

* get *all* the copper and iron containing nodes

* fix old awards mod's handling of grouped dig items

* Add a little bonus for players who activate a slade breacher - a handheld 'splosion tool

* used the wrong drop method

* beef up explosions in MCL, make slade brick craftable from slade sand and lava

* better creative mode checks, fix crash when digging walls in MCL

* Update subterrane

* various bugfixes and tweaks

* whipping up a simple puzzle chest to give a clue about ancient numbering

The coding is done, but UI and a node mesh need to be done

* prepare for some art tomorrow

* chest node and sounds

* images for the combination dials

* add puzzle chests to the underworld buildings

* update translations

* oops, can't initialize the contents of puzzle chests every time or players get endless stuff

* add backgrounds to item slots in MCL

* wrap the existing function rather than copy and pasting it

* fix bucket dependency in cooking recipes

* add _mcl_saturation to edibles

df_underworld_items/slade.lua

@@ -1,4 +1,4 @@
-local S = df_underworld_items.S
+local S = minetest.get_translator(minetest.get_current_modname())
 
 local invulnerable = df_underworld_items.config.invulnerable_slade and not minetest.settings:get_bool("creative_mode")
 
@@ -15,16 +15,20 @@ local add_immortality = function(slade_def)
 	return slade_def
 end
 
+local slade_groups = {cracky=3, stone=1, slade=1, pit_plasma_resistant=1, mese_radiation_shield=1,creative_breakable=1, building_block=1, material_stone=1}
+
 local slade_def = {
 	description = S("Slade"),
 	_doc_items_longdesc = df_underworld_items.doc.slade_desc,
 	_doc_items_usagehelp = df_underworld_items.doc.slade_usage,
 	tiles = {"dfcaverns_slade.png"},
-	groups = {cracky=3, stone=1, level=3, slade=1, pit_plasma_resistant=1, mese_radiation_shield=1},
-	sounds = default.node_sound_stone_defaults({ footstep = { name = "bedrock2_step", gain = 1 } }),
+	groups = slade_groups,
+	sounds = df_dependencies.sound_stone({ footstep = { name = "bedrock2_step", gain = 1 } }),
 	is_ground_content = false,
+	_mcl_blast_resistance = 8,
+	_mcl_hardness = 5,
 	on_blast = function(pos, intensity)
-		if intensity > 3.0 then
+		if intensity >= 1.0 then
 			minetest.set_node(pos, {name="df_underworld_items:slade_sand"})
 			minetest.check_for_falling(pos)
 		end
@@ -32,6 +36,8 @@ local slade_def = {
 }
 if invulnerable then
 	add_immortality(slade_def)
+	slade_def._mcl_blast_resistance = 8
+	slade_def._mcl_hardness = 5
 end
 minetest.register_node("df_underworld_items:slade", slade_def)
 
@@ -40,15 +46,23 @@ local slade_brick_def = {
 	_doc_items_longdesc = df_underworld_items.doc.slade_desc,
 	_doc_items_usagehelp = df_underworld_items.doc.slade_usage,
 	tiles = {"dfcaverns_slade_brick.png"},
-	groups = { cracky=3, stone=1, level=3, slade=1, pit_plasma_resistant=1, mese_radiation_shield=1},
-	sounds = default.node_sound_stone_defaults({ footstep = { name = "bedrock2_step", gain = 1 } }),
+	groups = slade_groups,
+	sounds = df_dependencies.sound_stone({ footstep = { name = "bedrock2_step", gain = 1 } }),
 	is_ground_content = false,
+	_mcl_blast_resistance = 8,
+	_mcl_hardness = 5,
 }
 if invulnerable then
 	add_immortality(slade_brick_def)
 end
 minetest.register_node("df_underworld_items:slade_brick", slade_brick_def)
 
+-- can't use "wall=1" because MCL has special handling for nodes in that group that explodes if it tries handling this one.
+-- fortunately minetest_game walls also connect to group fence, so this should be fine.
+local slade_wall_groups = {fence=1}
+for key, val in pairs(slade_groups) do
+	slade_wall_groups[key]=val
+end
 local slade_wall_def = {
 	description = S("Slade Wall"),
 	drawtype = "nodebox",
@@ -66,25 +80,26 @@ local slade_wall_def = {
 	tiles = {"dfcaverns_slade_brick.png"},
 	walkable = true,
 	is_ground_content = false,
-	groups = { cracky=3, stone=1, level=3, slade=1, pit_plasma_resistant=1, mese_radiation_shield=1},
-	sounds = default.node_sound_stone_defaults({ footstep = { name = "bedrock2_step", gain = 1 } }),
+	groups = slade_wall_groups,
+	sounds = df_dependencies.sound_stone({ footstep = { name = "bedrock2_step", gain = 1 } }),
+	_mcl_blast_resistance = 8,
+	_mcl_hardness = 5,
 }
 if invulnerable then
 	add_immortality(slade_wall_def)
 end
 minetest.register_node("df_underworld_items:slade_wall", slade_wall_def)
 
-
 minetest.register_node("df_underworld_items:slade_sand", {
 	description = S("Slade Sand"),
 	_doc_items_longdesc = df_underworld_items.doc.slade_desc,
 	_doc_items_usagehelp = df_underworld_items.doc.slade_usage,
 	tiles = {"dfcaverns_slade_sand.png"},
 	is_ground_content = false,
-	groups = {crumbly = 3, level = 2, falling_node = 1, slade=1, pit_plasma_resistant=1, mese_radiation_shield=1},
-	sounds = default.node_sound_gravel_defaults({
-		footstep = {name = "default_gravel_footstep", gain = 0.45},
-	}),
+	groups = {crumbly = 3, falling_node = 1, slade=1, pit_plasma_resistant=1, mese_radiation_shield=1,handy=1,shovely=3, sand=1, enderman_takable=1, building_block=1, material_sand=1, crush_after_fall=1, falling_node_damage=1},
+	sounds = df_dependencies.sound_gravel({footstep = {name = df_dependencies.soundfile_gravel_footstep, gain = 0.45},}),
+	_mcl_blast_resistance = 8,
+	_mcl_hardness = 3,
 })
 
 local slade_block_def = {
@@ -92,9 +107,11 @@ local slade_block_def = {
 	_doc_items_longdesc = df_underworld_items.doc.slade_desc,
 	_doc_items_usagehelp = df_underworld_items.doc.slade_usage,
 	tiles = {"dfcaverns_slade_block.png"},
-	groups = {cracky=3, stone=1, level=3, slade=1, pit_plasma_resistant=1, mese_radiation_shield=1},
-	sounds = default.node_sound_stone_defaults({ footstep = { name = "bedrock2_step", gain = 1 } }),
+	groups = slade_groups,
+	sounds = df_dependencies.sound_stone({ footstep = { name = "bedrock2_step", gain = 1 } }),
 	is_ground_content = false,
+	_mcl_blast_resistance = 1200,
+	_mcl_hardness = 50,
 }
 if invulnerable then
 	add_immortality(slade_block_def)
@@ -108,9 +125,11 @@ local slade_seal_def = {
 	_doc_items_longdesc = df_underworld_items.doc.slade_seal_desc,
 	_doc_items_usagehelp = df_underworld_items.doc.slade_usage,
 	tiles = {"dfcaverns_slade_block.png^dfcaverns_seal.png", "dfcaverns_slade_block.png"},
-	groups = {cracky=3, stone=1, level=3, slade=1, pit_plasma_resistant=1, mese_radiation_shield=1},
-	sounds = default.node_sound_stone_defaults({ footstep = { name = "bedrock2_step", gain = 1 } }),
+	groups = slade_groups,
+	sounds = df_dependencies.sound_stone({ footstep = { name = "bedrock2_step", gain = 1 } }),
 	is_ground_content = false,
+	_mcl_blast_resistance = 1200,
+	_mcl_hardness = 50,
 }
 if invulnerable then
 	slade_seal_def.on_blast = function() end
@@ -118,7 +137,15 @@ if invulnerable then
 end
 minetest.register_node("df_underworld_items:slade_seal", slade_seal_def)
 
-
+minetest.register_craft({
+	type = "shapeless",
+	output = "df_underworld_items:slade_brick",
+	recipe = {
+		"df_underworld_items:slade_sand",
+		df_dependencies.node_name_bucket_lava,
+	},
+	replacements = {{df_dependencies.node_name_bucket_lava, df_dependencies.node_name_bucket_empty}},
+})
 
 minetest.register_abm{
 	label = "slade seal scratching",
@@ -140,33 +167,18 @@ minetest.register_abm{
 
 -- Register stair and slab
 
-if minetest.get_modpath("stairs") then
-	local stair_groups = {level = 3, mese_radiation_shield=1, pit_plasma_resistant=1, slade=1}
-	if invulnerable then
-		stair_groups.immortal = 1
-	end
-	stair_groups.cracky = 3
-	
-	stairs.register_stair_and_slab(
-		"slade_brick",
-		"df_underworld_items:slade_brick",
-		stair_groups,
-		{"dfcaverns_slade_brick.png"},
-		S("Slade Stair"),
-		S("Slade Slab"),
-		default.node_sound_stone_defaults({ footstep = { name = "bedrock2_step", gain = 1 } })
-	)
-	
-	if invulnerable then
-		for name, def in pairs(minetest.registered_nodes) do
-			if name:sub(1,7) == "stairs:" and name:sub(-11) == "slade_brick" then
-				minetest.override_item(name, {can_dig = server_diggable_only})
-			end
+df_dependencies.register_stairs("slade_brick")
+
+if invulnerable then
+	for name, def in pairs(minetest.registered_nodes) do
+		if (name:sub(1,7) == "stairs:" and name:sub(-11) == "slade_block") or 
+			name:sub(1,11) == "mcl_stairs:" and name:sub(-11) == "slade_brick" then
+				minetest.override_item(name, {can_dig = server_diggable_only})			
 		end
 	end
-	
 end
 
+
 if minetest.get_modpath("mesecons_mvps") and df_underworld_items.config.invulnerable_slade then
 	mesecon.register_mvps_stopper("df_underworld_items:slade")
 end