Mineclone compatibility (#36)

* latest versions of mapgen_helper and subterrane

* initial work

* call it "minetest_game" compatibility instead of "default" compatibility

* Getting started on moving all default dependencies to a single root mod

* distilling out more dependencies

* fix some typos

* more default dependencies

* beds

* start getting some MCL equivalents set up

* mine gas dependencies

* reorganize

* add some mapgen stuff

* getting close to actually being able to run mineclone with this

* it actually runs! Crashes with out-of-memory error when you try to go below -64, but it's a start.

* hide flowing pit plasma from creative inventory

* mineclone 5 settings

* Update subterrane

* get rid of meselamp dependency, bring in ancient lanterns from deep roads

* stair dependencies

* add mcl fences

* add mcl blast resistance and hardness to everything. Also an alternate name for Nethercap in MCL, since "nether" has another meaning there.

* buckets of oil and syrup should work in mineclone now

* 'splosions!

* make hunters avoid repaired ancient lanterns

* mapgen torchspine wasn't having its timer set

* split mapgen compatibility code into its own file

* bypass dependency indirection for df_farming.

* apply threshold alpha to food items, they look better that way

* bypass dependency indirection for df_mapitems

* bypass dependency indirection for df_primordial_items

* bypass dependency indirection for df_trees

* bypass dependency indirection for df_underworld_items

* bypass dependency indirection for df_caverns

* fixing up the puzzle seal to work in both

* fix puzzle seal formspec for mcl

* create built-in substitutes for fireflies and bones mods for when those aren't available

* set up mcl dungeon loot for underworld warriors, port over some translations from default

* overlooked a debug

* add itemslot backgrounds for mcl

* added mineclone groups to all registered nodes. TODO: craftitems.

This was extremely tedious. Completely untested, aside from simply running the game.

* minor fixes to the built-in bones node

* eatable group for edibles

* clean up some TODOs

* adjust pit plasma abm conditions

* add df_ambience

* fixing up explosions. Also make slade sand diggable in mcl, and fix a bug in web generators

* make tower cap caves less chirpy, fix bigger goblin hut schematic, allow glowing spindlestem extract bottles

* avoid an undeclared global check

* alas, cave pearls aren't set up right for attached_node_facedir.

* bunch of work on mineclone ores, moved main config into df_dependencies

* add a few more ores

* update depends in mod.conf

* add opaque group to light-sensitive dirt types

Mineclone adds the "opaque" group only to non-light nodes, and torches check for the opaque group to decide whether they can be placed there. light-sensitive nodes need the "light" paramtype to work, though. So adding the opaque group manually to these.

* add a touch of reverb to one of the whisper tracks, it didn't fit with the others without it

* bloodthorn also needs to be set opaque

* add sound to torchspines

* isolate Nethercap translation name to make it easier to swap out in Mineclone contexts

* ambience tweak

* fix dirt spreads

https://github.com/FaceDeer/dfcaverns/issues/35

* adding achievements! Almost all untested yet.

* fix a few achievements glitches

* tweak some more achievements, add delay when achievements unlock other achievements

* fix farming achievements, fix spindlestem callbacks on place

* icons for farming achievements

* more achievement icons, fix ancient lantern achievement

* two more icons, update text

* add icons for upper cavern layers

* all achievements have icons now. Also add another sound to the magma sea ambience

* hook into awards' trigger system to get "x/y" progress displayed for the multi-achievement achievements

* ironically, Mineclone has an old version of awards that is incompatible with my trigger work.

* every award should now have a description and a difficulty.

* removing leftovers

* missing callbacks for farmables

* put growth restrictions on farmables so the achievement doesn't trigger inappropriately.

* enable ores in MCL2, fix some undeclared globals, fix icecap growth in MCL (achievements are a good debugging tool)

* get *all* the copper and iron containing nodes

* fix old awards mod's handling of grouped dig items

* Add a little bonus for players who activate a slade breacher - a handheld 'splosion tool

* used the wrong drop method

* beef up explosions in MCL, make slade brick craftable from slade sand and lava

* better creative mode checks, fix crash when digging walls in MCL

* Update subterrane

* various bugfixes and tweaks

* whipping up a simple puzzle chest to give a clue about ancient numbering

The coding is done, but UI and a node mesh need to be done

* prepare for some art tomorrow

* chest node and sounds

* images for the combination dials

* add puzzle chests to the underworld buildings

* update translations

* oops, can't initialize the contents of puzzle chests every time or players get endless stuff

* add backgrounds to item slots in MCL

* wrap the existing function rather than copy and pasting it

* fix bucket dependency in cooking recipes

* add _mcl_saturation to edibles

oil/init.lua

@@ -11,6 +11,10 @@ end
 
 local oil_sounds = {footstep = {name = "oil_oil_footstep", gain = 0.2}}
 
+local water_source = df_dependencies.node_name_water_source
+local water_flowing = df_dependencies.node_name_water_flowing
+local bucket_empty = df_dependencies.node_name_bucket_empty
+
 minetest.register_node("oil:oil_source", {
 	description = S("Oil"),
 	_doc_items_longdesc = oil_desc,
@@ -57,8 +61,10 @@ minetest.register_node("oil:oil_source", {
 	liquid_alternative_source = "oil:oil_source",
 	liquid_viscosity = 1,
 	post_effect_color = {a = 250, r = 0, g = 0, b = 0},
-	groups = {liquid = 3},
+	groups = {liquid = 1, dig_by_piston=1},
 	sounds = oil_sounds,
+	_mcl_blast_resistance      = 100,
+	_mcl_hardness              = -1,
 })
 
 minetest.register_node("oil:oil_flowing", {
@@ -107,8 +113,10 @@ minetest.register_node("oil:oil_flowing", {
 	liquid_alternative_source = "oil:oil_source",
 	liquid_viscosity = 1,
 	post_effect_color = {a = 250, r = 0, g = 0, b = 0},
-	groups = {liquid = 3, not_in_creative_inventory = 1},
+	groups = {liquid = 1, not_in_creative_inventory = 1, dig_by_piston=1},
 	sounds = oil_sounds,
+	_mcl_blast_resistance      = 100,
+	_mcl_hardness              = -1,
 })
 
 minetest.register_craft({
@@ -124,7 +132,7 @@ if minetest.get_modpath("dynamic_liquid") then
 	minetest.register_abm({
 		label = "oil:oil floats",
 		nodenames = {"oil:oil_source"},
-		neighbors = {"default:water_source"},
+		neighbors = {water_source},
 		interval = 1.0,
 		chance = 1,
 		catch_up = true,
@@ -132,7 +140,7 @@ if minetest.get_modpath("dynamic_liquid") then
 			local next_pos = {x=pos.x, y=pos.y+1, z=pos.z}
 			local next_node = minetest.get_node(next_pos)
 			local above_name = next_node.name
-			if above_name == "default:water_source" then
+			if above_name == water_source then
 				minetest.swap_node(next_pos, {name="oil:oil_source"})
 				minetest.swap_node(pos, next_node)
 			else
@@ -145,7 +153,7 @@ if minetest.get_modpath("dynamic_liquid") then
 					next_pos.z = next_pos.z + displacement
 				end
 				next_node = minetest.get_node(next_pos)
-				if next_node.name == "default:water_source" then
+				if next_node.name == water_source then
 					if above_name ~= "air" then
 						-- we're not on the surface, so try any lateral movement
 						minetest.swap_node(next_pos, {name="oil:oil_source"})
@@ -169,14 +177,14 @@ if minetest.get_modpath("dynamic_liquid") then
 	minetest.register_abm({
 		label = "oil:oil settles",
 		nodenames = {"oil:oil_source"},
-		neighbors = {"default:water_flowing"},
+		neighbors = {water_flowing},
 		interval = 1.0,
 		chance = 1,
 		catch_up = true,
 		action = function(pos, node)
 			local next_pos = {x=pos.x, y=pos.y-1, z=pos.z}
 			local next_node = minetest.get_node(next_pos)
-			if next_node.name == "default:water_flowing" then
+			if next_node.name == water_flowing then
 				minetest.swap_node(next_pos, {name="oil:oil_source"})
 				minetest.swap_node(pos, next_node)
 			end
@@ -185,8 +193,8 @@ if minetest.get_modpath("dynamic_liquid") then
 
 end
 
-if minetest.get_modpath("bucket") then
-	bucket.register_liquid(
+if df_dependencies.bucket_register_liquid then
+	df_dependencies.bucket_register_liquid(
 		"oil:oil_source",
 		"oil:oil_flowing",
 		"oil:oil_bucket",
@@ -198,7 +206,7 @@ if minetest.get_modpath("bucket") then
 		type = "fuel",
 		recipe = "oil:oil_bucket",
 		burntime = 370, -- same as coalblock
-		replacements = {{"oil:oil_bucket", "bucket:bucket_empty"}},
+		replacements = {{"oil:oil_bucket", bucket_empty}},
 	})
 	
 	if minetest.get_modpath("basic_materials") then
@@ -207,7 +215,7 @@ if minetest.get_modpath("bucket") then
 			output = "basic_materials:paraffin",
 			recipe = "oil:oil_bucket",
 			cooktime = 5,
-			replacements = {{"oil:oil_bucket", "bucket:bucket_empty"}},
+			replacements = {{"oil:oil_bucket", bucket_empty}},
 		})
 	end
 end

oil/mod.conf

@@ -1,4 +1,4 @@
 name = oil
 description = Oil liquid type
-depends = default
-optional_depends = dynamic_liquid, bucket, doc, basic_materials
+depends = df_dependencies
+optional_depends = dynamic_liquid, doc, basic_materials