code tidy and tweak

crops/cotton.lua

@@ -1,7 +1,7 @@
 
 local S = farming.intllib
 
--- wild cotton as a source of cotton seed
+-- wild cotton as a source of cotton seed and a chance of cotton itself
 minetest.register_node("farming:cotton_wild", {
 	description = S("Wild Cotton"),
 	drawtype = "plantlike",
@@ -14,12 +14,17 @@ minetest.register_node("farming:cotton_wild", {
 	walkable = false,
 	buildable_to = true,
 	groups = {snappy = 3, attached_node = 1, flammable = 4},
-	drop = "farming:seed_cotton",
+	drop = {
+		items = {
+			{items = {"farming:cotton"}, rarity = 2},
+			{items = {"farming:seed_cotton"}, rarity = 1}
+		}
+	},
 	sounds = default.node_sound_leaves_defaults(),
 	selection_box = {
 		type = "fixed",
-		fixed = {-6 / 16, -8 / 16, -6 / 16, 6 / 16, 5 / 16, 6 / 16},
-	},
+		fixed = {-6 / 16, -8 / 16, -6 / 16, 6 / 16, 5 / 16, 6 / 16}
+	}
 })
 
 -- cotton seeds
@@ -37,21 +42,21 @@ minetest.register_node("farming:seed_cotton", {
 	selection_box = farming.select,
 	on_place = function(itemstack, placer, pointed_thing)
 		return farming.place_seed(itemstack, placer, pointed_thing, "farming:cotton_1")
-	end,
+	end
 })
 
--- cotton / string
-
+-- cotton
 minetest.register_craftitem("farming:cotton", {
 	description = S("Cotton"),
 	inventory_image = "farming_cotton.png",
-	groups = {flammable = 4},
+	groups = {flammable = 4}
 })
 
+-- string
 minetest.register_craftitem("farming:string", {
 	description = S("String"),
 	inventory_image = "farming_string.png",
-	groups = {flammable = 2},
+	groups = {flammable = 2}
 })
 
 -- cotton to wool
@@ -59,7 +64,7 @@ minetest.register_craft({
 	output = "wool:white",
 	recipe = {
 		{"farming:cotton", "farming:cotton"},
-		{"farming:cotton", "farming:cotton"},
+		{"farming:cotton", "farming:cotton"}
 	}
 })
 
@@ -68,7 +73,7 @@ minetest.register_craft({
 	output = "farming:string 2",
 	recipe = {
 		{"farming:cotton"},
-		{"farming:cotton"},
+		{"farming:cotton"}
 	}
 })
 
@@ -76,17 +81,17 @@ minetest.register_craft({
 minetest.register_craft({
 	type = "fuel",
 	recipe = "farming:string",
-	burntime = 1,
+	burntime = 1
 })
 
 minetest.register_craft({
 	type = "fuel",
 	recipe = "farming:cotton",
-	burntime = 1,
+	burntime = 1
 })
 
 -- cotton definition
-local crop_def = {
+local def = {
 	drawtype = "plantlike",
 	tiles = {"farming_cotton_1.png"},
 	paramtype = "light",
@@ -103,65 +108,65 @@ local crop_def = {
 }
 
 -- stage 1
-minetest.register_node("farming:cotton_1", table.copy(crop_def))
+minetest.register_node("farming:cotton_1", table.copy(def))
 
 -- stage 2
-crop_def.tiles = {"farming_cotton_2.png"}
-minetest.register_node("farming:cotton_2", table.copy(crop_def))
+def.tiles = {"farming_cotton_2.png"}
+minetest.register_node("farming:cotton_2", table.copy(def))
 
 -- stage 3
-crop_def.tiles = {"farming_cotton_3.png"}
-minetest.register_node("farming:cotton_3", table.copy(crop_def))
+def.tiles = {"farming_cotton_3.png"}
+minetest.register_node("farming:cotton_3", table.copy(def))
 
 -- stage 4
-crop_def.tiles = {"farming_cotton_4.png"}
-minetest.register_node("farming:cotton_4", table.copy(crop_def))
+def.tiles = {"farming_cotton_4.png"}
+minetest.register_node("farming:cotton_4", table.copy(def))
 
 -- stage 5
-crop_def.tiles = {"farming_cotton_5.png"}
-crop_def.drop = {
+def.tiles = {"farming_cotton_5.png"}
+def.drop = {
 	items = {
-		{items = {"farming:seed_cotton"}, rarity = 1},
+		{items = {"farming:seed_cotton"}, rarity = 1}
 	}
 }
-minetest.register_node("farming:cotton_5", table.copy(crop_def))
+minetest.register_node("farming:cotton_5", table.copy(def))
 
 -- stage 6
-crop_def.tiles = {"farming_cotton_6.png"}
-crop_def.drop = {
+def.tiles = {"farming_cotton_6.png"}
+def.drop = {
 	items = {
 		{items = {"farming:cotton"}, rarity = 1},
-		{items = {"farming:cotton"}, rarity = 2},
+		{items = {"farming:cotton"}, rarity = 2}
 	}
 }
-minetest.register_node("farming:cotton_6", table.copy(crop_def))
+minetest.register_node("farming:cotton_6", table.copy(def))
 
 -- stage 7
-crop_def.tiles = {"farming_cotton_7.png"}
-crop_def.drop = {
+def.tiles = {"farming_cotton_7.png"}
+def.drop = {
 	items = {
 		{items = {"farming:cotton"}, rarity = 1},
 		{items = {"farming:cotton"}, rarity = 2},
 		{items = {"farming:seed_cotton"}, rarity = 1},
-		{items = {"farming:seed_cotton"}, rarity = 2},
+		{items = {"farming:seed_cotton"}, rarity = 2}
 	}
 }
-minetest.register_node("farming:cotton_7", table.copy(crop_def))
+minetest.register_node("farming:cotton_7", table.copy(def))
 
 -- stage 8 (final)
-crop_def.tiles = {"farming_cotton_8.png"}
-crop_def.groups.growing = 0
-crop_def.drop = {
+def.tiles = {"farming_cotton_8.png"}
+def.groups.growing = nil
+def.drop = {
 	items = {
 		{items = {"farming:cotton"}, rarity = 1},
 		{items = {"farming:cotton"}, rarity = 2},
 		{items = {"farming:cotton"}, rarity = 3},
 		{items = {"farming:seed_cotton"}, rarity = 1},
 		{items = {"farming:seed_cotton"}, rarity = 2},
-		{items = {"farming:seed_cotton"}, rarity = 3},
+		{items = {"farming:seed_cotton"}, rarity = 3}
 	}
 }
-minetest.register_node("farming:cotton_8", table.copy(crop_def))
+minetest.register_node("farming:cotton_8", table.copy(def))
 
 -- add to registered_plants
 farming.registered_plants["farming:cotton"] = {
@@ -172,7 +177,7 @@ farming.registered_plants["farming:cotton"] = {
 	steps = 8
 }
 
---[[ Cotton (example, is already registered in cotton.lua)
+--[[ Cotton using api
 farming.register_plant("farming:cotton", {
 	description = "Cotton seed",
 	inventory_image = "farming_cotton_seed.png",