separate food /non-food items from crop files, tidy code

crops/carrot.lua

@@ -1,64 +1,27 @@
 
---[[
-	Original textures from PixelBox texture pack
-	https://forum.minetest.net/viewtopic.php?id=4990
-]]
+-- Original textures from PixelBox texture pack
+-- https://forum.minetest.net/viewtopic.php?id=4990
 
-local S = farming.translate
+local S = minetest.get_translator("farming")
 local a = farming.recipe_items
 
--- carrot
+-- item/seed
+
 minetest.register_craftitem("farming:carrot", {
 	description = S("Carrot"),
 	inventory_image = "farming_carrot.png",
-	groups = {
-		compostability = 48, seed = 2, food_carrot = 1
-	},
+	groups = {compostability = 48, seed = 2, food_carrot = 1},
+	on_use = minetest.item_eat(4),
+
 	on_place = function(itemstack, placer, pointed_thing)
 		return farming.place_seed(itemstack, placer, pointed_thing, "farming:carrot_1")
-	end,
-	on_use = minetest.item_eat(4)
+	end
 })
 
 farming.add_eatable("farming:carrot", 4)
 
--- carrot juice
-minetest.register_craftitem("farming:carrot_juice", {
-	description = S("Carrot Juice"),
-	inventory_image = "farming_carrot_juice.png",
-	on_use = minetest.item_eat(4, "vessels:drinking_glass"),
-	groups = {vessel = 1, drink = 1}
-})
+-- crop definition
 
-farming.add_eatable("farming:carrot_juice", 4)
-
-minetest.register_craft({
-	output = "farming:carrot_juice",
-	recipe = {
-		{a.juicer},
-		{"group:food_carrot"},
-		{"vessels:drinking_glass"}
-	},
-	replacements = {
-		{"group:food_juicer", "farming:juicer"}
-	}
-})
-
--- golden carrot
-minetest.register_craftitem("farming:carrot_gold", {
-	description = S("Golden Carrot"),
-	inventory_image = "farming_carrot_gold.png",
-	on_use = minetest.item_eat(10)
-})
-
-farming.add_eatable("farming:carrot_gold", 10)
-
-minetest.register_craft({
-	output = "farming:carrot_gold",
-	recipe = {{"group:food_carrot", "default:gold_lump"}}
-})
-
--- carrot definition
 local def = {
 	drawtype = "plantlike",
 	tiles = {"farming_carrot_1.png"},
@@ -78,31 +41,37 @@ local def = {
 	sounds = farming.node_sound_leaves_defaults()
 }
 
-
 -- stage 1
+
 minetest.register_node("farming:carrot_1", table.copy(def))
 
 -- stage 2
+
 def.tiles = {"farming_carrot_2.png"}
 minetest.register_node("farming:carrot_2", table.copy(def))
 
 -- stage 3
+
 def.tiles = {"farming_carrot_3.png"}
 minetest.register_node("farming:carrot_3", table.copy(def))
 
 -- stage 4
+
 def.tiles = {"farming_carrot_4.png"}
 minetest.register_node("farming:carrot_4", table.copy(def))
 
 -- stage 5
+
 def.tiles = {"farming_carrot_5.png"}
 minetest.register_node("farming:carrot_5", table.copy(def))
 
 -- stage 6
+
 def.tiles = {"farming_carrot_6.png"}
 minetest.register_node("farming:carrot_6", table.copy(def))
 
 -- stage 7
+
 def.tiles = {"farming_carrot_7.png"}
 def.drop = {
 	items = {
@@ -113,6 +82,7 @@ def.drop = {
 minetest.register_node("farming:carrot_7", table.copy(def))
 
 -- stage 8 (final)
+
 def.tiles = {"farming_carrot_8.png"}
 def.groups.growing = nil
 def.selection_box = farming.select_final
@@ -125,6 +95,7 @@ def.drop = {
 minetest.register_node("farming:carrot_8", table.copy(def))
 
 -- add to registered_plants
+
 farming.registered_plants["farming:carrot"] = {
 	crop = "farming:carrot",
 	seed = "farming:carrot",
@@ -134,6 +105,7 @@ farming.registered_plants["farming:carrot"] = {
 }
 
 -- mapgen
+
 local mg = farming.mapgen == "v6"
 
 def = {