From 0c2271fa46d02bbe1462d9fc326844a7c64113cb Mon Sep 17 00:00:00 2001
From: wsor4035 <24964441+wsor4035@users.noreply.github.com>
Date: Mon, 7 Feb 2022 08:18:17 -0500
Subject: [PATCH] fixes warning spam (#20)

* fix fake fire warnings

* fix hd 3d extras warnings

* fix hd climate control warnings

* fix hd clocks warnings

* fix hd cobweb warnings

* fix hd doors/gates warnings

* fix hd exterior warnings

* fix hd fences warnings

* fix hd gastronomy warnings

* fix hd kitchen missing dependency

* fix hd office warnings

* fix hd roofing warnings

* fix hd table warnings

* fix hd trash cans warnings

* fix hd wardrobe warnings

* remove legacy hack
---
 fake_fire/init.lua                 |  1 +
 fake_fire/mod.conf                 |  2 +-
 homedecor_3d_extras/init.lua       |  6 +++---
 homedecor_climate_control/init.lua |  2 ++
 homedecor_clocks/init.lua          |  1 +
 homedecor_cobweb/init.lua          |  2 ++
 homedecor_doors_and_gates/init.lua |  6 +++---
 homedecor_exterior/init.lua        |  5 +++++
 homedecor_fences/init.lua          | 10 ++++++++++
 homedecor_gastronomy/init.lua      |  2 ++
 homedecor_kitchen/mod.conf         |  2 +-
 homedecor_office/init.lua          |  1 +
 homedecor_roofing/init.lua         |  3 ++-
 homedecor_tables/coffeetable.lua   |  1 +
 homedecor_tables/endtable.lua      |  1 +
 homedecor_tables/misc.lua          |  3 +++
 homedecor_trash_cans/init.lua      |  1 +
 homedecor_wardrobe/init.lua        |  2 +-
 18 files changed, 41 insertions(+), 10 deletions(-)

diff --git a/fake_fire/init.lua b/fake_fire/init.lua
index 21f82cc0..660bd0e3 100644
--- a/fake_fire/init.lua
+++ b/fake_fire/init.lua
@@ -179,6 +179,7 @@ minetest.register_node("fake_fire:fancy_fire", {
 	mesh = "fancy_fire.obj",
 	paramtype = "light",
 	paramtype2 = "facedir",
+	use_texture_alpha = "clip",
 	groups = {oddly_breakable_by_hand=3, flammable=0},
 	sunlight_propagates = true,
 	light_source = 13,
diff --git a/fake_fire/mod.conf b/fake_fire/mod.conf
index c3e56ba2..39f9dd45 100644
--- a/fake_fire/mod.conf
+++ b/fake_fire/mod.conf
@@ -1,2 +1,2 @@
 name = fake_fire
-depends = default
+depends = default, basic_materials
diff --git a/homedecor_3d_extras/init.lua b/homedecor_3d_extras/init.lua
index 53d75545..263573f2 100644
--- a/homedecor_3d_extras/init.lua
+++ b/homedecor_3d_extras/init.lua
@@ -21,7 +21,7 @@ if minetest.get_modpath("vessels") then
 		},
 		paramtype = "light",
 		paramtype2 = "facedir",
-		use_texture_alpha = true
+		use_texture_alpha = "blend",
 	})
 
 	local sbox = {
@@ -35,7 +35,7 @@ if minetest.get_modpath("vessels") then
 		tiles = {"homedecor_3d_vessels_shelf_glass.png"},
 		inventory_image = "homedecor_3d_vessels_glass_bottle_inv.png",
 		wield_image = "homedecor_3d_vessels_glass_bottle_inv.png",
-		use_texture_alpha = true,
+		use_texture_alpha = "blend",
 		selection_box = sbox
 	})
 
@@ -54,7 +54,7 @@ if minetest.get_modpath("vessels") then
 		tiles = {"homedecor_3d_vessels_shelf_glass.png"},
 		inventory_image = "homedecor_3d_vessels_drinking_glass_inv.png",
 		wield_image = "homedecor_3d_vessels_drinking_glass_inv.png",
-		use_texture_alpha = true,
+		use_texture_alpha = "blend",
 		selection_box = sbox
 	})
 end
diff --git a/homedecor_climate_control/init.lua b/homedecor_climate_control/init.lua
index cbb0aaa3..41834d28 100644
--- a/homedecor_climate_control/init.lua
+++ b/homedecor_climate_control/init.lua
@@ -10,6 +10,7 @@ homedecor.register("air_conditioner", {
 		"default_glass.png"
 	},
 	groups = { snappy = 3 },
+	use_texture_alpha = "clip",
 	sounds = default.node_sound_leaves_defaults(),
 	selection_box = { type="regular" },
 })
@@ -95,6 +96,7 @@ homedecor.register("ceiling_fan", {
 			{ -0.0625, 0.375, -0.0625, 0.0625, 0.5, 0.0625 }
 		}
 	},
+	use_texture_alpha = "clip",
 	groups = { snappy = 3 },
 	light_source = default.LIGHT_MAX-1,
 	sounds = default.node_sound_glass_defaults(),
diff --git a/homedecor_clocks/init.lua b/homedecor_clocks/init.lua
index 8801e921..9474d1f2 100644
--- a/homedecor_clocks/init.lua
+++ b/homedecor_clocks/init.lua
@@ -88,6 +88,7 @@ homedecor.register("grandfather_clock", {
 		"homedecor_grandfather_clock_face_edge.png",
 		"homedecor_generic_metal_brass.png"
 	},
+	use_texture_alpha = "clip",
 	inventory_image = "homedecor_grandfather_clock_inv.png",
 	groups = { snappy = 3 },
 	selection_box = gf_cbox,
diff --git a/homedecor_cobweb/init.lua b/homedecor_cobweb/init.lua
index 2d5a6bbe..0e5b8fc2 100644
--- a/homedecor_cobweb/init.lua
+++ b/homedecor_cobweb/init.lua
@@ -30,6 +30,7 @@ minetest.register_node(":homedecor:cobweb_centered", {
 	drawtype = "nodebox",
 	tiles = { "homedecor_cobweb.png" },
 	inventory_image = "homedecor_cobweb.png",
+	use_texture_alpha = "clip",
 	paramtype = "light",
 	paramtype2 = "facedir",
 	sunlight_propagates = true,
@@ -59,6 +60,7 @@ minetest.register_node(":homedecor:cobweb_flat", {
 	inventory_image = "homedecor_cobweb.png",
 	paramtype = "light",
 	paramtype2 = "facedir",
+	use_texture_alpha = "clip",
 	sunlight_propagates = true,
 	liquid_viscosity = 8,
 	liquidtype = "source",
diff --git a/homedecor_doors_and_gates/init.lua b/homedecor_doors_and_gates/init.lua
index 0554db5e..951b2073 100644
--- a/homedecor_doors_and_gates/init.lua
+++ b/homedecor_doors_and_gates/init.lua
@@ -183,12 +183,11 @@ for _, door in ipairs(door_list) do
 
 	if door.alpha then
 		local def = table.copy(minetest.registered_nodes[nn_a])
-			def.use_texture_alpha = true
-			def.mesh = "door_a.obj"                -- leaving this out will break the _a model
+			def.use_texture_alpha = "blend"
 			minetest.register_node(":"..nn_a, def) -- assignment when the override takes place
 
 		def = table.copy(minetest.registered_nodes[nn_b])
-			def.use_texture_alpha = true
+			def.use_texture_alpha = "blend"
 			minetest.register_node(":"..nn_b, def)
 	end
 
@@ -307,6 +306,7 @@ for i, g in ipairs(gate_list) do
 		description = gatedesc,
 		tiles = tiles,
 		paramtype = "light",
+		use_texture_alpha = "clip",
 		groups = {snappy=3},
 		sounds = default.node_sound_wood_defaults(),
 		paramtype2 = "facedir",
diff --git a/homedecor_exterior/init.lua b/homedecor_exterior/init.lua
index 3e4b1697..bfe92dbd 100644
--- a/homedecor_exterior/init.lua
+++ b/homedecor_exterior/init.lua
@@ -94,6 +94,7 @@ homedecor.register("lattice_"..name, {
 	description = S("Garden Lattice (@1)", desc),
 	tiles = {"homedecor_lattice"..texture},
 	inventory_image = "homedecor_lattice"..texture,
+	use_texture_alpha = "clip",
 	groups = { snappy=3 },
 	node_box = {
 		type = "fixed",
@@ -121,6 +122,7 @@ homedecor.register("swing", {
 		"homedecor_swing_top.png"
 	},
 	inventory_image = "homedecor_swing_inv.png",
+	use_texture_alpha = "clip",
 	groups = { snappy=3, oddly_breakable_by_hand=3 },
 	sounds = default.node_sound_wood_defaults(),
 	walkable = false,
@@ -219,6 +221,7 @@ homedecor.register("well", {
 	},
 	inventory_image = "homedecor_well_inv.png",
 	description = S("Water well"),
+	use_texture_alpha = "clip",
 	groups = { snappy = 3 },
 	selection_box = homedecor.nodebox.slab_y(2),
 	collision_box = homedecor.nodebox.slab_y(2),
@@ -265,6 +268,7 @@ for color, color_loc in pairs(homedecor_exterior.shrub_colors) do
 		tiles = {"homedecor_shrubbery_"..color..".png"},
 		paramtype = "light",
 		is_ground_content = false,
+		use_texture_alpha = "clip",
 		groups = {snappy=3, flammable=2},
 		sounds = default.node_sound_leaves_defaults(),
 	})
@@ -280,6 +284,7 @@ for color, color_loc in pairs(homedecor_exterior.shrub_colors) do
 		},
 		paramtype = "light",
 		is_ground_content = false,
+		use_texture_alpha = "clip",
 		groups = {snappy=3, flammable=2},
 		sounds = default.node_sound_leaves_defaults(),
 		selection_box = shrub_cbox,
diff --git a/homedecor_fences/init.lua b/homedecor_fences/init.lua
index 7a0dccc4..c5226efe 100644
--- a/homedecor_fences/init.lua
+++ b/homedecor_fences/init.lua
@@ -35,6 +35,7 @@ homedecor.register("fence_picket", {
 		"homedecor_fence_picket_backside.png",
 		"homedecor_fence_picket.png"
 	},
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	sounds = default.node_sound_wood_defaults(),
 	selection_box = homedecor.nodebox.slab_z(-0.1),
@@ -51,6 +52,7 @@ homedecor.register("fence_picket_corner", {
 		"homedecor_fence_picket_backside.png",
 		"homedecor_fence_picket.png",
 	},
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	sounds = default.node_sound_wood_defaults(),
 	selection_box = homedecor.nodebox.corner_xz(0.1, -0.1),
@@ -67,6 +69,7 @@ homedecor.register("fence_picket_white", {
 		"homedecor_fence_picket_white_backside.png",
 		"homedecor_fence_picket_white.png"
 	},
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	sounds = default.node_sound_wood_defaults(),
 	selection_box = homedecor.nodebox.slab_z(-0.1),
@@ -83,6 +86,7 @@ homedecor.register("fence_picket_corner_white", {
 		"homedecor_fence_picket_white_backside.png",
 		"homedecor_fence_picket_white.png",
 	},
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	sounds = default.node_sound_wood_defaults(),
 	selection_box = homedecor.nodebox.corner_xz(0.1, -0.1),
@@ -152,6 +156,7 @@ homedecor.register("fence_barbed_wire", {
 	description = S("Barbed Wire Fence"),
 	mesh = "homedecor_fence_barbed_wire.obj",
 	tiles = {"homedecor_fence_barbed_wire.png"},
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	sounds = default.node_sound_wood_defaults(),
 	selection_box = homedecor.nodebox.slab_z(-0.125),
@@ -162,6 +167,7 @@ homedecor.register("fence_barbed_wire_corner", {
 	description = S("Barbed Wire Fence Corner"),
 	mesh = "homedecor_fence_barbed_wire_corner.obj",
 	tiles = { "homedecor_fence_barbed_wire.png" },
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	sounds = default.node_sound_wood_defaults(),
 	selection_box = homedecor.nodebox.corner_xz(0.125, -0.125),
@@ -179,6 +185,7 @@ homedecor.register("fence_chainlink", {
 		"homedecor_fence_chainlink_fb.png",
 		"homedecor_fence_chainlink_fb.png",
 	},
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	sounds = default.node_sound_wood_defaults(),
 	selection_box = homedecor.nodebox.slab_z(-0.125),
@@ -197,6 +204,7 @@ homedecor.register("fence_chainlink_corner", {
 		"homedecor_fence_chainlink_corner_front.png",
 		"homedecor_fence_chainlink_corner_front.png",
 	},
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	sounds = default.node_sound_wood_defaults(),
 	selection_box = homedecor.nodebox.corner_xz(0.125, -0.125),
@@ -213,6 +221,7 @@ homedecor.register("fence_wrought_iron_2", {
 		"homedecor_fence_wrought_iron_2_fb.png",
 		"homedecor_fence_wrought_iron_2_fb.png"
 	},
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	sounds = default.node_sound_wood_defaults(),
 	selection_box = homedecor.nodebox.slab_z(-0.08),
@@ -240,6 +249,7 @@ homedecor.register("fence_wrought_iron_2_corner", {
 		"homedecor_fence_corner_wrought_iron_2_sides.png^[transformFX",
 		"homedecor_fence_corner_wrought_iron_2_sides.png"
 	},
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	sounds = default.node_sound_wood_defaults(),
 	selection_box = homedecor.nodebox.corner_xz(0.08, -0.08),
diff --git a/homedecor_gastronomy/init.lua b/homedecor_gastronomy/init.lua
index 4cc18b66..b71676b3 100644
--- a/homedecor_gastronomy/init.lua
+++ b/homedecor_gastronomy/init.lua
@@ -136,6 +136,7 @@ homedecor.register("toaster", {
 	tiles = { "homedecor_toaster_sides.png" },
 	inventory_image = "homedecor_toaster_inv.png",
 	walkable = false,
+	use_texture_alpha = "clip",
 	groups = { snappy=3 },
 	node_box = {
 		type = "fixed",
@@ -165,6 +166,7 @@ homedecor.register("toaster_loaf", {
 		"homedecor_toaster_sides.png"
 	},
 	walkable = false,
+	use_texture_alpha = "clip",
 	groups = { snappy=3, not_in_creative_inventory=1 },
 	node_box = {
 		type = "fixed",
diff --git a/homedecor_kitchen/mod.conf b/homedecor_kitchen/mod.conf
index 22f97b2f..8de6943d 100644
--- a/homedecor_kitchen/mod.conf
+++ b/homedecor_kitchen/mod.conf
@@ -1,4 +1,4 @@
 name = homedecor_kitchen
 description = Homedecor mod: kitchen
-depends = homedecor_common, default, basic_materials, dye
+depends = homedecor_common, default, basic_materials, dye, unifieddyes
 optional_depends = moreblocks, building_blocks, technic, bucket, screwdriver
diff --git a/homedecor_office/init.lua b/homedecor_office/init.lua
index e55c4bcb..c0fa573a 100644
--- a/homedecor_office/init.lua
+++ b/homedecor_office/init.lua
@@ -77,6 +77,7 @@ homedecor.register("calendar", {
 		wall_bottom = { -4/16, -8/16, -8/16,  4/16, -5/16, 5/16 },
 		wall_top =    { -4/16,  5/16, -8/16,  4/16,  8/16, 5/16 }
 	},
+	use_texture_alpha = "clip",
 	groups = {choppy=2,attached_node=1},
 	legacy_wallmounted = true,
 	sounds = default.node_sound_defaults(),
diff --git a/homedecor_roofing/init.lua b/homedecor_roofing/init.lua
index 3c88deaf..0f600d4b 100644
--- a/homedecor_roofing/init.lua
+++ b/homedecor_roofing/init.lua
@@ -20,7 +20,7 @@ minetest.register_node(":homedecor:skylight_frosted", {
 	tiles = { "homedecor_skylight_frosted.png" },
 	wield_image = "homedecor_skylight_frosted.png",
 	inventory_image = "homedecor_skylight_frosted_inv.png",
-	use_texture_alpha = true,
+	use_texture_alpha = "blend",
 	groups = { snappy = 3 },
 	paramtype = "light",
 	sounds = default.node_sound_glass_defaults(),
@@ -134,6 +134,7 @@ homedecor_roofing.register_slope = function(modname, subname, recipeitem, groups
 		paramtype2 = "facedir",
 		selection_box = slope_cbox,
 		collision_box = slope_cbox,
+		use_texture_alpha = "blend",
 		groups = groups,
 		on_place = minetest.rotate_node,
 		sounds = default.node_sound_wood_defaults()
diff --git a/homedecor_tables/coffeetable.lua b/homedecor_tables/coffeetable.lua
index 3e73e664..fd9fc649 100644
--- a/homedecor_tables/coffeetable.lua
+++ b/homedecor_tables/coffeetable.lua
@@ -57,6 +57,7 @@ minetest.register_node(":lrfurn:coffeetable", {
 	},
 	paramtype = "light",
 	paramtype2 = "facedir",
+	use_texture_alpha = "blend",
 	groups = {snappy=1,choppy=2,oddly_breakable_by_hand=2,flammable=3},
 	sounds = default.node_sound_wood_defaults(),
 	node_box = {
diff --git a/homedecor_tables/endtable.lua b/homedecor_tables/endtable.lua
index d28b5c4b..61af7ece 100644
--- a/homedecor_tables/endtable.lua
+++ b/homedecor_tables/endtable.lua
@@ -15,6 +15,7 @@ minetest.register_node(":lrfurn:endtable", {
 	},
 	paramtype = "light",
 	paramtype2 = "facedir",
+	use_texture_alpha = "blend",
 	groups = {snappy=1,choppy=2,oddly_breakable_by_hand=2,flammable=3},
 	sounds = default.node_sound_wood_defaults(),
 	node_box = {
diff --git a/homedecor_tables/misc.lua b/homedecor_tables/misc.lua
index de062240..6fa331db 100644
--- a/homedecor_tables/misc.lua
+++ b/homedecor_tables/misc.lua
@@ -34,6 +34,7 @@ for _, t in ipairs(leg_materials) do
 		inventory_image = "homedecor_table_legs_"..name..".png",
 		wield_image = "homedecor_table_legs_"..name..".png",
 		walkable = false,
+		use_texture_alpha = "blend",
 		groups = {snappy=3},
 		sounds = default.node_sound_wood_defaults(),
 		selection_box = {
@@ -76,6 +77,7 @@ for i, mat in ipairs(tabletop_materials) do
 				'homedecor_blanktile.png',
 			},
 			wield_image = 'homedecor_'..m..'_table_'..shape..'_inv.png',
+			use_texture_alpha = "blend",
 			groups = { snappy = 3 },
 			sounds = s,
 			selection_box = tables_cbox,
@@ -111,6 +113,7 @@ for i, mat in ipairs(tabletop_materials) do
 					'homedecor_'..m..'_table_edges.png',
 					"homedecor_table_legs_"..leg_mat..".png",
 				},
+				use_texture_alpha = "blend",
 				groups = { snappy = 3 },
 				sounds = s,
 			})
diff --git a/homedecor_trash_cans/init.lua b/homedecor_trash_cans/init.lua
index 092f4f92..63e70ee7 100644
--- a/homedecor_trash_cans/init.lua
+++ b/homedecor_trash_cans/init.lua
@@ -61,6 +61,7 @@ homedecor.register("trash_can", {
 	tiles = { "homedecor_trash_can.png" },
 	inventory_image = "homedecor_trash_can_inv.png",
 	description = S("Small Trash Can"),
+	use_texture_alpha = "clip",
 	groups = {snappy=3},
 	selection_box = trash_cbox,
 	collision_box = trash_cbox,
diff --git a/homedecor_wardrobe/init.lua b/homedecor_wardrobe/init.lua
index c7d279c0..ae5eb461 100644
--- a/homedecor_wardrobe/init.lua
+++ b/homedecor_wardrobe/init.lua
@@ -173,7 +173,7 @@ if not skinsdb_mod_path then -- If not managed by skinsdb
 
 	minetest.register_on_joinplayer(function(player)
 
-		local skin = player:get_attribute("homedecor:player_skin")
+		local skin = player:get_meta():get("homedecor:player_skin")
 
 		if skin and skin ~= "" then