mtcontrib/homedecor_modpack
1
0
Fork 2
mirror of https://github.com/mt-mods/homedecor_modpack.git synced 2024-11-17 15:48:31 +01:00
Code Issues Releases Wiki Activity

Fix books: enforce book ownership, strict access checking.

Browse Source 
Fixes #399
This commit is contained in:
Auke Kok 2017-12-06 21:15:58 -08:00
parent 5efa9af1b7
commit 9d4ac9bd9a
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
homedecor/books.lua
View File

@ -156,13 +156,20 @@ for _, c in ipairs(bookcolors) do
end end
minetest.register_on_player_receive_fields(function(player, form_name, fields) minetest.register_on_player_receive_fields(function(player, form_name, fields)
if form_name ~= BOOK_FORMNAME or not fields.save then if form_name ~= BOOK_FORMNAME then
return return false
end end
local player_name = player:get_player_name() local player_name = player:get_player_name()
local pos = player_current_book[player_name] local pos = player_current_book[player_name]
if not pos then return end if not pos then
return true
end
local meta = minetest.get_meta(pos) local meta = minetest.get_meta(pos)
local owner = meta:get_string("owner")
if owner ~= "" and player_name ~= owner or not fields.save then
player_current_book[player_name] = nil
return true
end
meta:set_string("title", fields.title or "") meta:set_string("title", fields.title or "")
meta:set_string("text", fields.text or "") meta:set_string("text", fields.text or "")
meta:set_string("owner", player_name) meta:set_string("owner", player_name)
@ -171,6 +178,9 @@ minetest.register_on_player_receive_fields(function(player, form_name, fields)
end end
minetest.log("action", S("@1 has written in a book (title: \"@2\"): \"@3\" at location @4", minetest.log("action", S("@1 has written in a book (title: \"@2\"): \"@3\" at location @4",
player:get_player_name(), fields.title, fields.text, minetest.pos_to_string(player:getpos()))) player:get_player_name(), fields.title, fields.text, minetest.pos_to_string(player:getpos())))
player_current_book[player_name] = nil
return true
end) end)
minetest.register_alias("homedecor:book", "homedecor:book_grey") minetest.register_alias("homedecor:book", "homedecor:book_grey")