remove debug prints

(causes color code to be displayed raw)

README.md

@@ -4,9 +4,11 @@ Simply place one or more panels, and set a channel on just the left-most or uppe
 
 Then send a character, a string, or one of several control words or codes to that channel from a Mesecons Lua Controller and the mod will try to display it.
 
-A single character will be displayed on the connected panel. A numeric message (i.e. not a string) will display the first digit on the connected panel.
+A single character will be displayed on the connected panel.
 
-Strings will be displayed using all panels in a lineup, so long as they all face the same way, starting from the panel the Lua Controller is connected to, going left to right. The other panels in the line do not need to be connected to anything - think of them as being connected together internally. Only the panel at the far left need be connected to the Lua Controller.
+A numeric message (i.e. not a string) will be converted into a string.
+
+Strings of all types (other than the keywords below) will be displayed using all panels in a lineup, so long as they all face the same way, starting from the panel the Lua Controller is connected to, going left to right. The other panels in the line do not need to be connected to anything - think of them as being connected together internally. Only the panel at the far left need be connected to the Lua Controller.
 
 The string will spread down the line until either a panel is found that faces the wrong way, or has a channel that's not empty/nil and is set to something other than what the first is set to, or if a node is encountered that is not an alpha-numeric panel at all.
 
@@ -22,7 +24,7 @@ If the program finds something other than a panel, it wraps to the next line. If
 
 Lines of panels don't need to be all the same length, the program will wrap as needed, with the left margin always being aligned with the panel the LuaController is connected to.
 
-Strings are trimmed to 1 kB.
+Strings are trimmed to 6 kB.
 
 Panels are not erased between prints.
 
@@ -40,15 +42,24 @@ This mod uses the full ISO-8859-1 character set (see https://en.wikipedia.org/wi
 If a string is prefixed with character code 255, it is treated as UTF-8 and passed through a simple translation function.  Only characters with codes greater than 159 are altered; normal ASCII text, color codes, control codes, and the above symbols are passed through unchanged.  Note that in this mode, a character code over 159 is treated as the first byte of a two-byte symbol.
 
 The panels also respond to these control messages:
-the keywords "off", "colon" and "period" translate to a blank space, ":", and ".", respectively (they're leftover from the nixie tubes fork, but might be useful anyway)
 
-* "del" is mapped to character #127, a square with an X in it.
-* "allon" is mapped to character #144, the full/all-on block graphic.
-* "cursor" or character code 31 will display a short, thick, flashing line at the bottom of the panel.
-* "off_multi" turns all panels in a lineup or wall off - essentially a "clear screen" command.
-* "allon_multi" turns on all LEDs of all panels in a lineup/wall (by filling them with char #144).
+* "clear" turns all panels in a lineup or wall off, or up to 2048 of them, anyway - essentially a "clear screen" command.
+* "allon" fills all panels in a lineup/wall, up to a max of 2048 of them, with char(144), i.e. the reverse of "clear".
+* "start_scroll" starts the automatic scrolling function, repeatedly moving the last displayed message to the left one character space each time the scroll timer runs out (and automatically restarting it, natch).  The scroll action will spread across the line, and down a multi-line wall (just set a new, different channel on the first row you want to exclude), and will continue until "stop_scroll" or any displayable message is received.
 
-A byte value of 0 to 27 in a string will change colors (i.e. string.char(0 to 27) ).
+	As it advances through the message, the scroll code will search through the message for a printable character, on each scroll step, basically stripping-out color code, and using just the last one before the new start position.  This is done in order to keep a constant visible speed (the text will still be colored properly though).
+* "stop_scroll" does just what it says - it stops the auto-scroll timer.  
+* "scroll_speed" followed by a decimal number (in the string, not a byte value) sets the time between scroll steps.  Minimum 0.2s, maximum 5s.
+* "scroll_step" will immediately advance the last-displayed message by one character.  Omit the above automatic scrolling keywords, and use ONLY this keyword instead if you want to let your LuaController control the scrolling speed.  Optionally, you can follow this with a number and the scroll code will skip forward that many bytes into the message, starting from the current position, before starting the above-mentioned color-vs-character search.  Essentially, this value will roughly translate to the number of printable characters to skip.
+* "get" will read the one character (as a numerical character value) currently displayed by the master panel (by reading its node name)
+* "getstr" will read the last-stored message for the entire lineup/wall (from the master panel's meta).  Note that even if the message has been or is being scrolled, you'll get the original stored message.
+* "getindex" will read the scroll index position in that message, which will always point at a printable character, per the above color-versus-character search.
+
+During a scroll event, the printed string is padded with spaces (one in auto mode, or as many as the skip value when manually stepping).
+
+If you need vertical scrolling, you will have to handle that yourself (since the size of a screen/wall is not hard-coded).
+
+To change colors, put a "/" followed by a digit or a letter from "A" to "R" (or "a" to "r") into your printed string.  Digits 0 to 9 trigger colors 0 to 9 (obviously :-) ), while A/a through R/r set colors 10 to 27.  Any other sequence is invalid and will just be printed literally.  Two slashes "//" will translated to a single char(30) internally, and displayed as a single slash (doing it that way makes the code easier).
 
 Color values 0 to 11 are:
 
@@ -60,12 +71,14 @@ Colors 24 - 27 are white, light grey, medium grey, and dim grey (or think of the
 
 The last color that was used is stored in the left-most/upper-left "master" panel's metadata, and defaults to red. It should persist across reboots.
 
-A byte value of 28 in a string will act as a line feed (I would have used 10, but that's a color code :-P )
+char(10) will do its job as linefeed/newline.
 
-A byte value of 29 in a string signals a cursor position command. The next two byte values select a column and row, respectively. The next character after the row byte will be printed there, and the rest of the string then continues printing from that spot onward with normal line wrapping, colors and so forth. Note that any string that does NOT contain cursor positioning commands will automatically start printing at the upper-left.
+char(29) signals a cursor position command. The next two byte values select a column and row, respectively. The next character after the row byte will be printed there, and the rest of the string then continues printing from that spot onward with normal line wrapping, colors and so forth. Note that any string that does NOT contain cursor positioning commands will automatically start printing at the upper-left.
 
-You can use "get" and "getstr" to read the one character from the connected panel. These messages will not read the other panels in the lineup.
+Any number of color, line feed, and cursor position commands may be present in a string, making it possible to "frame-buffer" a screen full of text into a string before printing it.
 
 All panels emit a small amount of light when displaying something.
 
 The panels only mount on a wall.
+
+The "master"/connected panel stores the last-displayed message and some other details in its metadata, so you may occasionally need to dig and re-place the panel if things go wonky (this won't happen during normal use, but it may happen if you're making lots of changes to the panels' layout, channel names, etc).

init.lua

@@ -1,6 +1,8 @@
 -- simple LED marquee mod
 -- by Vanessa Dannenberg
 
+led_marquee = {}
+
 local S
 if minetest.get_modpath("intllib") then
 	S = intllib.make_gettext_pair()
@@ -8,6 +10,89 @@ else
 	S = function(s) return s end
 end
 
+local color_to_char = {
+	"0",
+	"1",
+	"2",
+	"3",
+	"4",
+	"5",
+	"6",
+	"7",
+	"8",
+	"9",
+	"A",
+	"B",
+	"C",
+	"D",
+	"E",
+	"F",
+	"G",
+	"H",
+	"I",
+	"J",
+	"K",
+	"L",
+	"M",
+	"N",
+	"O",
+	"P",
+	"Q",
+	"R"
+}
+
+local char_to_color = {
+	["0"] = 0,
+	["1"] = 1,
+	["2"] = 2,
+	["3"] = 3,
+	["4"] = 4,
+	["5"] = 5,
+	["6"] = 6,
+	["7"] = 7,
+	["8"] = 8,
+	["9"] = 9,
+
+	["A"] = 10,
+	["B"] = 11,
+	["C"] = 12,
+	["D"] = 13,
+	["E"] = 14,
+	["F"] = 15,
+	["G"] = 16,
+	["H"] = 17,
+	["I"] = 18,
+	["J"] = 19,
+	["K"] = 20,
+	["L"] = 21,
+	["M"] = 22,
+	["N"] = 23,
+	["O"] = 24,
+	["P"] = 25,
+	["Q"] = 26,
+	["R"] = 27,
+
+	["a"] = 10,
+	["b"] = 11,
+	["c"] = 12,
+	["d"] = 13,
+	["e"] = 14,
+	["f"] = 15,
+	["g"] = 16,
+	["h"] = 17,
+	["i"] = 18,
+	["j"] = 19,
+	["k"] = 20,
+	["l"] = 21,
+	["m"] = 22,
+	["n"] = 23,
+	["o"] = 24,
+	["p"] = 25,
+	["q"] = 26,
+	["r"] = 27
+
+}
+
 -- the following functions based on the so-named ones in Jeija's digilines mod
 
 local reset_meta = function(pos)
@@ -53,6 +138,59 @@ local make_iso = function(s)
 	return s2
 end
 
+-- scrolling
+
+led_marquee.set_timer = function(pos, timeout)
+	local timer = minetest.get_node_timer(pos)
+	timer:stop()
+	if not timeout or timeout < 0.2 or timeout > 5 then return false end
+
+	if timeout > 0 then
+		local meta = minetest.get_meta(pos)
+		meta:set_int("timeout", timeout)
+		timer:start(timeout)
+	end
+end
+
+led_marquee.scroll_text = function(pos, elapsed, skip)
+	skip = skip or 1
+	local meta = minetest.get_meta(pos)
+	local msg = meta:get_string("last_msg")
+	local channel = meta:get_string("channel")
+	local index = meta:get_int("index")
+	local color = meta:get_int("last_color")
+	local colorchar = color_to_char[color+1]
+	if not index or index < 1 then index = 1 end
+	local len = string.len(msg)
+	index = index + skip
+	if index > len then index = 1 end
+
+	-- search backward to find the most recent color code in the string
+	local r = index
+	while r > 0 and not string.match(string.sub(msg, r, r+1), "/[0-9A-Ra-r]") do
+		r = r - 1
+	end
+	if r == 0 then r = 1 end
+	if string.match(string.sub(msg, r, r+1), "/[0-9A-Ra-r]") then
+		colorchar = string.sub(msg, r+1, r+1)
+	end
+
+	-- search forward to find the next printable symbol after the current index
+	local f = index
+	while f < len do
+		if string.match(string.sub(msg, f-1, f), "/[0-9A-Ra-r]") then
+			f = f + 2
+		else
+			break
+		end
+	end
+	led_marquee.display_msg(pos, channel, "/"..colorchar..string.sub(msg, f)..string.rep(" ", skip + 1))
+
+	meta:set_int("index", f)
+	if not elapsed or elapsed < 0.2 then return false end
+	return true
+end
+
 -- the nodes:
 
 local fdir_to_right = {
@@ -71,14 +209,14 @@ local cbox = {
 	wall_side = { -8/16, -8/16, -8/16, -7/16, 8/16, 8/16 }
 }
 
-local display_string = function(pos, channel, string)
-	string = string.sub(string, 1, 1024)
-	if string == "off_multi" then
-		string = string.rep(" ", 1024)
-	elseif string == "allon_multi" then
-		string = string.rep(string.char(144), 1024)
-	elseif string.sub(string,1,1) == string.char(255) then -- treat it as incoming UTF-8
-		string = make_iso(string.sub(string, 2, 1024))
+led_marquee.decode_color = function(msg)
+
+end
+
+led_marquee.display_msg = function(pos, channel, msg)
+	msg = string.sub(msg, 1, 6144).." "
+	if string.sub(msg,1,1) == string.char(255) then -- treat it as incoming UTF-8
+		msg = make_iso(string.sub(msg, 2, 6144))
 	end
 
 	local master_fdir = minetest.get_node(pos).param2 % 8
@@ -90,7 +228,7 @@ local display_string = function(pos, channel, string)
 		master_meta:set_int("last_color", 0)
 	end
 	local i = 1
-	local len = string.len(string)
+	local len = string.len(msg)
 	local wrapped = nil
 	while i <= len do
 		local node = minetest.get_node(pos2)
@@ -98,7 +236,7 @@ local display_string = function(pos, channel, string)
 		local meta = minetest.get_meta(pos2)
 		local setchan = nil
 		if meta then setchan = meta:get_string("channel") end
-		local asc = string.byte(string, i, i)
+		local asc = string.byte(msg, i, i)
 		if not string.match(node.name, "led_marquee:char_") then
 			if not wrapped then
 				pos2.x = pos.x
@@ -111,31 +249,48 @@ local display_string = function(pos, channel, string)
 		elseif string.match(node.name, "led_marquee:char_")
 			and fdir ~= master_fdir or (setchan ~= nil and setchan ~= "" and setchan ~= channel) then
 			break
-		elseif asc == 28 then
+		elseif asc == 10 then
 			pos2.x = pos.x
 			pos2.y = pos2.y-1
 			pos2.z = pos.z
 			i = i + 1
 			wrapped = nil
 		elseif asc == 29 then
-			local c = string.byte(string, i+1, i+1) or 0
-			local r = string.byte(string, i+2, i+2) or 0
+			local c = string.byte(msg, i+1, i+1) or 0
+			local r = string.byte(msg, i+2, i+2) or 0
 			pos2.x = pos.x + (fdir_to_right[fdir+1][1])*c
 			pos2.y = pos.y - r
 			pos2.z = pos.z + (fdir_to_right[fdir+1][2])*c
 			i = i + 3
 			wrapped = nil
+		elseif asc == 30 then -- translate to slash for printing
+			minetest.swap_node(pos2, { name = "led_marquee:char_47", param2 = master_fdir + (last_color*8)})
+			pos2.x = pos2.x + fdir_to_right[fdir+1][1]
+			pos2.z = pos2.z + fdir_to_right[fdir+1][2]
+			i = i + 1
+		elseif asc == 47 then -- slash
+			local ccode = string.sub(msg, i+1, i+1)
+			if ccode then
+				if char_to_color[ccode] then
+					last_color = char_to_color[ccode]
+					i = i + 2
+				else
+					minetest.swap_node(pos2, { name = "led_marquee:char_47", param2 = master_fdir + (last_color*8)})
+					pos2.x = pos2.x + fdir_to_right[fdir+1][1]
+					pos2.z = pos2.z + fdir_to_right[fdir+1][2]
+					i = i + 1
+				end
+			end
+			master_meta:set_int("last_color", last_color)
+			wrapped = nil
 		elseif asc > 30 and asc < 256 then
 			minetest.swap_node(pos2, { name = "led_marquee:char_"..asc, param2 = master_fdir + (last_color*8)})
 			pos2.x = pos2.x + fdir_to_right[fdir+1][1]
 			pos2.z = pos2.z + fdir_to_right[fdir+1][2]
 			i = i + 1
 			wrapped = nil
-		elseif asc < 28 then
-			last_color = asc
-			master_meta:set_int("last_color", asc)
+		else
 			i = i + 1
-			wrapped = nil
 		end
 	end
 end
@@ -153,47 +308,64 @@ local on_digiline_receive_string = function(pos, node, channel, msg)
 	if setchan ~= channel then return end
 	if msg and msg ~= "" and type(msg) == "string" then
 		if string.len(msg) > 1 then
-			if msg == "off" then
-				minetest.swap_node(pos, { name = "led_marquee:char_32", param2 = fdir + (last_color*8)})
-			elseif msg == "colon" then
-				minetest.swap_node(pos, { name = "led_marquee:char_58", param2 = fdir + (last_color*8)})
-			elseif msg == "period" then
-				minetest.swap_node(pos, { name = "led_marquee:char_46", param2 = fdir + (last_color*8)})
-			elseif msg == "del" then
-				minetest.swap_node(pos, { name = "led_marquee:char_127", param2 = fdir + (last_color*8)})
+			if msg == "clear" then
+				led_marquee.set_timer(pos, 0)
+				msg = string.rep(" ", 2048)
+				meta:set_string("last_msg", msg)
+				led_marquee.display_msg(pos, channel, msg)
+				meta:set_int("index", 1)
 			elseif msg == "allon" then
-				minetest.swap_node(pos, { name = "led_marquee:char_144", param2 = fdir + (last_color*8)})
-			elseif msg == "cursor" then
-				minetest.swap_node(pos, { name = "led_marquee:char_31", param2 = fdir + (last_color*8)})
+				led_marquee.set_timer(pos, 0)
+				msg = string.rep(string.char(144), 2048)
+				meta:set_string("last_msg", msg)
+				led_marquee.display_msg(pos, channel, msg)
+				meta:set_int("index", 1)
+			elseif msg == "start_scroll" then
+				local timeout = meta:get_int("timeout")
+				led_marquee.set_timer(pos, timeout)
+			elseif msg == "stop_scroll" then
+				led_marquee.set_timer(pos, 0)
+				return
+			elseif string.sub(msg, 1, 12) == "scroll_speed" then
+				local timeout = tonumber(string.sub(msg, 13))
+				led_marquee.set_timer(pos, timeout)
+			elseif string.sub(msg, 1, 11) == "scroll_step" then
+				local skip = tonumber(string.sub(msg, 12))
+				led_marquee.scroll_text(pos, nil, skip)
+			elseif msg == "get" then -- get the master panel's displayed char as ASCII numerical value
+				digilines.receptor_send(pos, digiline.rules.default, channel, tonumber(string.match(minetest.get_node(pos).name,"led_marquee:char_(.+)"))) -- wonderfully horrible string manipulaiton
+			elseif msg == "getstr" then -- get the last stored message
+				digilines.receptor_send(pos, digiline.rules.default, channel, meta:get_string("last_msg"))
+			elseif msg == "getindex" then -- get the scroll index
+				digilines.receptor_send(pos, digiline.rules.default, channel, meta:get_int("index"))
 			else
-				display_string(pos, channel, msg)
+				msg = string.gsub(msg, "//", string.char(30))
+				led_marquee.set_timer(pos, 0)
+				meta:set_string("last_msg", msg)
+				led_marquee.display_msg(pos, channel, msg)
+				meta:set_int("index", 1)
 			end
 		else
 			local asc = string.byte(msg)
-			if asc > 30 and asc < 256 then
+			if asc > 29 and asc < 256 then
 				minetest.swap_node(pos, { name = "led_marquee:char_"..asc, param2 = fdir + (last_color*8)})
-			elseif asc < 28 then
-				last_color = asc
-				meta:set_int("last_color", asc)
-			elseif msg == "get" then -- get value as ASCII numerical value
-				digiline:receptor_send(pos, digiline.rules.default, channel, tonumber(string.match(minetest.get_node(pos).name,"led_marquee:char_(.+)"))) -- wonderfully horrible string manipulaiton
-			elseif msg == "getstr" then -- get actual char
-				digiline:receptor_send(pos, digiline.rules.default, channel, string.char(tonumber(string.match(minetest.get_node(pos).name,"led_marquee:char_(.+)"))))
+				meta:set_string("last_msg", tostring(msg))
+				meta:set_int("index", 1)
 			end
 		end
 	elseif msg and type(msg) == "number" then
-		if msg == 0 then
-			minetest.swap_node(pos, { name = "led_marquee:char_32", param2 = fdir + (last_color*8)})
-		elseif msg > 30 then
-			minetest.swap_node(pos, { name = "led_marquee:char_"..tostring(msg), param2 = fdir + (last_color*8)})
-		end
+		meta:set_string("last_msg", tostring(msg))
+		led_marquee.display_msg(pos, channel, tostring(msg))
+		meta:set_int("index", 1)
 	end
 end
 
+-- the nodes!
+
 for i = 31, 255 do
 	local groups = { cracky = 2, not_in_creative_inventory = 1}
 	local light = LIGHT_MAX-2
-	local description = S("Alphanumeric LED marquee panel ("..i..")")
+	local description = S("LED marquee panel ("..i..")")
 	local tiles = {
 				{ name="led_marquee_base.png", color="white"},
 				{ name="led_marquee_leds_off.png", color="white"},
@@ -214,7 +386,8 @@ for i = 31, 255 do
 	if i == 32 then
 		groups = {cracky = 2}
 		light = nil
-		description = S("Alphanumeric LED marquee panel")
+		description = S("LED marquee panel")
+		wimage = "led_marquee_leds_off.png^(led_marquee_char_155.png^[multiply:red)"
 	end
 
 	minetest.register_node("led_marquee:char_"..i, {
@@ -222,6 +395,8 @@ for i = 31, 255 do
 		drawtype = "mesh",
 		mesh = "led_marquee.obj",
 		tiles = tiles,
+		inventory_image = wimage,
+		wield_image = wimage,
 		palette="led_marquee_palette.png",
 		use_texture_alpha = true,
 		groups = groups,
@@ -244,13 +419,13 @@ for i = 31, 255 do
 				action = on_digiline_receive_string,
 			},
 		},
-		drop = "led_marquee:char_32"
+		drop = "led_marquee:char_32",
+		on_timer = led_marquee.scroll_text
 	})
 end
 
 -- crafts
 
-
 minetest.register_craft({
 	output = "led_marquee:char_32 6",
 	recipe = {