mtcontrib/minetest-u_skinsdb
1
0
Fork 2
mirror of https://github.com/SmallJoker/minetest-u_skinsdb.git synced 2024-11-16 15:10:17 +01:00
Code Issues Releases Wiki Activity

fixes

Browse Source 
close the response lexically, and replace takes a path which could differ from location/base so we can efficiently make the rename temp name.
This commit is contained in:
user 2015-09-21 17:46:06 +00:00
parent 2b7610a60f
commit fdf52ebd86
1 changed files with 33 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
update_from_db.py
View File

@ -1,8 +1,9 @@
#!/usr/bin/python3 #!/usr/bin/python3
from http.client import HTTPConnection from http.client import HTTPConnection,HTTPException
import json import json
import base64 import base64
import sys from contextlib import closing
import sys,os,shutil
def die(message,code=23): def die(message,code=23):
print(message,file=sys.stderr) print(message,file=sys.stderr)
@ -14,20 +15,24 @@ metadir = "u_skins/meta/"
curskin = 0 curskin = 0
pages = None pages = None
def replace(path,encoding=None): def replace(location,base,encoding=None,path=None):
if path is None:
path = os.path.join(location,base)
mode = "wt" if encoding else "wb" mode = "wt" if encoding else "wb"
# an unpredictable temp name only needed for a+rwxt directories # an unpredictable temp name only needed for a+rwxt directories
tmp = '.'+path+'-tmp' tmp = os.path.join(location,'.'+base+'-tmp')
def deco(handle): def deco(handle):
with open(tmp,mode,encoding=encoding) as out: with open(tmp,mode,encoding=encoding) as out:
yield out handle(out)
os.rename(tmp,path) os.rename(tmp,path)
return deco return deco
def maybeReplace(path,encoding=None): def maybeReplace(location,base,encoding=None):
def deco(handle): def deco(handle):
path = os.path.join(location,base)
if os.path.exists(path): return if os.path.exists(path): return
return replace(path,encoding)(handle) return replace(location,base,encoding=encoding,path=path)(handle)
return deco
c = HTTPConnection(server) c = HTTPConnection(server)
def addpage(page): def addpage(page):
@ -53,33 +58,39 @@ def addpage(page):
for s in l["skins"]: for s in l["skins"]:
# make sure to increment this, even if the preview exists! # make sure to increment this, even if the preview exists!
curskin = curskin + 1 curskin = curskin + 1
preview = skinsdir + "character_" + str(curskin) + "_preview.png" previewbase = "character_" + str(curskin) + "_preview.png"
if os.path.exists(preview): continue preview = os.path.join(skinsdir, previewbase)
if os.path.exists(preview):
print('skin',curskin,'already retrieved')
continue
print('updating skin',curskin)
foundOne = True foundOne = True
tmp = dest+'-tmp' @maybeReplace(skinsdir, "character_" + str(curskin) + ".png")
@maybeReplace(skinsdir + "character_" + str(curskin) + ".png")
def go(f): def go(f):
f.write(base64.b64decode(bytes(s["img"], 'utf-8'))) f.write(base64.b64decode(bytes(s["img"], 'utf-8')))
f.close() f.close()
@maybeReplace(metadir + "character_" + str(curskin) + ".txt", @maybeReplace(metadir, "character_" + str(curskin) + ".txt",
encoding='utf-8') encoding='utf-8')
def go(f): def go(f):
f.write(str(s["name"]) + '\n') f.write(str(s["name"]) + '\n')
f.write(str(s["author"]) + '\n') f.write(str(s["author"]) + '\n')
f.write(str(s["license"])) f.write(str(s["license"]))
url = "/skins/1/" + str(s["id"]) + ".png"
try: try:
c.request("GET", "/skins/1/" + str(s["id"]) + ".png") c.request("GET", url)
r = c.getresponse() with closing(c.getresponse()) as r:
if r.status != 200:
print("Error", r.status)
continue
@replace(skinsdir,previewbase,path=preview)
def go(f):
shutil.copyfileobj(r,f)
except HTTPException as e: except HTTPException as e:
print(type(e),dir(e)) die("Couldn't get {} because of a {} (url={})".format(
raise(e) s["id"],
if r.status != 200: e,
print("Error", r.status) url))
continue
@replace(preview)
def go(f):
shutil.copyfileobj(r,f)
if not foundOne: if not foundOne:
print("No skins updated on this page. Seems we're done?") print("No skins updated on this page. Seems we're done?")
raise SystemExit raise SystemExit