From 4ab678d7ec8bbd4ea3a1af711c44b05238aebb67 Mon Sep 17 00:00:00 2001
From: tenplus1 <kinsellaja@yahoo.com>
Date: Fri, 28 Jun 2024 11:31:26 +0100
Subject: [PATCH] refactor lava pick dig function

---
 lava_flan.lua | 53 ++++++++++++++++++++++++---------------------------
 1 file changed, 25 insertions(+), 28 deletions(-)

diff --git a/lava_flan.lua b/lava_flan.lua
index 84574f8..068cd7e 100644
--- a/lava_flan.lua
+++ b/lava_flan.lua
@@ -138,46 +138,43 @@ local old_handle_node_drops = minetest.handle_node_drops
 
 function minetest.handle_node_drops(pos, drops, digger)
 
-	-- are we the player holding a Lava Pick?
-	if not digger
-	or (digger and digger:get_wielded_item():get_name() ~= ("mobs:pick_lava")) then
-		return old_handle_node_drops(pos, drops, digger)
-	end
+	-- are we a player using the lava pick?
+	if digger and digger:get_wielded_item():get_name() == ("mobs:pick_lava") then
 
-	-- reset new smelted drops
-	local hot_drops = {}
+		local hot_drops = {}
 
-	-- loop through current node drops
-	for _, drop in ipairs(drops) do
+		for _, drop in ipairs(drops) do
 
-		-- get cooked output of current drops
-		local stack = ItemStack(drop)
+			local stack = ItemStack(drop)
 
-		while not stack:is_empty() do
+			while not stack:is_empty() do
 
-			local output, decremented_input = minetest.get_craft_result({
-				method = "cooking",
-				width = 1,
-				items = {stack}
-			})
+				local output, decremented_input = minetest.get_craft_result({
+					method = "cooking",
+					width = 1,
+					items = {stack}
+				})
 
-			if output.item:is_empty() then
+				if output.item:is_empty() then
 
-				table.insert_all(hot_drops, decremented_input.items)
-				break
-			else
-				if not output.item:is_empty() then
-					table.insert(hot_drops, output.item)
+					table.insert_all(hot_drops, decremented_input.items)
+					break
+				else
+					if not output.item:is_empty() then
+						table.insert(hot_drops, output.item)
+					end
+
+					table.insert_all(hot_drops, output.replacements)
+
+					stack = decremented_input.items[1] or ItemStack()
 				end
-
-				table.insert_all(hot_drops, output.replacements)
-
-				stack = decremented_input.items[1] or ItemStack()
 			end
 		end
+
+		drops = hot_drops -- replace normal drops with cooked versions
 	end
 
-	return old_handle_node_drops(pos, hot_drops, digger)
+	return old_handle_node_drops(pos, drops, digger)
 end
 
 minetest.register_tool(":mobs:pick_lava", {