From d85fb4c64f5f1305d62370e7dafcfb6e0a1a0f69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Diego=20Mart=C3=ADnez?= Date: Fri, 6 Jan 2017 05:36:40 -0300 Subject: [PATCH] Prevent two separate instances of stack overflow. The first one happens because `remove_node` is called directly, calling `remove_node` for the vine below, calling `remove_node` for the vine below, calling... The second one happens because `get_item_group` returns 0 for groups not set, and 0 is a truthy value in Lua, so the code always removes the bottom node regardless of its group rating. This interacted funnily with doors wanting to remove their top node, while vines wanted to remove their bottom nodes. --- vines/functions.lua | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vines/functions.lua b/vines/functions.lua index db120a6..9050a15 100644 --- a/vines/functions.lua +++ b/vines/functions.lua @@ -82,8 +82,10 @@ vines.register_vine = function( name, defs, biome ) local node = minetest.get_node( pos ) local bottom = {x=pos.x, y=pos.y-1, z=pos.z} local bottom_node = minetest.get_node( bottom ) - if minetest.get_item_group( bottom_node.name, "vines") then - minetest.remove_node( bottom ) + if minetest.get_item_group( bottom_node.name, "vines") > 0 then + -- Calling `remove_node` directly would cause + -- a stack overflow for really long vines. + minetest.after( 0, minetest.remove_node, bottom ) end end, after_dig_node = function( pos, node, oldmetadata, user )