Browse Source

Merge pull request #23 from thomasrudin-mt/code-cleanup-ci

stricter luacheck (no globals) / travis ci file
github-actions
D00Med GitHub 7 months ago
parent
commit
0e05d475a3
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 27 additions and 12 deletions
  1. +7
    -4
      .luacheckrc
  2. +12
    -0
      .travis.yml
  3. +5
    -5
      doors.lua
  4. +2
    -2
      nodeboxes.lua
  5. +1
    -1
      palm_scanner.lua

+ 7
- 4
.luacheckrc View File

@@ -1,9 +1,7 @@
unused_args = false
allow_defined_top = true

globals = {
"minetest",
"mesecon"
"scifi_nodes"
}

read_globals = {
@@ -16,6 +14,11 @@ read_globals = {
"dump",

-- optional deps
"default", "stairsplus", "xpanes", "screwdriver"
"default",
"stairsplus",
"xpanes",
"screwdriver",
"minetest",
"mesecon"

}

+ 12
- 0
.travis.yml View File

@@ -0,0 +1,12 @@
language: generic
sudo: false
addons:
apt:
packages:
- luarocks
before_install:
- luarocks install --local luacheck
script:
- $HOME/.luarocks/bin/luacheck --no-color .
notifications:
email: false

+ 5
- 5
doors.lua View File

@@ -66,7 +66,7 @@ for _, current_door in ipairs(doors) do
})


function onplace(itemstack, placer, pointed_thing)
local function onplace(itemstack, placer, pointed_thing)
-- Is there room enough ?
local pos1 = pointed_thing.above
local pos2 = {x=pos1.x, y=pos1.y, z=pos1.z}
@@ -120,11 +120,11 @@ for _, current_door in ipairs(doors) do
return itemstack;
end

function afterdestruct(pos, oldnode)
local function afterdestruct(pos, oldnode)
minetest.set_node({x=pos.x,y=pos.y+1,z=pos.z},{name="air"})
end

function open_door(pos, node, player, itemstack, pointed_thing)
local function open_door(pos, node, player, itemstack, pointed_thing)
-- play sound
minetest.sound_play(sound,{
max_hear_distance = 16,
@@ -181,12 +181,12 @@ for _, current_door in ipairs(doors) do
timer:start(3)
end

function afterplace(pos, placer, itemstack, pointed_thing)
local function afterplace(pos, placer, itemstack, pointed_thing)
local node = minetest.get_node(pos)
minetest.set_node({x=pos.x,y=pos.y+1,z=pos.z},{name=opened_top,param2=node.param2})
end

function ontimer(pos, elapsed)
local function ontimer(pos, elapsed)
-- play sound
minetest.sound_play(sound,{
max_hear_distance = 16,


+ 2
- 2
nodeboxes.lua View File

@@ -2,8 +2,8 @@
-- GENERATED CODE
-- Node Box Editor, version 0.9.0

position1 = nil
position2 = nil
local position1 = nil
local position2 = nil

minetest.register_node("scifi_nodes:alienslope", {
description = "Alien Platform",


+ 1
- 1
palm_scanner.lua View File

@@ -10,7 +10,7 @@
local has_mesecons = minetest.get_modpath("mesecons")


function activate_palm_scanner(pos, node, player)
local function activate_palm_scanner(pos, node, player)
local name = player and player:get_player_name()
name = name or ""



Loading…
Cancel
Save