From aabf7ec57595d849fa18d631edec9d53bd7251e2 Mon Sep 17 00:00:00 2001 From: electrodude Date: Fri, 18 Dec 2015 00:01:02 -0500 Subject: [PATCH 1/2] Added missing local variable The on_metadata_inventory_take method of digiline_inventory:chest was broken, since it used a `channel` local variable that was never defined, but should have been fetched from the node's meta --- digilines_inventory/init.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/digilines_inventory/init.lua b/digilines_inventory/init.lua index 89aaabc..f0a2053 100644 --- a/digilines_inventory/init.lua +++ b/digilines_inventory/init.lua @@ -127,6 +127,7 @@ minetest.register_node("digilines_inventory:chest", { minetest.log("action", player:get_player_name().." puts stuff into chest at "..minetest.pos_to_string(pos)) end, on_metadata_inventory_take = function(pos, listname, index, stack, player) + local channel = minetest.get_meta(pos):get_string("channel") local inv = minetest.get_meta(pos):get_inventory() if inv:is_empty(listname) then sendMessage(pos, "empty", channel) From dcb25cbe2f74b6d538d2569db2341e0c1ce1ef32 Mon Sep 17 00:00:00 2001 From: electrodude Date: Mon, 18 Jan 2016 11:54:05 -0500 Subject: [PATCH 2/2] Removed redundant minetest.get_meta(pos) --- digilines_inventory/init.lua | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/digilines_inventory/init.lua b/digilines_inventory/init.lua index f0a2053..a8e7ecf 100644 --- a/digilines_inventory/init.lua +++ b/digilines_inventory/init.lua @@ -127,8 +127,9 @@ minetest.register_node("digilines_inventory:chest", { minetest.log("action", player:get_player_name().." puts stuff into chest at "..minetest.pos_to_string(pos)) end, on_metadata_inventory_take = function(pos, listname, index, stack, player) - local channel = minetest.get_meta(pos):get_string("channel") - local inv = minetest.get_meta(pos):get_inventory() + local meta = minetest.get_meta(pos) + local channel = meta:get_string("channel") + local inv = meta:get_inventory() if inv:is_empty(listname) then sendMessage(pos, "empty", channel) end