This repository has been archived on 2025-10-04. You can view files and clone it. You cannot open issues or pull requests or push a commit.

cutealien 92564435f4 Fix bad cast in CIndexBuffer. Modify IIndexBuffer interface for cleanup and safety. ...

CIndexBuffer::setType could end up casting a temporary u16 variable to u32& (reference!).
Probably never noticed as this tended to mostly works (guess next byte on stack often 0?).
To prevent this from happening again I modifed IIndexBuffer::push_back to work with copies instead of references.
While breaking the interface anyway I also deprecated pointer() which is just identical to getData() anyway.
I get the idea of staying similar to core::array interface, but it's just confusing (and not same due to lack of types anyway).
Also added a const version for getData()

On a side-note - same setType bug still in CVertexBuffer, but a bit harder to fix there. So will be an new patch.

git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@6357 dfc29bdd-3216-0410-991c-e03cc46cb475

2022-04-22 16:28:29 +00:00

2.4 KiB

Raw Blame History

View Raw