minetest
/
minetest
mirror of https://github.com/minetest/minetest.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix footsteps for players whose collision box min y != 0 (#12110)

This commit is contained in:
Gregor Parzefall 2022-03-14 21:01:18 +01:00 committed by GitHub
parent 11f3f72f1c
commit 289c3ff377
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/client/localplayer.cpp
View File

@ -672,19 +672,21 @@ v3s16 LocalPlayer::getStandingNodePos()
v3s16 LocalPlayer::getFootstepNodePos()
{
v3f feet_pos = getPosition() + v3f(0.0f, m_collisionbox.MinEdge.Y, 0.0f);
// Emit swimming sound if the player is in liquid
if (in_liquid_stable)
return floatToInt(getPosition(), BS);
return floatToInt(feet_pos, BS);
// BS * 0.05 below the player's feet ensures a 1/16th height
// nodebox is detected instead of the node below it.
if (touching_ground)
return floatToInt(getPosition() - v3f(0.0f, BS * 0.05f, 0.0f), BS);
return floatToInt(feet_pos - v3f(0.0f, BS * 0.05f, 0.0f), BS);
// A larger distance below is necessary for a footstep sound
// when landing after a jump or fall. BS * 0.5 ensures water
// sounds when swimming in 1 node deep water.
return floatToInt(getPosition() - v3f(0.0f, BS * 0.5f, 0.0f), BS);
return floatToInt(feet_pos - v3f(0.0f, BS * 0.5f, 0.0f), BS);
}
v3s16 LocalPlayer::getLightPosition() const