fixed warnings reported by cppcheck

This commit is contained in:
Perttu Ahola 2011-04-11 11:36:13 +03:00
parent 3f153c20d3
commit 9d4e9c59de
10 changed files with 19 additions and 9 deletions

View File

@ -82,7 +82,8 @@ Client::Client(
camera_direction(0,0,1), camera_direction(0,0,1),
m_server_ser_ver(SER_FMT_VER_INVALID), m_server_ser_ver(SER_FMT_VER_INVALID),
m_inventory_updated(false), m_inventory_updated(false),
m_time_of_day(0) m_time_of_day(0),
m_map_seed(0)
{ {
m_packetcounter_timer = 0.0; m_packetcounter_timer = 0.0;
m_delete_unused_sectors_timer = 0.0; m_delete_unused_sectors_timer = 0.0;

View File

@ -404,7 +404,8 @@ RatCAO::RatCAO():
ClientActiveObject(0), ClientActiveObject(0),
m_selection_box(-BS/3.,0.0,-BS/3., BS/3.,BS/2.,BS/3.), m_selection_box(-BS/3.,0.0,-BS/3., BS/3.,BS/2.,BS/3.),
m_node(NULL), m_node(NULL),
m_position(v3f(0,10*BS,0)) m_position(v3f(0,10*BS,0)),
m_yaw(0)
{ {
ClientActiveObject::registerType(getType(), create); ClientActiveObject::registerType(getType(), create);
} }

View File

@ -90,6 +90,7 @@ DebugStack::DebugStack(threadid_t id)
threadid = id; threadid = id;
stack_i = 0; stack_i = 0;
stack_max_i = 0; stack_max_i = 0;
memset(stack, 0, DEBUG_STACK_SIZE*DEBUG_STACK_TEXT_SIZE);
} }
void DebugStack::print(FILE *file, bool everything) void DebugStack::print(FILE *file, bool everything)

View File

@ -6030,7 +6030,8 @@ void MapVoxelManipulator::blitBack
} }
ManualMapVoxelManipulator::ManualMapVoxelManipulator(Map *map): ManualMapVoxelManipulator::ManualMapVoxelManipulator(Map *map):
MapVoxelManipulator(map) MapVoxelManipulator(map),
m_create_area(false)
{ {
} }

View File

@ -780,7 +780,8 @@ struct ChunkMakeData
ChunkMakeData(): ChunkMakeData():
no_op(false), no_op(false),
vmanip(NULL) vmanip(NULL),
seed(0)
{} {}
}; };

View File

@ -563,7 +563,8 @@ public:
(-BS*0.3,-BS*.25,-BS*0.3, BS*0.3,BS*0.25,BS*0.3); (-BS*0.3,-BS*.25,-BS*0.3, BS*0.3,BS*0.25,BS*0.3);
m_selection_box = new core::aabbox3d<f32> m_selection_box = new core::aabbox3d<f32>
(-BS*0.3,-BS*.25,-BS*0.3, BS*0.3,BS*0.25,BS*0.3); (-BS*0.3,-BS*.25,-BS*0.3, BS*0.3,BS*0.25,BS*0.3);
m_yaw = 0;
m_counter1 = 0; m_counter1 = 0;
m_counter2 = 0; m_counter2 = 0;
m_age = 0; m_age = 0;
@ -906,7 +907,8 @@ class PlayerObject : public MovingObject
public: public:
PlayerObject(MapBlock *block, s16 id, v3f pos): PlayerObject(MapBlock *block, s16 id, v3f pos):
MovingObject(block, id, pos), MovingObject(block, id, pos),
m_node(NULL) m_node(NULL),
m_yaw(0)
{ {
m_collision_box = new core::aabbox3d<f32> m_collision_box = new core::aabbox3d<f32>
(-BS*0.3,-BS*.25,-BS*0.3, BS*0.3,BS*0.25,BS*0.3); (-BS*0.3,-BS*.25,-BS*0.3, BS*0.3,BS*0.25,BS*0.3);

View File

@ -892,6 +892,7 @@ void RemoteClient::SetBlocksNotSent(core::map<v3s16, MapBlock*> &blocks)
PlayerInfo::PlayerInfo() PlayerInfo::PlayerInfo()
{ {
name[0] = 0; name[0] = 0;
avg_rtt = 0;
} }
void PlayerInfo::PrintLine(std::ostream *s) void PlayerInfo::PrintLine(std::ostream *s)

View File

@ -53,6 +53,8 @@ void sockets_cleanup()
Address::Address() Address::Address()
{ {
m_address = 0;
m_port = 0;
} }
Address::Address(unsigned int address, unsigned short port) Address::Address(unsigned int address, unsigned short port)

View File

@ -1903,7 +1903,7 @@ inline v3f intToFloat(v3s16 p, f32 d)
*/ */
// Creates a string with the length as the first two bytes // Creates a string with the length as the first two bytes
inline std::string serializeString(const std::string plain) inline std::string serializeString(const std::string &plain)
{ {
assert(plain.size() <= 65535); assert(plain.size() <= 65535);
char buf[2]; char buf[2];
@ -1945,7 +1945,7 @@ inline std::string deSerializeString(std::istream &is)
} }
// Creates a string with the length as the first four bytes // Creates a string with the length as the first four bytes
inline std::string serializeLongString(const std::string plain) inline std::string serializeLongString(const std::string &plain)
{ {
char buf[4]; char buf[4];
writeU32((u8*)&buf[0], plain.size()); writeU32((u8*)&buf[0], plain.size());

View File

@ -553,7 +553,7 @@ public:
/* /*
Some settings Some settings
*/ */
bool m_disable_water_climb; //bool m_disable_water_climb;
private: private:
}; };