minetest
/
minetest
mirror of https://github.com/minetest/minetest.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Deny empty username early in the protocol 

Thanks to @UltimateNate for pointing this out :)
This commit is contained in:
est31 2015-05-22 20:22:55 +02:00
parent 9facb40738
commit e13d2bafc6
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/serverpackethandler.cpp
View File

@ -164,9 +164,11 @@ void Server::handleCommand_Init(NetworkPacket* pkt)
*/ */
const char* playername = playerName.c_str(); const char* playername = playerName.c_str();
if (playerName.size() > PLAYERNAME_SIZE) { size_t pns = playerName.size();
actionstream << "Server: Player with an too long name " if (pns == 0 || pns > PLAYERNAME_SIZE) {
<< "tried to connect from " << addr_s << std::endl; actionstream << "Server: Player with "
<< ((pns > PLAYERNAME_SIZE) ? "a too long" : "an empty")
<< " name tried to connect from " << addr_s << std::endl;
DenyAccess(pkt->getPeerId(), SERVER_ACCESSDENIED_WRONG_NAME); DenyAccess(pkt->getPeerId(), SERVER_ACCESSDENIED_WRONG_NAME);
return; return;
} }