Commit Graph

7131 Commits

Author SHA1 Message Date
sfan5 123370f2ee Sanitize lang_code and full_version received from client
fixes #14262
2024-03-24 20:25:49 +00:00
SmallJoker 751fa811fa Client: fix possible division by zero in [crack modifier 2024-03-24 20:23:57 +00:00
sfan5 38a3d6fac2 Fix Lua PseudoRandom seeds being mangled
closes #14237
2024-03-24 20:23:31 +00:00
SmallJoker d5ddfa6e46 ContentCAO: Fix threshold of alpha channel textures (#14213)
With disabled shaders, the material EMT_TRANSPARENT_ALPHA_CHANNEL uses the
parameter as an alpha threshold to decide whether to draw the texture.
Thus lowering this limit fixes the issue of vanishing textures below alpha 128.
2024-03-24 20:22:41 +00:00
cx384 9c08b9978d Fix dividing by zero crashes in texture modifiers 2024-03-24 20:21:49 +00:00
sfan5 9ba8d5fc2e Fix some console window behavior on Windows 2024-03-24 20:21:31 +00:00
sfan5 adf8296081 Fix native thread handle usage on win32 2024-03-24 20:21:20 +00:00
sfan5 701c5edfbe Avoid unused argument spam with MinGW-clang 2024-03-24 20:21:15 +00:00
sfan5 1dfe954104 Add unittest to check thread_local destructor brokenness 2024-03-24 20:21:10 +00:00
sfan5 ce02619aaa Fix logic in porting::attachOrCreateConsole()
No functional change but now the comment is actually correct.
2024-03-24 20:21:05 +00:00
Maintainer_ d0d8d3f65f Fix GameUI text staying visible during shutdown. (#14197) 2024-03-24 20:20:18 +00:00
Gregor Parzefall fcd2dd7e3b Make the loading screen progress bar respect "gui_scaling" 2024-03-24 20:17:07 +00:00
grorp bd551780e7 Touchscreen: Make server-sent overrides of button textures work (#14145) 2024-03-24 20:16:26 +00:00
Gregor Parzefall 39be1b9cbb Fix TouchScreenGUI ignoring server-sent pitch changes 2024-03-24 20:15:42 +00:00
sfan5 4f0e31cbe1 Hand roll UTF-16 conversion in CGUITTFont (#14121) 2024-03-24 20:15:10 +00:00
Gregor Parzefall d57305210d Fix touch input on Linux
The code relied on touch IDs being consecutive. This is true on Android, but not on Linux.
Therefore, touch input on Linux was broken since 53886dcdb5.
2024-03-24 20:14:56 +00:00
SmallJoker fdb5cc0061 Inventory: prevent item loss when stacking oversized ItemStacks (#14072) 2024-03-24 20:13:31 +00:00
sfan5 ecd0e44b2d Fix Windows architecture reporting in sysinfo 2024-03-24 20:13:05 +00:00
Gary Miguel f4af3912b4 Try to fix safeWriteToFile producing empty files on Windows (#14085)
Use win32 APIs to write the temporary file before copying to the final
destination. Because we've observed the final file being empty, we
suspect that std::ostream::flush is not flushing.

Also add a test for it.
2024-03-24 20:12:18 +00:00
SmallJoker 218addfd50 GUIFormspecMenu: Fix race condition between quit event and cleanup in Game (#14010)
To not instantly free GUIFormSpec upon close/quit, Game periodically
cleans up the remaining instance on the next frame.

When a new formspec is received and processed after closing the previous formspec
but before the cleanup in Game, the formspec would be closed regardless.
This now re-creates the formspec when the old one is already pending for removal.
2024-03-24 20:12:08 +00:00
ZenonSeth 2ecc741d6c Check if liquid can flow into empty node before picking it as source (#14057) 2024-03-24 20:11:51 +00:00
updatepo.sh bae9f65411 Update from builtin/settingtypes.txt 2023-12-03 18:47:50 +01:00
Desour bf53e7e1ca Fix anticheat false positives whith speed physics override 2023-12-03 12:23:17 +01:00
Muhammad Rifqi Priyo Susanto 047520d91e
Inventory: Add remaining items into the source slot directly (#14021)
Remaining items are added into the source slot directly when left-dragging over the source slot.
2023-12-03 15:00:07 +07:00
DS 6106e4e72b
Fix sound and particlespawner id generation (#14059)
* Fix server sound ids being reused to early

* Fix particlespawner id generation

It always returned 0.
Also, now the ids always grow, to make a conflict with ids in lua unlikely.
2023-12-01 00:09:53 +01:00
SmallJoker a7e5456099
Server: avoid re-use of recent ParticleSpawner and Sound IDs (#14045)
This improves the reliability when removing and re-adding handles quickly.
Looping through the entire ID range avoids collisions caused by any race condition.
2023-11-29 21:10:19 +01:00
sfan5 d6a8b546e4 Enable clean transparent filter in more cases
It was determined that this fixes scaling artifacts that can happen with bilinear,
trilinear or anisotropic filtering alone.
Since the previous commit did not bring back the relevant setting, we fix this
shortcoming by just enabling it in all cases where it is known to help.
2023-11-29 21:09:21 +01:00
sfan5 7f9326805c Return texture filter settings to previous state
This partially reverts commit 72ef90885d.

fixes #14007
2023-11-29 21:09:21 +01:00
Muhammad Rifqi Priyo Susanto 53886dcdb5
Formspec: Pass the second-touch event as is (#13872)
The second-touch event is passed to the GUIFormSpecMenu::OnEvent() function as a touch event.
There are two types of event for inventory formspec: (1) mouse event and (2) touch event.
The touch event is just a modifier of the mouse event.


Co-authored-by: Gregor Parzefall <82708541+grorp@users.noreply.github.com>
2023-11-28 07:00:07 +07:00
grorp 771da80bbb
Make it possible again to see item tooltips on Android (#14029)
This change is a quick fix so that item tooltips show again on Android.
2023-11-25 17:07:07 +01:00
grorp 4255ac3022
Mainmenu: Avoid the header being displayed behind the formspec (#13924)
This change keeps the current header placement code, but adds additional code to make sure the header doesn't end up behind the formspec.
2023-11-25 17:04:33 +01:00
Desour 585e6aa80b Clamp values in read_ARGB8 2023-11-19 20:45:18 +01:00
Desour 1bc74b0ba1 Fix undefined inf to s32 cast in GUIScrollBar::setPos 2023-11-19 20:45:18 +01:00
Desour 73e85b2ebb Fix cached wanted_range and camera_fov being written with out-of-range value 2023-11-19 20:45:18 +01:00
Muhammad Rifqi Priyo Susanto aa912e90a7
Make text containers wider in the Volume Change dialog (#13995)
These containers are widened to account for translations.
2023-11-15 07:00:03 +07:00
superfloh247 7cb20dd6c2
Fix undefined behaviour in modulo360f (#13976)
Resolves a crash on macOS/arm64 by no longer depending on UB.
2023-11-12 20:08:33 +01:00
updatepo.sh 8abb5796ed Update example conf and settings translations 2023-11-11 12:09:35 +01:00
JosiahWI 56902745c8
Extract updateClouds method from updateFrame (#13939)
Co-authored-by: Gregor Parzefall <82708541+grorp@users.noreply.github.com>
2023-11-08 07:00:59 +07:00
corpserot 9e952603b2
Lump MT_LOGCOLOR env together with other color env (#13887) 2023-11-08 07:00:36 +07:00
Muhammad Rifqi Priyo Susanto 7213ff7a00
Resolves some warnings for Android version (#13862) 2023-11-05 19:02:01 +01:00
Nils Dagsson Moskopp 2025dcffbd Revert "Don't trigger a key event if a key with the same associated char was pressed (#13773)"
This partially reverts commit d57c936b08.

The reverted commit prevented recognition of key combinations.
It correctly changed a test case to no longer use “KEY_NUMPAD_5”.

Several keyboard layouts use a key combination to input a “+” (e.g. Neo2);
therefore some users could no longer input “+” to increase the view range.

Co-authored-by: savilli <78875209+savilli@users.noreply.github.com>
2023-10-30 21:23:59 +01:00
Desour ec7a1f02e7 Fix out-of-bounds access in NodeDefManager::nodeboxConnects 2023-10-30 21:23:47 +01:00
Desour 1d31533601 Reformat rot array in NodeDefManager::nodeboxConnects, to make it less magic 2023-10-30 21:23:47 +01:00
Gregor Parzefall 96197025b9
Fix hypertext[] sometimes calculating incorrect scrollbar height (#13943) 2023-10-29 17:54:31 +01:00
Muhammad Rifqi Priyo Susanto 1363059416
Fix issues in Minetest's English texts (#13913)
Co-authored-by: Gregor Parzefall <82708541+grorp@users.noreply.github.com>
Co-authored-by: rubenwardy <rw@rubenwardy.com>
Co-authored-by: Desour <ds.desour@proton.me>
Co-authored-by: sfan5 <sfan5@live.de>
2023-10-29 12:24:39 +01:00
Desour b3988d964a Sounds: Do not fade paused sounds 2023-10-29 00:40:07 +02:00
Desour 2ad17136dc Sounds: Fix dtime being in milliseconds 2023-10-29 00:40:07 +02:00
Desour b2aa5d9261 Sounds: Don't pause new sounds when paused 2023-10-29 00:39:38 +02:00
rubenwardy 4ee32c5441
Add package update detection on Content tab (#13807) 2023-10-28 17:33:44 +01:00
Desour 454eb3901d Inventory: Fix deleted inventory being used for regaining locked lists 2023-10-27 18:47:07 +02:00