mirror of https://github.com/minetest/minetest.git
8e5bd82c4d
* fix integer overflow in mapgen
Some calculations involving the magic seed had overflow because the result of an intermediate arithmetic step could not fit in an s32. By making the magic seed unsigned, the other operand in the equation will be cast to unsigned, and possibly other operands or intermediate operands. This will result in unexpected behavior if an operand is negative, which is technically possible, but logically should not happen.
* comment noise2d bitshift
While working through the code I was momentarily concerned that the right bitshift in noise2d could fill ones in some cases. It turns out that with signed integers, this is indeed true, but this one is shifting an unsigned integer, so the behavior is as expected. I put a comment here to clarify this, in case someone else wonders the same thing down the line.
* noise2d and noise3d unittests
I have added 3 tests each for noise2d and noise3d, testing all zero inputs, a very large seed (case which caused UB in the old implementation) and some fun primes I picked for no particular reason. This should be sufficient to demonstrate that the behavior of the new implementation has not changed. I used uniform initialization because it is a good feature of C++11. Please do not explode.
* uncomment the noise2d bitshift
This reverts commit
|
||
|---|---|---|
| .. | ||
| test_mod/test_mod | ||
| test_world | ||
| CMakeLists.txt | ||
| test.cpp | ||
| test.h | ||
| test_activeobject.cpp | ||
| test_address.cpp | ||
| test_areastore.cpp | ||
| test_authdatabase.cpp | ||
| test_ban.cpp | ||
| test_clientactiveobjectmgr.cpp | ||
| test_collision.cpp | ||
| test_compression.cpp | ||
| test_config.h.in | ||
| test_connection.cpp | ||
| test_eventmanager.cpp | ||
| test_filepath.cpp | ||
| test_gameui.cpp | ||
| test_gettext.cpp | ||
| test_inventory.cpp | ||
| test_irrptr.cpp | ||
| test_keycode.cpp | ||
| test_lua.cpp | ||
| test_map.cpp | ||
| test_map_settings_manager.cpp | ||
| test_mapnode.cpp | ||
| test_modchannels.cpp | ||
| test_modmetadatadatabase.cpp | ||
| test_nodedef.cpp | ||
| test_noderesolver.cpp | ||
| test_noise.cpp | ||
| test_objdef.cpp | ||
| test_profiler.cpp | ||
| test_random.cpp | ||
| test_schematic.cpp | ||
| test_serialization.cpp | ||
| test_server_shutdown_state.cpp | ||
| test_serveractiveobjectmgr.cpp | ||
| test_servermodmanager.cpp | ||
| test_settings.cpp | ||
| test_socket.cpp | ||
| test_threading.cpp | ||
| test_utilities.cpp | ||
| test_voxelalgorithms.cpp | ||
| test_voxelarea.cpp | ||
| test_voxelmanipulator.cpp | ||