Primordial cavern layer (#12)

* bring in the art assets from ClockGen's "better_caves_modpack" under CC BY 4.0,, code written from scratch.

* update mapgen_helper

* import ClockGen's giant mushroom schematics, make them and giant ferns growable

* add giant jungle mushroom, rough out actual cavern layer code framework

* fungal ceiling decorations

* decorate fungal floor a bit

* update mapgen_helper

* update primordial mushroom schematic placement to ensure it fits

* add giant mycelium fungoidal structure

* add giant mycelium to mapgen

* fix settings for giant mycelium

* make mycelium grow when players aren't present

* allow mycelium growth to pause when it hits unloaded areas

* add a use for giant mycelium

* make giant mushrooms edible, make jungle trees growable

* rough out the jungle biome

* Make a spectrum of jungle growth

* optimize pngs, add is_ground_content to everything

* use custom is_ground_content method

* fix a crash with veinstone, and simplify nvals_cave lookup now that overgen covers the same area

* more fixes for overgen support

* remove unintentional airspace from underside of slade

* fix for overgen crash in level 2

* primordial column material, add sealed shafts to underworld

* add seal block

* Set up puzzle seals to be able to dig a staircase shaft through the slade layer. TODO: the puzzle to guard the trigger.

* puzzle seals now fully functional. Need to add clues for decoding the keys next.

* add a small bit of anti-griefing - the seal breach bell only tolls globally 13 times per activation

* add flowers to the underworld warrior bones

* switch to a different key bell

* fancy up the puzzle seal temples with some custom blocks, add sub-slade grid passages

* add a clue to the seal formspec

* tweak background of inscription 2 so it's less obviously a copy of the background for inscription 1

* switch to compositing to save a few bytes

* fancy up the seal's upper surface with inscriptions to make the formspec feel consistent

* puzzle particle, bones were only spawning on top of structures

* fix ice/oil on level 3, tweak some loot probabilities

* add trail mod support

* remove deprecated files

* boost default plant growth delay, add growing selection boxes

* update map colours

* add named waypoints to the underworld

* try a more efficient way of changing the interiors of columns

* polishing up the Primordial layer

* update guide with some Primordial teasers

* updated magma sea screenshot

* update mapgen_helper and subterrane

* reduce density of megaflora a bit - was too hard to walk through

* spreading_dirt_type depends on light, create my own ABM instead

* add names to the glowing pits and some of the ruins

* separate setting for ruin markers

* record identity of slade-breachers

* make mycelia climbable

* update subterrane

* change surface tunnel detection to allow above-ground stalactites and stalagmites

* add rare thicker Goblin Caps, suitable for use as huts.

* better goblin cap schematics

* update colours

* make it slightly harder to dig down through amethyst sheathing of pits

* fixing up fungus light sensitivity, tree growth code

* fix a few minor bugs

* update deprecated functions

* add various eating sounds

* make mapping kit requirement more flexible

* update spindlestem growth code, remove deprecated functions

* fix leftover undefined variable

* add fireflies to primordial, spread out the post-mapgen node timer for plant matter a bit more.

* fix bones formspec

* add lbm to upgrade old bones

* fix slade undiggability

* make torchspines smokey and manually lightable

* fix drop definitions

* generate dry stalactites in near-surface caverns.

* caverns become far too smokey, alas

* add pitter patter of spore tree spores, alternate paper recipe

* new mapgen_helper metrics

* add smokey back to torchspine now that it can be dialed down a bit

* replace glowstone texture with a new animated one

* switch from ABM to node timer for mapgen mycelium growth

* make mapgen mycelium timer delay configurable

* improve the efficiency of giant mycelium growth using flat node array, fewer dereferences

* remove the smoke from torchspines again - it doesn't dissipate that deep underground

* give slade a more muted, gloomy hue to differentiate it from nether stone

* update screenshots with new slade colors

* update mapgen_helper

df_mapitems/castle_coral.lua

@@ -13,6 +13,7 @@ minetest.register_node("df_mapitems:castle_coral", {
 	_doc_items_longdesc = df_mapitems.doc.castle_coral_desc,
 	_doc_items_usagehelp = df_mapitems.doc.castle_coral_usage,
 	drawtype = "mesh",
+	is_ground_content = false,
 	light_source = 2,
 	mesh = "octagonal_coral.obj",
 	drop = "df_mapitems:castle_coral_skeleton",
@@ -34,6 +35,7 @@ minetest.register_node("df_mapitems:castle_coral_skeleton", {
 	drawtype = "mesh",
 	mesh = "octagonal_coral.obj",
 	paramtype = "light",
+	is_ground_content = false,
 	groups = {cracky = 3},
 	sounds = default.node_sound_stone_defaults(),
 })

df_mapitems/cave_coral.lua

@@ -10,8 +10,14 @@ minetest.register_node("df_mapitems:cave_coral_3", {
 	drop = "default:coral_skeleton",
 	light_source = 3,
 	paramtype2 = "facedir",
+	is_ground_content = false,
 	groups = {cracky = 3, dfcaverns_cave_coral = 1},
 	sounds = default.node_sound_stone_defaults(),
+	on_timer = function(pos)
+		if minetest.find_node_near(pos, 1, {"default:water_source"}) == nil then
+			minetest.set_node(pos, {name="default:coral_skeleton"})
+		end
+	end,
 })
 
 minetest.register_node("df_mapitems:cave_coral_2", {
@@ -22,8 +28,14 @@ minetest.register_node("df_mapitems:cave_coral_2", {
 	drop = "default:coral_skeleton",
 	light_source = 2,
 	paramtype2 = "facedir",
+	is_ground_content = false,
 	groups = {cracky = 3, dfcaverns_cave_coral = 1},
 	sounds = default.node_sound_stone_defaults(),
+	on_timer = function(pos)
+		if minetest.find_node_near(pos, 1, {"default:water_source"}) == nil then
+			minetest.set_node(pos, {name="default:coral_skeleton"})
+		end
+	end,
 })
 
 minetest.register_node("df_mapitems:cave_coral_1", {
@@ -34,8 +46,14 @@ minetest.register_node("df_mapitems:cave_coral_1", {
 	drop = "default:coral_skeleton",
 	light_source = 1,
 	paramtype2 = "facedir",
+	is_ground_content = false,
 	groups = {cracky = 3, dfcaverns_cave_coral = 1},
 	sounds = default.node_sound_stone_defaults(),
+	on_timer = function(pos)
+		if minetest.find_node_near(pos, 1, {"default:water_source"}) == nil then
+			minetest.set_node(pos, {name="default:coral_skeleton"})
+		end
+	end,
 })
 
 local coral_names = {"df_mapitems:cave_coral_1", "df_mapitems:cave_coral_2", "df_mapitems:cave_coral_3"}

df_mapitems/cave_pearls.lua

@@ -12,6 +12,7 @@ minetest.register_node("df_mapitems:cave_pearls", {
 	paramtype2 = "facedir",
 	groups = {cracky = 2},
 	walkable = false,
+	is_ground_content = false,
 	climbable = true,
 	light_source = 4,
 	node_box = {

df_mapitems/config.lua

@@ -7,11 +7,11 @@ local print_settingtypes = false
 local function setting(stype, name, default, description)
 	local value
 	if stype == "bool" then
-		value = minetest.setting_getbool(CONFIG_FILE_PREFIX..name)
+		value = minetest.settings:get_bool(CONFIG_FILE_PREFIX..name, default)
 	elseif stype == "string" then
-		value = minetest.setting_get(CONFIG_FILE_PREFIX..name)
+		value = minetest.settings:get(CONFIG_FILE_PREFIX..name)
 	elseif stype == "int" or stype == "float" then
-		value = tonumber(minetest.setting_get(CONFIG_FILE_PREFIX..name))
+		value = tonumber(minetest.settings:get(CONFIG_FILE_PREFIX..name))
 	end
 	if value == nil then
 		value = default

df_mapitems/crystals_mese.lua

@@ -8,9 +8,9 @@ minetest.register_node("df_mapitems:glow_mese", {
 	_doc_items_longdesc = df_mapitems.doc.glow_mese_desc,
 	_doc_items_usagehelp = df_mapitems.doc.glow_mese_usage,
 	tiles = {"dfcaverns_glow_mese.png"},
-	is_ground_content = true,
 	groups = {cracky=3},
 	sounds = default.node_sound_glass_defaults(),
+	is_ground_content = false,
 	light_source = 13,
 	paramtype = "light",
 	use_texture_alpha = true,
@@ -36,7 +36,7 @@ minetest.register_node("df_mapitems:mese_crystal", {
 	drawtype = "mesh",
 	mesh = "underch_crystal.obj",
 	light_source = 12,
-	is_ground_content = true,
+	is_ground_content = false,
 	sounds = default.node_sound_glass_defaults(),
 	use_texture_alpha = true,
 	sunlight_propagates = true,

df_mapitems/crystals_ruby.lua

@@ -7,7 +7,7 @@ minetest.register_node("df_mapitems:glow_ruby_ore", {
 	_doc_items_longdesc = df_mapitems.doc.glow_ruby_ore_desc,
 	_doc_items_usagehelp = df_mapitems.doc.glow_ruby_ore_usage,
 	tiles = {"dfcaverns_glow_ruby_ore.png"},
-	is_ground_content = true,
+	is_ground_content = false,
 	groups = {cracky=2},
 	sounds = default.node_sound_glass_defaults(),
 })
@@ -25,6 +25,7 @@ minetest.register_node("df_mapitems:big_crystal", {
 	use_texture_alpha = true,
 	paramtype = "light",
 	paramtype2 = "facedir",
+	is_ground_content = false,
 	sunlight_propagates = true,
 	light_source = 12,
 	groups = {cracky=2, dfcaverns_big_crystal = 1},
@@ -52,6 +53,7 @@ minetest.register_node("df_mapitems:med_crystal", {
 	use_texture_alpha = true,
 	paramtype = "light",
 	paramtype2 = "facedir",
+	is_ground_content = false,
 	sunlight_propagates = true,
 	light_source = 12,
 	groups = {cracky=2, dfcaverns_big_crystal = 1},
@@ -81,6 +83,7 @@ minetest.register_node("df_mapitems:big_crystal_30", {
 	paramtype = "light",
 	paramtype2 = "facedir",
 	sunlight_propagates = true,
+	is_ground_content = false,
 	light_source = 12,
 	drop = "df_mapitems:big_crystal",
 	groups = {cracky=2, dfcaverns_big_crystal = 1},
@@ -132,6 +135,7 @@ minetest.register_node("df_mapitems:med_crystal_30", {
 	paramtype = "light",
 	paramtype2 = "facedir",
 	sunlight_propagates = true,
+	is_ground_content = false,
 	light_source = 12,
 	drop = "df_mapitems:med_crystal",
 	groups = {cracky=2, dfcaverns_big_crystal = 1},
@@ -168,6 +172,7 @@ minetest.register_node("df_mapitems:big_crystal_30_45", {
 	paramtype = "light",
 	paramtype2 = "facedir",
 	sunlight_propagates = true,
+	is_ground_content = false,
 	light_source = 12,
 	drop = "df_mapitems:big_crystal",
 	groups = {cracky=2, dfcaverns_big_crystal = 1},
@@ -205,6 +210,7 @@ minetest.register_node("df_mapitems:med_crystal_30_45", {
 	paramtype = "light",
 	paramtype2 = "facedir",
 	sunlight_propagates = true,
+	is_ground_content = false,
 	light_source = 12,
 	drop = "df_mapitems:med_crystal",
 	groups = {cracky=2, dfcaverns_big_crystal = 1},

df_mapitems/crystals_salt.lua

@@ -16,6 +16,7 @@ minetest.register_node("df_mapitems:salt_crystal", {
 	sounds = default.node_sound_glass_defaults(),
 	use_texture_alpha = true,
 	sunlight_propagates = true,
+	is_ground_content = false,
 	on_place = df_mapitems.place_against_surface,
 })
 
@@ -26,7 +27,7 @@ minetest.register_node("df_mapitems:salty_cobble", {
 	tiles = {"default_cobble.png^dfcaverns_salty.png"},
 	groups = {cracky = 3, stone = 1, lava_heatable = 1},
 	_magma_conduits_heats_to = "default:cobble",
-	is_ground_content = true,
+	is_ground_content = false,
 	light_source = 2,
 	drop = 'default:cobble',
 	sounds = default.node_sound_stone_defaults(),

df_mapitems/depends.txt

@@ -1,7 +0,0 @@
-default
-subterrane
-df_farming?
-farming?
-intllib?
-doc?
-radiant_damage?

df_mapitems/description.txt

@@ -1 +0,0 @@
-Various node types used by the dfcaverns mapgen mod. Includes cave coral, flowstone, glowing crystals, glow worms, moss and fungi ground cover, and snare weed.

df_mapitems/flowstone.lua

@@ -13,6 +13,7 @@ df_mapitems.dry_stalagmite_ids = subterrane.register_stalagmite_nodes("df_mapite
 	},
 	groups = {cracky = 3, stone = 2},
 	sounds = default.node_sound_stone_defaults(),
+	is_ground_content = false,
 })
 
 minetest.register_node("df_mapitems:dry_flowstone", {
@@ -22,7 +23,7 @@ minetest.register_node("df_mapitems:dry_flowstone", {
 	tiles = {"default_stone.png^[brighten"},
 	groups = {cracky = 3, stone = 1, lava_heatable = 1},
 	_magma_conduits_heats_to = "default:cobble",
-	is_ground_content = true,
+	is_ground_content = false,
 	drop = 'default:cobble',
 	sounds = default.node_sound_stone_defaults(),
 })
@@ -38,6 +39,7 @@ df_mapitems.wet_stalagmite_ids = subterrane.register_stalagmite_nodes("df_mapite
 	},
 	groups = {cracky = 3, stone = 2, subterrane_wet_dripstone = 1},
 	sounds = default.node_sound_stone_defaults(),
+	is_ground_content = false,
 }, "df_mapitems:dry_stal")
 
 
@@ -48,7 +50,7 @@ minetest.register_node("df_mapitems:wet_flowstone", {
 	tiles = {"default_stone.png^[brighten^dfcaverns_dripstone_streaks.png"},
 	groups = {cracky = 3, stone = 1, subterrane_wet_dripstone = 1, lava_heatable = 1},
 	_magma_conduits_heats_to = "df_mapitems:dry_flowstone",
-	is_ground_content = true,
+	is_ground_content = false,
 	drop = 'default:cobble',
 	sounds = default.node_sound_stone_defaults(),
 })

df_mapitems/glow_worms.lua

@@ -24,7 +24,7 @@ minetest.register_node("df_mapitems:glow_worm", {
 	},
 	inventory_image = "dfcaverns_glow_worm.png",
 	wield_image = "dfcaverns_glow_worm.png",
-	is_ground_content = true,
+	is_ground_content = false,
 	groups = {oddly_breakable_by_hand=3, light_sensitive_fungus = 12},
 	_dfcaverns_dead_node = "air",
 	light_source = 9,

df_mapitems/ground_cover.lua

@@ -8,14 +8,14 @@ local S, NS = dofile(MP.."/intllib.lua")
 -- cyan/dark cyan
 
 minetest.register_node("df_mapitems:dirt_with_cave_moss", {
-	description = S("Dirt With Cave Moss"),
+	description = S("Dirt with Cave Moss"),
 	_doc_items_longdesc = df_mapitems.doc.cave_moss_desc,
 	_doc_items_usagehelp = df_mapitems.doc.cave_moss_usage,
 	tiles = {"default_dirt.png^dfcaverns_cave_moss.png", "default_dirt.png", 
 		{name = "default_dirt.png^dfcaverns_cave_moss_side.png",
 			tileable_vertical = false}},
 	drop = "default:dirt",
-	is_ground_content = true,
+	is_ground_content = false,
 	light_source = 2,
 	paramtype = "light",
 	groups = {crumbly = 3, soil = 1, light_sensitive_fungus = 8},
@@ -45,18 +45,31 @@ minetest.register_abm{
 	end,
 }
 
+if minetest.get_modpath("trail") and trail and trail.register_trample_node then	
+	local HARDPACK_PROBABILITY = minetest.settings:get("trail_hardpack_probability") or 0.5 -- Chance walked dirt/grass is worn and compacted to trail:trail.
+	local HARDPACK_COUNT = minetest.settings:get("trail_hardpack_count") or 5 -- Number of times the above chance needs to be passed for soil to compact.
+
+	trail.register_trample_node("df_mapitems:dirt_with_cave_moss", {
+		trampled_node_def_override = {description = S("Dirt with Cave Moss and Footprint"),},
+		hard_pack_node_name = "trail:trail",
+		footprint_opacity = 128,
+		hard_pack_probability = HARDPACK_PROBABILITY,
+		hard_pack_count = HARDPACK_COUNT,
+	})	
+end
+
 --------------------------------------------------
 -- floor fungus
 
 -- white/yellow
 
 minetest.register_node("df_mapitems:cobble_with_floor_fungus", {
-	description = S("Cobblestone With Floor Fungus"),
+	description = S("Cobblestone with Floor Fungus"),
 	_doc_items_longdesc = df_mapitems.doc.floor_fungus_desc,
 	_doc_items_usagehelp = df_mapitems.doc.floor_fungus_usage,
 	tiles = {"default_cobble.png^dfcaverns_floor_fungus.png"},
 	drops = "default:cobble",
-	is_ground_content = true,
+	is_ground_content = false,
 	paramtype = "light",
 	groups = {cracky = 3, stone = 2, slippery = 1, light_sensitive_fungus = 8},
 	_dfcaverns_dead_node = "default:cobble",
@@ -66,12 +79,12 @@ minetest.register_node("df_mapitems:cobble_with_floor_fungus", {
 })
 
 minetest.register_node("df_mapitems:cobble_with_floor_fungus_fine", {
-	description = S("Cobblestone With Floor Fungus"),
+	description = S("Cobblestone with Floor Fungus"),
 	_doc_items_longdesc = df_mapitems.doc.floor_fungus_desc,
 	_doc_items_usagehelp = df_mapitems.doc.floor_fungus_usage,
 	tiles = {"default_cobble.png^dfcaverns_floor_fungus_fine.png"},
 	drops = "default:cobble",
-	is_ground_content = true,
+	is_ground_content = false,
 	paramtype = "light",
 	groups = {cracky = 3, stone = 2, slippery = 1, light_sensitive_fungus = 8},
 	_dfcaverns_dead_node = "default:cobble",
@@ -106,13 +119,14 @@ minetest.register_abm{
 -- Hoar moss
 
 minetest.register_node("df_mapitems:ice_with_hoar_moss", {
-	description = S("Ice With Hoar Moss"),
+	description = S("Ice with Hoar Moss"),
 	_doc_items_longdesc = df_mapitems.doc.hoar_moss_desc,
 	_doc_items_usagehelp = df_mapitems.doc.hoar_moss_usage,
 	tiles = {"default_ice.png^dfcaverns_hoar_moss.png"},
 	drops = "default:ice",
 	paramtype = "light",
 	light_source = 2,
+	is_ground_content = false,
 	groups = {cracky = 3, puts_out_fire = 1, cools_lava = 1, slippery = 2, light_sensitive_fungus = 8},
 	sounds = default.node_sound_glass_defaults(),
 	_dfcaverns_dead_node = "default:ice",

df_mapitems/mod.conf

@@ -1,4 +1,4 @@
 name = df_mapitems
 description = Various node types used by the dfcaverns mapgen mod. Includes cave coral, flowstone, glowing crystals, glow worms, moss and fungi ground cover, and snare weed.
 depends = default, subterrane
-optional_depends = df_farming, farming, intllib, doc, radiant_damage
+optional_depends = df_farming, farming, intllib, doc, radiant_damage, trail

df_mapitems/snareweed.lua

@@ -10,7 +10,7 @@ minetest.register_node("df_mapitems:snareweed", {
 	drawtype="plantlike_rooted",
 	paramtype2 = "leveled",
 	special_tiles = {{name = "dfcaverns_snareweed.png", tileable_vertical = true}},
-	is_ground_content = true,
+	is_ground_content = false,
 	drop = 'default:dirt',
 	light_source = 6,
 	groups = {crumbly = 3, soil = 1},
@@ -25,7 +25,7 @@ if df_mapitems.config.snareweed_damage then
 		if timer >= 1 then
 			timer = timer - 1
 			for _, player in pairs(minetest.get_connected_players()) do
-				local player_pos = player:getpos() -- node player's feet are in this location.
+				local player_pos = player:get_pos() -- node player's feet are in this location.
 				local rounded_pos = vector.round(player_pos)
 				local nearby_nodes = minetest.find_nodes_in_area(vector.add(rounded_pos, {x=0, y= -8, z=0}), rounded_pos, {"df_mapitems:snareweed"})
 				for _, node_pos in ipairs(nearby_nodes) do

df_mapitems/util.lua

@@ -59,7 +59,7 @@ df_mapitems.place_against_surface = function(itemstack, placer, pointed_thing)
 	end
 	-- add the node and remove 1 item from the itemstack
 	minetest.add_node(above_pos, {name = itemstack:get_name(), param2 = param2})
-	if not minetest.setting_getbool("creative_mode") and not minetest.check_player_privs(placer, "creative") then
+	if not minetest.settings:get_bool("creative_mode", false) and not minetest.check_player_privs(placer, "creative") then
 		itemstack:take_item()
 	end
 	return itemstack

df_mapitems/veinstone.lua

@@ -9,7 +9,7 @@ minetest.register_node("df_mapitems:veinstone", {
 	tiles = {"default_stone.png^dfcaverns_veins.png"},
 	groups = {cracky = 3, stone = 1, lava_heatable = 1},
 	_magma_conduits_heats_to = "default:cobble",
-	is_ground_content = true,
+	is_ground_content = false,
 	light_source = 2,
 	drop = 'default:cobble',
 	sounds = default.node_sound_stone_defaults(),