Primordial cavern layer (#12)

* bring in the art assets from ClockGen's "better_caves_modpack" under CC BY 4.0,, code written from scratch.

* update mapgen_helper

* import ClockGen's giant mushroom schematics, make them and giant ferns growable

* add giant jungle mushroom, rough out actual cavern layer code framework

* fungal ceiling decorations

* decorate fungal floor a bit

* update mapgen_helper

* update primordial mushroom schematic placement to ensure it fits

* add giant mycelium fungoidal structure

* add giant mycelium to mapgen

* fix settings for giant mycelium

* make mycelium grow when players aren't present

* allow mycelium growth to pause when it hits unloaded areas

* add a use for giant mycelium

* make giant mushrooms edible, make jungle trees growable

* rough out the jungle biome

* Make a spectrum of jungle growth

* optimize pngs, add is_ground_content to everything

* use custom is_ground_content method

* fix a crash with veinstone, and simplify nvals_cave lookup now that overgen covers the same area

* more fixes for overgen support

* remove unintentional airspace from underside of slade

* fix for overgen crash in level 2

* primordial column material, add sealed shafts to underworld

* add seal block

* Set up puzzle seals to be able to dig a staircase shaft through the slade layer. TODO: the puzzle to guard the trigger.

* puzzle seals now fully functional. Need to add clues for decoding the keys next.

* add a small bit of anti-griefing - the seal breach bell only tolls globally 13 times per activation

* add flowers to the underworld warrior bones

* switch to a different key bell

* fancy up the puzzle seal temples with some custom blocks, add sub-slade grid passages

* add a clue to the seal formspec

* tweak background of inscription 2 so it's less obviously a copy of the background for inscription 1

* switch to compositing to save a few bytes

* fancy up the seal's upper surface with inscriptions to make the formspec feel consistent

* puzzle particle, bones were only spawning on top of structures

* fix ice/oil on level 3, tweak some loot probabilities

* add trail mod support

* remove deprecated files

* boost default plant growth delay, add growing selection boxes

* update map colours

* add named waypoints to the underworld

* try a more efficient way of changing the interiors of columns

* polishing up the Primordial layer

* update guide with some Primordial teasers

* updated magma sea screenshot

* update mapgen_helper and subterrane

* reduce density of megaflora a bit - was too hard to walk through

* spreading_dirt_type depends on light, create my own ABM instead

* add names to the glowing pits and some of the ruins

* separate setting for ruin markers

* record identity of slade-breachers

* make mycelia climbable

* update subterrane

* change surface tunnel detection to allow above-ground stalactites and stalagmites

* add rare thicker Goblin Caps, suitable for use as huts.

* better goblin cap schematics

* update colours

* make it slightly harder to dig down through amethyst sheathing of pits

* fixing up fungus light sensitivity, tree growth code

* fix a few minor bugs

* update deprecated functions

* add various eating sounds

* make mapping kit requirement more flexible

* update spindlestem growth code, remove deprecated functions

* fix leftover undefined variable

* add fireflies to primordial, spread out the post-mapgen node timer for plant matter a bit more.

* fix bones formspec

* add lbm to upgrade old bones

* fix slade undiggability

* make torchspines smokey and manually lightable

* fix drop definitions

* generate dry stalactites in near-surface caverns.

* caverns become far too smokey, alas

* add pitter patter of spore tree spores, alternate paper recipe

* new mapgen_helper metrics

* add smokey back to torchspine now that it can be dialed down a bit

* replace glowstone texture with a new animated one

* switch from ABM to node timer for mapgen mycelium growth

* make mapgen mycelium timer delay configurable

* improve the efficiency of giant mycelium growth using flat node array, fewer dereferences

* remove the smoke from torchspines again - it doesn't dissipate that deep underground

* give slade a more muted, gloomy hue to differentiate it from nether stone

* update screenshots with new slade colors

* update mapgen_helper

df_trees/spindlestem.lua

@@ -46,7 +46,7 @@ local stem_on_place = function(itemstack, placer, pointed_thing)
 
 	-- add the node and remove 1 item from the itemstack
 	minetest.add_node(pt.above, {name = itemstack:get_name(), param2 = new_param2})
-	if not minetest.setting_getbool("creative_mode") then
+	if not minetest.settings:get_bool("creative_mode", false) then
 		itemstack:take_item()
 	end
 	return itemstack
@@ -64,7 +64,7 @@ minetest.register_node("df_trees:spindlestem_stem", {
 	description = S("Spindlestem"),
 	_doc_items_longdesc = df_trees.doc.spindlestem_desc,
 	_doc_items_usagehelp = df_trees.doc.spindlestem_usage,
-	is_ground_content = true,
+	is_ground_content = false,
 	groups = {wood = 1, choppy = 2, oddly_breakable_by_hand = 1, flammable = 2, spindlestem = 1},
 	sounds = default.node_sound_wood_defaults(),
 	tiles = {
@@ -95,7 +95,7 @@ local register_spindlestem_type = function(item_suffix, colour_name, colour_code
 	
 	minetest.register_node(cap_item, {
 		description = S("@1 Spindlestem Cap", colour_name),
-		is_ground_content = true,
+		is_ground_content = false,
 		_doc_items_longdesc = df_trees.doc["spindlestem_cap_"..item_suffix.."_desc"],
 		_doc_items_usagehelp = df_trees.doc["spindlestem_cap_"..item_suffix.."_usage"],
 		groups = {wood = 1, choppy = 2, oddly_breakable_by_hand = 1, flammable = 2, spindlestem = 1},
@@ -149,23 +149,34 @@ local register_spindlestem_type = function(item_suffix, colour_name, colour_code
 		
 		on_place = stem_on_place,
 		on_timer = function(pos, elapsed)
-			local above = vector.add(pos, {x=0,y=1,z=0})
-			local node_above = minetest.get_node(above)
-			local above_def = minetest.registered_nodes[node_above.name]
-			if not above_def or not above_def.buildable_to then
-				-- can't grow any more, exit
-				return
-			end
 			local meta = minetest.get_meta(pos)
 			local height = meta:get_int("spindlestem_to_grow")
+			local delay = meta:get_int("spindlestem_delay")
+			if delay == 0 then
+				delay = growth_delay() -- compatibility code to ensure no crash for previous version
+			end
 			local node = minetest.get_node(pos)
-			minetest.set_node(pos, {name="df_trees:spindlestem_stem", param2 = node.param2})
-			minetest.set_node(above, {name=cap_item, param2 = node.param2})
-			height = height - 1
+		
+			while height > 0 and elapsed >= delay do
+				elapsed = elapsed - delay
+				local this_pos = pos
+				pos = vector.add(this_pos, {x=0,y=1,z=0})
+				local node_above = minetest.get_node(pos)
+				local above_def = minetest.registered_nodes[node_above.name]
+				if not above_def or not above_def.buildable_to then
+					-- can't grow any more, exit
+					return
+				end
+				minetest.set_node(this_pos, {name="df_trees:spindlestem_stem", param2 = node.param2})
+				minetest.set_node(pos, {name=cap_item, param2 = node.param2})
+				height = height - 1
+			end
+			
 			if height > 0 then
-				meta = minetest.get_meta(above)
+				meta = minetest.get_meta(pos)
 				meta:set_int("spindlestem_to_grow", height)
-				minetest.get_node_timer(above):start(growth_delay())
+				meta:set_int("spindlestem_delay", delay)
+				minetest.get_node_timer(pos):start(delay-elapsed)
 			end
 		end,
 	})
@@ -223,13 +234,6 @@ local register_spindlestem_type = function(item_suffix, colour_name, colour_code
 	end
 end
 
-local seedling_construct = function(pos)
-	local below_node = minetest.get_node(vector.add(pos, {x=0,y=-1,z=0}))
-	if minetest.get_item_group(below_node.name, "soil") > 0 then
-		minetest.get_node_timer(pos):start(growth_delay())
-	end
-end
-
 minetest.register_node("df_trees:spindlestem_seedling", {
 	description = S("Spindlestem Spawn"),
 	_doc_items_longdesc = df_trees.doc.spindlestem_desc,
@@ -241,6 +245,7 @@ minetest.register_node("df_trees:spindlestem_seedling", {
 	drawtype = "nodebox",
 	paramtype = "light",
 	paramtype2 = "facedir",
+	is_ground_content = false,
 	walkable = false,
 	floodable = true,
 	node_box = {
@@ -251,9 +256,21 @@ minetest.register_node("df_trees:spindlestem_seedling", {
 	},
 	
 	on_place = stem_on_place,
-	on_construct = seedling_construct,
+	on_construct = function(pos)
+		if minetest.get_item_group(minetest.get_node({x=pos.x, y=pos.y-1, z=pos.z}).name, "soil") == 0 then
+			return
+		end
+		minetest.get_node_timer(pos):start(growth_delay())
+	end,
+	on_destruct = function(pos)
+		minetest.get_node_timer(pos):stop()
+	end,
 	
 	on_timer = function(pos, elapsed)
+		if df_farming and df_farming.kill_if_sunlit(pos) then
+			return
+		end
+
 		local cap_item = minetest.get_name_from_content_id(get_spindlestem_cap_type(pos))
 		local node = minetest.get_node(pos)
 		minetest.set_node(pos, {name=cap_item, param2 = node.param2})
@@ -264,8 +281,10 @@ minetest.register_node("df_trees:spindlestem_seedling", {
 		local height = math.random(1,3)
 		if count > 10 then height = height + 2 end -- if there are a lot of nearby spindlestems, grow taller
 		if height > 0 then
+			local delay = growth_delay()
 			meta:set_int("spindlestem_to_grow", height)
-			minetest.get_node_timer(pos):start(growth_delay())
+			meta:set_int("spindlestem_delay", delay)
+			minetest.get_node_timer(pos):start(delay)
 		end
 	end,
 })
@@ -314,7 +333,7 @@ local c_cyan = minetest.get_content_id("df_trees:spindlestem_cap_cyan")
 local c_golden = minetest.get_content_id("df_trees:spindlestem_cap_golden")
 
 get_spindlestem_cap_type = function(pos)
-	if pos.y > -100 or minetest.find_node_near(pos, 15, "group:tower_cap") then
+	if minetest.find_node_near(pos, 15, "group:tower_cap") then
 		return c_white
 	end
 	if minetest.find_node_near(pos, 15, "group:goblin_cap") then
@@ -330,7 +349,6 @@ get_spindlestem_cap_type = function(pos)
 	if copper then table.insert(possibilities, c_green) end
 	if iron then table.insert(possibilities, c_red) end
 	if iron and copper then table.insert(possibilities, c_cyan) end
-	
 	if #possibilities == 0 then
 		return c_white
 	else