add infomessage to the snow chatcommand, add a bit light to the lit star texture and allow en- and disabling snowfall ingame

init.lua

@@ -123,8 +123,7 @@ end
 
 -- Checks if the snow level is even at any given pos.
 -- Smooth Snow
-if snow.smooth_snow then
-	snow.is_uneven = function(pos)
+local function is_uneven(pos)
 	local num = minetest.get_node_level(pos)
 	local get_node = minetest.get_node
 	local add_node = minetest.add_node
@@ -171,7 +170,9 @@ if snow.smooth_snow then
 		return true
 	end
 end
-else
-	snow.is_uneven = function()
+
+function snow.is_uneven(pos)
+	if snow.smooth_snow then
+		return is_uneven(pos)
 	end
 end

src/falling_snow.lua

@@ -40,10 +40,6 @@ near torches and lava.
 --=============================================================
 
 
-if not snow.enable_snowfall then
-	return
-end
-
 local weather_legacy
 
 local read_weather_legacy = function ()
@@ -84,7 +80,7 @@ local PERSISTENCE3 = 0.5 -- 0.5
 local SCALE3 = 250 -- 250
 
 --Get snow at position.
-local get_snow = function(pos)
+local function get_snow(pos)
 	--Legacy support.
 	if weather_legacy == "snow" then
 		local perlin1 = minetest.get_perlin(112,3, 0.5, 150)
@@ -106,14 +102,19 @@ end
 local addvectors = vector and vector.add
 
 --Returns a random position between minp and maxp.
-local randpos = function (minp, maxp)
-	local x,y,z
+local function randpos(minp, maxp)
+	local x,z
 	if minp.x > maxp.x then
-		x = math.random(maxp.x,minp.x) else x = math.random(minp.x,maxp.x) end
-		y = minp.y
+		x = math.random(maxp.x,minp.x)
+	else
+		x = math.random(minp.x,maxp.x)
+	end
 	if minp.z > maxp.z then
-		z = math.random(maxp.z,minp.z) else z = math.random(minp.z,maxp.z) end
-	return {x=x,y=y,z=z}
+		z = math.random(maxp.z,minp.z)
+	else
+		z = math.random(minp.z,maxp.z)
+	end
+	return {x=x,y=minp.y,z=z}
 end
 
 local default_snow_particle = {
@@ -152,22 +153,20 @@ local function snow_fall(pos, player, animate)
 			break
 		end
 	end
-	if not ground_y then return end
-	pos = {x=pos.x, y=ground_y, z=pos.z}
-	local spos = {x=pos.x, y=ground_y+10, z=pos.z}
+	if not ground_y then
+		return
+	end
 
+	pos = {x=pos.x, y=ground_y, z=pos.z}
   
   	if get_snow(pos) then
   		if animate then
-	  		local minp = addvectors(spos, {x=-9, y=3, z=-9})
-			local maxp = addvectors(spos, {x= 9, y=5, z= 9})
-	  		local vel = {x=0, y=   -1, z=-1}
-			local acc = {x=0, y=   0, z=0}
+			local spos = {x=pos.x, y=ground_y+10, z=pos.z}
 			minetest.add_particlespawner(get_snow_particledef({
-				minpos = minp,
-				maxpos = maxp,
-				vel = vel,
-				acc = acc,
+				minpos = addvectors(spos, {x=-9, y=3, z=-9}),
+				maxpos = addvectors(spos, {x= 9, y=5, z= 9}),
+				vel = {x=0, y=-1, z=-1},
+				acc = {x=0, y=0, z=0},
 				playername = player:get_player_name()
 			}))
 		end
@@ -177,30 +176,21 @@ local function snow_fall(pos, player, animate)
 end
 
 -- Snow
-minetest.register_globalstep(function(dtime)
+local function calc_snowfall()
 	for _, player in pairs(minetest.get_connected_players()) do
 		local ppos = player:getpos()
 
-		local sminp = addvectors(ppos, {x=-20, y=0, z=-20})
-		local smaxp = addvectors(ppos, {x= 20, y=0, z= 20})
-	
 		-- Make sure player is not in a cave/house...
-		if get_snow(ppos) and minetest.get_node_light(ppos, 0.5) == 15 then
-
-			local minp = addvectors(ppos, {x=-9, y=3, z=-9})
-			local maxp = addvectors(ppos, {x= 9, y=5, z= 9})
-
-			local minp_deep = addvectors(ppos, {x=-5, y=3.2, z=-5})
-			local maxp_deep = addvectors(ppos, {x= 5, y=1.6, z= 5})
-
+		if get_snow(ppos)
+		and minetest.get_node_light(ppos, 0.5) == 15 then
+			local animate
+			if not snow.lighter_snowfall then
 				local vel = {x=0, y=-1, z=-1}
 				local acc = {x=0, y=0, z=0}
-			
-			if not snow.lighter_snowfall then
 				minetest.add_particlespawner(get_snow_particledef({
 					amount = 5,
-					minpos = minp,
-					maxpos = maxp,
+					minpos = addvectors(ppos, {x=-9, y=3, z=-9}),
+					maxpos = addvectors(ppos, {x= 9, y=5, z= 9}),
 					vel = vel,
 					acc = acc,
 					size = 25,
@@ -209,8 +199,8 @@ minetest.register_globalstep(function(dtime)
 
 				minetest.add_particlespawner(get_snow_particledef({
 					amount = 4,
-					minpos = minp_deep,
-					maxpos = maxp_deep,
+					minpos = addvectors(ppos, {x=-5, y=3.2, z=-5}),
+					maxpos = addvectors(ppos, {x= 5, y=1.6, z= 5}),
 					vel = vel,
 					acc = acc,
 					exptime = 4,
@@ -218,14 +208,27 @@ minetest.register_globalstep(function(dtime)
 					playername = player:get_player_name()
 				}))
 
-				if math.random(1,5) == 4 then	
-					snow_fall(randpos(sminp, smaxp), player)
-				end
+				animate = false
 			else
+				animate = true
+			end
+
 			if math.random(1,5) == 4 then	
-					snow_fall(randpos(sminp, smaxp), player, true)
+				snow_fall(
+					randpos(
+						addvectors(ppos, {x=-20, y=0, z=-20}),
+						addvectors(ppos, {x= 20, y=0, z= 20})
+					),
+					player,
+					animate
+				)
 			end
 		end
 	end
 end
+
+minetest.register_globalstep(function(dtime)
+	if snow.enable_snowfall then
+		calc_snowfall()
+	end
 end)

src/sled.lua

@@ -53,8 +53,7 @@ than I originally planned. :p  ~ LazyJ
 --
 
 local function is_water(pos)
-	local nn = minetest.get_node(pos).name
-	return minetest.get_item_group(nn, "water") ~= 0
+	return minetest.get_item_group(minetest.get_node(pos).name, "water") ~= 0
 end
 
 
@@ -77,7 +76,8 @@ local sled = {
 local players_sled = {}
 
 function sled:on_rightclick(clicker)
-	if (not self.driver) and snow.sleds then
+	if not self.driver
+	and snow.sleds then
 		players_sled[clicker:get_player_name()] = true
 		self.driver = clicker
 		self.object:set_attach(clicker, "", {x=0,y=-9,z=0}, {x=0,y=90,z=0})
@@ -126,13 +126,20 @@ end
 
 function sled:on_punch(puncher, time_from_last_punch, tool_capabilities, direction)
 	self.object:remove()
-	if puncher and puncher:is_player() then
+	if puncher
+	and puncher:is_player() then
 		puncher:get_inventory():add_item("main", "snow:sled")
 	end
 end
 
 
+local timer = 0
 minetest.register_globalstep(function(dtime)
+	timer = timer+dtime
+	if timer < 1 then
+		return
+	end
+	timer = 0
 	for _, player in pairs(minetest.get_connected_players()) do
 		if players_sled[player:get_player_name()] then
 			default.player_set_animation(player, "sit", 0)
@@ -140,14 +147,24 @@ minetest.register_globalstep(function(dtime)
 	end
 end)
 
+local timer = 0
 function sled:on_step(dtime)
-	if self.driver then
+	if not self.driver then
+		return
+	end
+	timer = timer+dtime
+	if timer < 1 then
+		return
+	end
+	timer = 0
 	local p = self.object:getpos()
 	p.y = p.y+0.4
 	local s = self.object:getpos()
 	s.y = s.y -0.5
 	local keys = self.driver:get_player_control()
-		if keys["sneak"] or is_water(p) or (not minetest.find_node_near(s, 1, {"default:snow","default:snowblock","default:ice","default:dirt_with_snow", "group:icemaker"})) then  -- LazyJ
+	if keys["sneak"]
+	or is_water(p)
+	or not minetest.find_node_near(s, 1, {"default:snow","default:snowblock","default:ice","default:dirt_with_snow", "group:icemaker"}) then  -- LazyJ
 		self.driver:set_physics_override({
 			speed = 1, -- multiplier to default value
 			jump = 1, -- multiplier to default value
@@ -163,7 +180,6 @@ function sled:on_step(dtime)
 
 	end
 end
-end
 
 minetest.register_entity("snow:sled", sled)
 
@@ -177,14 +193,12 @@ minetest.register_craftitem("snow:sled", {
 	stack_max = 1,
 	
 	on_use = function(itemstack, placer)
- 		local pos = {x=0,y=-1000, z=0}
- 		local name = placer:get_player_name()
- 		local player_pos = placer:getpos()
- 		if not players_sled[name] then
- 			if minetest.get_node(player_pos).name == "default:snow" then
-				local sled = minetest.add_entity(pos, "snow:sled")
-				sled:get_luaentity():on_rightclick(placer)
+		if players_sled[placer:get_player_name()] then
+			return
 		end
+		if minetest.get_node(placer:getpos()).name == "default:snow" then
+			local sled = minetest.add_entity({x=0,y=-1000, z=0}, "snow:sled")
+			sled:get_luaentity():on_rightclick(placer)
 		end
 	end,
 })

src/util.lua

@@ -159,6 +159,7 @@ minetest.register_chatcommand("snow", {
 	description = "Show a menu for various actions",
 	privs = {server=true},
 	func = function(name)
+		minetest.chat_send_player(name, "Showing snow menu…")
 		minetest.show_formspec(name, "snow:menu", get_formspec())
 	end,
 })