mtcontrib/playerfactions
1
0
Fork 0
mirror of https://github.com/mt-mods/playerfactions.git synced 2025-12-16 05:15:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add checks on command args to avoid server crashes

Browse Source
This commit is contained in:
Yves-Marie Haussonne
2020-10-13 00:57:52 +02:00
parent 639f5aa716
commit 0612afb338
3 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
init.lua
View File

@@ -287,6 +287,10 @@ local function handle_command(name, param)
end
elseif action == "player_info" then
local player_name = params[2]
if not player_name then
minetest.chat_send_player(name, S("The player name is nil or empty."))
return false
end
local player_factions = factions.get_player_factions(player_name)
if not player_factions then
minetest.chat_send_player(name, S("This player doesn't exists or is in no faction"))
@@ -324,6 +328,8 @@ local function handle_command(name, param)
local password = params[3]
if factions.get_player_faction(name) ~= nil and factions.mode_unique_faction then
minetest.chat_send_player(name, S("You are already in a faction."))
elseif not faction_name then
minetest.chat_send_player(name, S("Missing faction name."))
elseif facts[faction_name] == nil then
minetest.chat_send_player(name, S("The faction @1 doesn't exist.", faction_name))
elseif factions.get_password(faction_name) ~= password then
@@ -487,7 +493,11 @@ local function handle_command(name, param)
else
local target = params[2]
local faction_name = params[3]
if facts[faction_name] == nil then
if not target then
minetest.chat_send_player(name, S("Missing target."))
elseif not faction_name then
minetest.chat_send_player(name, S("Missing faction name."))
elseif facts[faction_name] == nil then
minetest.chat_send_player(name, S("The faction @1 doesn't exist.", faction_name))
elseif not minetest.player_exists(target) then
minetest.chat_send_player(name, S("The player doesn't exist."))