Fix crash and other things

- Fix crash nalc/nalc-server-mods#101
- Fix issue infinite spawn mobs
  nalc/nalc-server-mods#90
- Fix brewing stand for non compatible potions
  nalc/nalc-server-mods#100

brewing_stand.lua

@@ -38,13 +38,17 @@ minetest.register_node("witchcraft:brewing_stand", {
 	on_rightclick = function(pos, node, clicker, item, _)
 		local wield_item = item:get_name()
 		local new_item = wield_item.."_2"
-		if minetest.get_item_group(wield_item, "potion") ~= 0 then
+		local player_name = clicker:get_player_name()
+		if not player_name then return end
+		if minetest.get_item_group(wield_item, "potion") ~= 0 and minetest.registered_items[new_item] ~= nil then	
 			minetest.set_node(pos, {name="witchcraft:brewing_stand_active", param2=node.param2})
 			item:take_item()
 			minetest.after(30, function()
 				minetest.set_node(pos, {name="witchcraft:brewing_stand_unready", param2=node.param2})
 				minetest.add_item(pos, new_item)
 			end)
+		else
+			minetest.chat_send_player(player_name, "Sorry, it's not a potion/not upgradable!")
 		end
 	end,
 })

depends.txt

@@ -1,13 +0,0 @@
-default
-vessels
-tnt
-fire
-playereffects
-player_monoids?
-farming?
-lightning?
-pmobs?
-hud_hunger?
-hunger_ng?
-moreplants?
-horror?

init.lua

@@ -466,7 +466,7 @@ minetest.register_craft({
 	output = 'witchcraft:splash_green',
 	recipe = {
 		{'vessels:glass_fragments'},
-		{'witchcraft:potion_green'},
+		{'witchcraft:potion_green2'},
 	}
 })
 minetest.register_craft({
@@ -565,7 +565,7 @@ witchcraft.pot = {
 	{"blue", "brown", "default:dirt", "blue2", "moreplants:bullrush", "red", "purple"},
 	{"blue2", "yellow", "default:steelblock", "yellow", "default:copperblock", "green2", "aqua"},
 	{"darkpurple", "cyan", "flowers:mushroom_red", "green", "moreplants:weed", "yellow", "redbrown"},
-	{"purple", "blue2", "flowers:waterlily", "gpurple", "default:mese_crystal", "magenta", "darkpurple"},
+	{"purple", "blue2", "nalc_flowers:lily_pad", "gpurple", "default:mese_crystal", "magenta", "darkpurple"},
 	{"magenta", "purple", "witchcraft:bottle_eyes", "darkpurple", "moreplants:mushroom", "purple", "darkpurple"},
 	{"red", "grey", "default:gravel", "yllwgrn", "default:flint", "blue", "purple"},
 	{"redbrown", "magenta", "flowers:mushroom_brown", "magenta", "default:stone", "grey", "brown"},
@@ -587,7 +587,7 @@ witchcraft.pot = {
 --new recipes
 
 witchcraft.pot_new = {
-	{"blue", "blue2", "flowers:waterlily", "brown", "default:dirt", "red", "purple"},
+	{"blue", "blue2", "nalc_flowers:lily_pad", "brown", "default:dirt", "red", "purple"},
 	{"blue2", "green", "default:papyrus", "", "", "gred", "magenta"},
 	{"green", "green2", "default:sapling", "", "", "yellow", "yllwgrn"},
 	{"green2", "yellow", "default:mese_crystal_fragment", "", "", "blue", "cyan"},
@@ -655,6 +655,7 @@ for _, row in ipairs(witchcraft.pot_new) do --change 'pot_new' to 'pot' for the
 		},
 		on_rightclick = function(pos, node, clicker, itemstack, _)
 			local wield_item = itemstack:get_name()
+			if wield_item == "" then return nil end
 
 			if wield_item == "vessels:glass_bottle" then
 				local wield_items_count = itemstack:get_count()
@@ -3166,7 +3167,7 @@ minetest.register_node("witchcraft:potion_ggreen", {
 		})
 		local mtime = minetest.get_timeofday()
 		if mtime >= 0.25 and mtime <= 0.75 then
-			user:override_day_night_ratio(-mtime+0.5)
+			user:override_day_night_ratio(math.min(math.max(-mtime+0.5, 0), 1))
 			minetest.after(10, function()
 				user:override_day_night_ratio(nil)
 			end)
@@ -3390,7 +3391,7 @@ minetest.register_node("witchcraft:potion_blue2_2", {
 function lightchange(person, duration)
 	local mtime = minetest.get_timeofday()
 	if mtime <= 0.25 or mtime >= 0.75 then
-		person:override_day_night_ratio(mtime+0.5)
+		person:override_day_night_ratio(math.min(math.max(mtime+0.5, 0), 1))
 		minetest.after(duration, function()
 			person:override_day_night_ratio(nil)
 		end)
@@ -3536,6 +3537,10 @@ minetest.register_node("witchcraft:pentagram", {
 	on_rightclick = function(pos, node, _)
 		if minetest.get_modpath("mobs") then
 			minetest.after(0.5, function()
+				local node = minetest.get_node(pos)
+				if node.name ~= "witchcraft:pentagram" then
+					return
+				end
 				minetest.set_node(pos, {name="witchcraft:portal", param2=node.param2})
 				minetest.add_particlespawner({
 						amount = 25,
@@ -3578,6 +3583,10 @@ minetest.register_node("witchcraft:portal", {
 	},
 	on_construct = function(pos, node, _)
 		minetest.after(1, function()
+			local node = minetest.get_node(pos)
+			if node.name ~= "witchcraft:portal" then
+				return
+			end
 			if minetest.get_modpath("mobs_animal") and minetest.get_modpath("mobs_monster") then
 				if math.random(2) > 1 then
 					minetest.add_entity(pos, "mobs_monster:oerkki")
@@ -3627,3 +3636,5 @@ minetest.register_node("witchcraft:candle", {
 
 dofile(minetest.get_modpath("witchcraft").."/scrolls.lua")
 dofile(minetest.get_modpath("witchcraft").."/brewing_stand.lua")
+
+minetest.log("action", "[witchcraft] loaded.")