Validate user inputs (#39)

The current hack to get on the `on_player_receive_fields` function is quite likely to break with instrumented code.
This also changes the workaround to get custom inventory callbacks by using `minetest.override_item`.

.github/workflows/luacheck.yml

@@ -0,0 +1,10 @@
+name: luacheck
+on: [push, pull_request]
+jobs:
+  luacheck:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@master
+      - name: Luacheck
+        uses: lunarmodules/luacheck@master

.luacheckrc

@@ -0,0 +1,9 @@
+read_globals = {
+	-- Defined by Minetest
+	"minetest", "vector", "PseudoRandom", "VoxelArea", "table",
+
+	-- Mods
+	"digiline", "default", "creative",
+}
+globals = {"moremesecons", "mesecon"}
+ignore = {"212", "631", "422", "432"}

moremesecons_adjustable_blinkyplant/depends.txt

@@ -1,3 +0,0 @@
-mesecons
-moremesecons_utils
-craft_guide?

moremesecons_adjustable_blinkyplant/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_adjustable_blinkyplant
+depends = mesecons,moremesecons_utils
+optional_depends = craft_guide

moremesecons_adjustable_player_detector/depends.txt

@@ -1,2 +0,0 @@
-mesecons
-craft_guide?

moremesecons_adjustable_player_detector/init.lua

@@ -2,9 +2,11 @@
 -- Detects players in a certain radius
 -- The radius can be changes by right-click (by default 6)
 
+local MAX_RADIUS = moremesecons.setting("adjustable_player_detector", "max_radius", 16, 0)
+
 local function make_formspec(meta)
 	meta:set_string("formspec", "size[9,5]" ..
-		"field[0.3,  0;9,2;scanname;Coma-separated list of the names of players to scan for (empty for any):;${scanname}]"..
+		"field[0.3,  0;9,2;scanname;Comma-separated list of the names of players to scan for (empty for any):;${scanname}]"..
 		"field[0.3,1.5;4,2;digiline_channel;Digiline Channel (optional):;${digiline_channel}]"..
 		"field[0.3,3;4,2;radius;Detection radius:;${radius}]"..
 		"button_exit[3.5,3.5;2,3;;Save]")
@@ -36,7 +38,7 @@ local object_detector_scan = function (pos)
 	local scanname = meta:get_string("scanname")
 	local scan_all = scanname == ""
 	local scan_names = scanname:split(',')
-	local radius = meta:get_int("radius")
+	local radius = math.min(meta:get_int("radius"), MAX_RADIUS)
 	if radius <= 0 then
 		radius = 6
 	end
@@ -76,11 +78,11 @@ local object_detector_digiline = {
 						make_formspec(meta)
 					end
 				end
-				if msg.scanname then
+				if type(msg.scanname) == "string" then
 					meta:set_string("scanname", msg.scanname)
 					make_formspec(meta)
 				end
-				if msg.command and msg.command == "get" then
+				if msg.command == "get" then
 					local found, name = object_detector_scan(pos)
 					if not found then
 						name = ""

moremesecons_adjustable_player_detector/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_adjustable_player_detector
+depends = mesecons
+optional_depends = craft_guide

moremesecons_commandblock/depends.txt

@@ -1,3 +0,0 @@
-mesecons
-moremesecons_utils
-craft_guide?

moremesecons_commandblock/init.lua

@@ -1,10 +1,12 @@
+local strip_color_codes = minetest.settings:get_bool("strip_color_codes", false)
+
 local function initialize_data(meta)
 	local NEAREST_MAX_DISTANCE = moremesecons.setting("commandblock", "nearest_max_distance", 8, 1)
 
 	local commands = meta:get_string("commands")
 	meta:set_string("formspec",
-		"invsize[9,5;]" ..
+		"size[9,5]" ..
-		"textarea[0.5,0.5;8.5,4;commands;Commands;"..commands.."]" ..
+		"textarea[0.5,0.5;8.5,4;commands;Commands;"..minetest.formspec_escape(commands).."]" ..
 		"label[1,3.8;@nearest is replaced by the nearest player name ("..tostring(NEAREST_MAX_DISTANCE).." nodes max for the nearest distance)".."]" ..
 		"button_exit[3.3,4.5;2,1;submit;Submit]")
 	local owner = meta:get_string("owner")
@@ -46,23 +48,27 @@ local function receive_fields(pos, _, fields, player)
 	and player:get_player_name() ~= owner then
 		return
 	end
+	if strip_color_codes then
+		meta:set_string("commands", minetest.strip_colors(fields.commands))
+	else
 		meta:set_string("commands", fields.commands)
+	end
 
 	initialize_data(meta)
 end
 
 local function resolve_commands(commands, pos)
-	local nearest = nil
+	local nearest = ""
 	local min_distance = math.huge
 	local players = minetest.get_connected_players()
-	for index, player in pairs(players) do
+	for _, player in pairs(players) do
-		local distance = vector.distance(pos, player:getpos())
+		local distance = vector.distance(pos, player:get_pos())
 		if distance < min_distance then
 			min_distance = distance
 			nearest = player:get_player_name()
 		end
 	end
-	new_commands = commands:gsub("@nearest", nearest)
+	local new_commands = commands:gsub("@nearest", nearest)
 	return new_commands, min_distance, new_commands ~= commands
 end
 

moremesecons_commandblock/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_commandblock
+depends = mesecons,moremesecons_utils
+optional_depends = craft_guide

moremesecons_conductor_signalchanger/depends.txt

@@ -1,2 +0,0 @@
-mesecons
-craft_guide?

moremesecons_conductor_signalchanger/init.lua

@@ -5,7 +5,7 @@ local nodebox = {
 
 local function signalchanger_get_output_rules(node)
 	local rules = {{x=-1, y=0, z=0}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -13,7 +13,7 @@ end
 
 local function signalchanger_get_input_rules(node)
 	local rules = {{x=0, y=0, z=-1, name="input_on"}, {x=0, y=0, z=1, name="input_off"}, {x=1, y=0, z=0, name="input_signal"}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules

moremesecons_conductor_signalchanger/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_conductor_signalchanger
+depends = mesecons
+optional_depends = craft_guide

moremesecons_dual_delayer/depends.txt

@@ -1,2 +0,0 @@
-mesecons
-craft_guide?

moremesecons_dual_delayer/init.lua

@@ -1,6 +1,6 @@
 local function dual_delayer_get_input_rules(node)
 	local rules = {{x=1, y=0, z=0}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -8,7 +8,7 @@ end
 
 local function dual_delayer_get_output_rules(node)
 	local rules = {{x=0, y=0, z=1}, {x=0, y=0, z=-1}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -17,19 +17,19 @@ end
 local dual_delayer_activate = function(pos, node)
 	mesecon.receptor_on(pos, {dual_delayer_get_output_rules(node)[1]}) -- Turn on the port 1
 	minetest.swap_node(pos, {name = "moremesecons_dual_delayer:dual_delayer_10", param2 = node.param2})
-	minetest.after(0.4, function(pos, node)
+	minetest.after(0.4, function()
 		mesecon.receptor_on(pos, {dual_delayer_get_output_rules(node)[2]}) -- Turn on the port 2
 		minetest.swap_node(pos, {name = "moremesecons_dual_delayer:dual_delayer_11", param2 = node.param2})
-	end, pos, node)
+	end)
 end
 
 local dual_delayer_deactivate = function(pos, node, link)
 	mesecon.receptor_off(pos, {dual_delayer_get_output_rules(node)[2]}) -- Turn off the port 2
 	minetest.swap_node(pos, {name = "moremesecons_dual_delayer:dual_delayer_10", param2 = node.param2})
-	minetest.after(0.4, function(pos, node)
+	minetest.after(0.4, function()
 		mesecon.receptor_off(pos, {dual_delayer_get_output_rules(node)[1]}) -- Turn off the port 1
 		minetest.swap_node(pos, {name = "moremesecons_dual_delayer:dual_delayer_00", param2 = node.param2})
-	end, pos, node)
+	end)
 end
 
 
@@ -58,6 +58,10 @@ for n,i in pairs({{0,0},{1,0},{1,1}}) do
 		top_texture = pre..top_texture
 	end
 
+	local use_texture_alpha
+	if minetest.features.use_texture_alpha_string_modes then
+		use_texture_alpha = "opaque"
+	end
 	minetest.register_node("moremesecons_dual_delayer:dual_delayer_"..i1 ..i2, {
 		description = "Dual Delayer",
 		drop = "moremesecons_dual_delayer:dual_delayer_00",
@@ -74,6 +78,7 @@ for n,i in pairs({{0,0},{1,0},{1,1}}) do
 		},
 		groups = groups,
 		tiles = {top_texture, "moremesecons_dual_delayer_bottom.png", "moremesecons_dual_delayer_side_left.png", "moremesecons_dual_delayer_side_right.png", "moremesecons_dual_delayer_ends.png", "moremesecons_dual_delayer_ends.png"},
+		use_texture_alpha = use_texture_alpha,
 		mesecons = {
 			receptor = {
 				state = mesecon.state.off,

moremesecons_dual_delayer/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_dual_delayer
+depends = mesecons
+optional_depends = craft_guide

moremesecons_entity_detector/depends.txt

@@ -1,2 +0,0 @@
-mesecons
-craft_guide?

moremesecons_entity_detector/init.lua

@@ -2,9 +2,11 @@
 -- Detects entitys in a certain radius
 -- The radius can be changes by right-click (by default 6)
 
+local MAX_RADIUS = moremesecons.setting("entity_detector", "max_radius", 16, 0)
+
 local function make_formspec(meta)
 	meta:set_string("formspec", "size[9,5]" ..
-		"field[0.3,  0;9,2;scanname;Coma-separated list of the names (itemstring) of entities to scan for (empty for any):;${scanname}]"..
+		"field[0.3,  0;9,2;scanname;Comma-separated list of the names (itemstring) of entities to scan for (empty for any):;${scanname}]"..
 		"field[0.3,1.5;4,2;digiline_channel;Digiline Channel (optional):;${digiline_channel}]"..
 		"field[0.3,3;2,2;radius;Detection radius:;${radius}]"..
 		"button_exit[3.5,3.5;2,3;;Save]")
@@ -26,7 +28,7 @@ local function object_detector_on_receive_fields(pos, _, fields, player)
 	meta:set_string("digiline_channel", fields.digiline_channel)
 	local r = tonumber(fields.radius)
 	if r then
-		meta:set_int("radius", r)
+		meta:set_int("radius", math.min(r, MAX_RADIUS))
 	end
 end
 
@@ -36,18 +38,14 @@ local object_detector_scan = function (pos)
 	local scanname = meta:get_string("scanname")
 	local scan_all = scanname == ""
 	local scan_names = scanname:split(',')
-	local radius = meta:get_int("radius")
+	local radius = math.min(tonumber(meta:get("radius")) or 6, MAX_RADIUS)
-	if radius == 0 then
-		radius = 6
-	end
 	for _,obj in pairs(minetest.get_objects_inside_radius(pos, radius)) do
-		if not obj:is_player() then
 		local luaentity = obj:get_luaentity()
-			local isname = luaentity.name
+		if luaentity then
-			if isname then
 			if scan_all then
 				return true
 			end
+			local isname = luaentity.name
 			for _, name in ipairs(scan_names) do
 				if isname == name or (isname == "__builtin:item" and luaentity.itemstring == name) then
 					return true
@@ -55,7 +53,6 @@ local object_detector_scan = function (pos)
 			end
 		end
 	end
-	end
 	return false
 end
 
@@ -65,7 +62,7 @@ local object_detector_digiline = {
 		action = function (pos, node, channel, msg)
 			local meta = minetest.get_meta(pos)
 			local active_channel = meta:get_string("digiline_channel")
-			if channel ~= active_channel then
+			if channel ~= active_channel or type(msg) ~= "string" then
 				return
 			end
 			meta:set_string("scanname", msg)

moremesecons_entity_detector/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_entity_detector
+depends = mesecons
+optional_depends = craft_guide

moremesecons_igniter/depends.txt

@@ -1,3 +0,0 @@
-mesecons
-fire
-craft_guide?

moremesecons_igniter/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_igniter
+depends = mesecons,fire
+optional_depends = craft_guide

moremesecons_induction_transmitter/depends.txt

@@ -1,3 +0,0 @@
-mesecons
-mesecons_torch
-default

moremesecons_induction_transmitter/init.lua

@@ -18,10 +18,6 @@ local function induction_transmitter_get_output_rules(node)
 	return {vector.multiply(minetest.facedir_to_dir(node.param2), 2)}
 end
 
-local function induction_transmitter_get_virtual_output_rules(node)
-	return {minetest.facedir_to_dir(node.param2)}
-end
-
 local function act(pos, node, state)
 	minetest.swap_node(pos, {name = "moremesecons_induction_transmitter:induction_transmitter_"..state, param2 = node.param2})
 

moremesecons_induction_transmitter/mod.conf

@@ -0,0 +1,2 @@
+name = moremesecons_induction_transmitter
+depends = mesecons,mesecons_torch,default

moremesecons_injector_controller/depends.txt

@@ -1,2 +0,0 @@
-mesecons
-craft_guide?

moremesecons_injector_controller/init.lua

@@ -1,6 +1,6 @@
 local injector_controller_get_output_rules = function(node)
 	local rules = {{x = 0, y = 0, z = 1}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -10,7 +10,7 @@ local injector_controller_get_input_rules = function(node)
 	local rules = {{x = 0, y = 0, z = -1},
 			{x = 1, y = 0, z = 0},
 			{x = -1, y = 0, z = 0}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules

moremesecons_injector_controller/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_injector_controller
+depends = mesecons
+optional_depends = craft_guide

moremesecons_jammer/depends.txt

@@ -1,3 +0,0 @@
-mesecons
-moremesecons_utils
-craft_guide?

moremesecons_jammer/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_jammer
+depends = mesecons,moremesecons_utils
+optional_depends = craft_guide

moremesecons_luablock/depends.txt

@@ -1,2 +0,0 @@
-mesecons
-moremesecons_utils

moremesecons_luablock/init.lua

@@ -128,33 +128,33 @@ minetest.register_node("moremesecons_luablock:luablock", {
 			env.pos = table.copy(npos)
 			env.mem = minetest.deserialize(meta:get_string("mem")) or {}
 
-			local func, err
+			local func, err_syntax
 			if _VERSION == "Lua 5.1" then
-				func, err = loadstring(code)
+				func, err_syntax = loadstring(code)
 				if func then
 					setfenv(func, env)
 				end
 			else
-				func, err = load(code, nil, "t", env)
+				func, err_syntax = load(code, nil, "t", env)
 			end
 			if not func then
-				meta:set_string("errmsg", err)
+				meta:set_string("errmsg", err_syntax)
-				make_formspec(meta, pos)
+				make_formspec(meta, npos)
 				return
 			end
 
-			local good, err = pcall(func)
+			local good, err_runtime = pcall(func)
 
-			if not good then -- Runtime error
+			if not good then
-				meta:set_string("errmsg", err)
+				meta:set_string("errmsg", err_runtime)
-				make_formspec(meta, pos)
+				make_formspec(meta, npos)
 				return
 			end
 
 			meta:set_string("mem", minetest.serialize(env.mem))
 
 			meta:set_string("errmsg", "")
-			make_formspec(meta, pos)
+			make_formspec(meta, npos)
 		end
 	}}
 })

moremesecons_luablock/mod.conf

@@ -0,0 +1,2 @@
+name = moremesecons_luablock
+depends = mesecons,moremesecons_utils

moremesecons_luacontroller_tool/depends.txt

@@ -1,3 +0,0 @@
-mesecons
-mesecons_luacontroller
-moremesecons_utils

moremesecons_luacontroller_tool/init.lua

@@ -76,16 +76,19 @@ end]]
 local file_path = minetest.get_worldpath().."/MoreMesecons_lctt"
 
 -- load templates from a compressed file
-local templates_file = io.open(file_path, "rb")
+do
-if templates_file then
+	local templates_file = io.open(file_path, "rb")
+	if templates_file then
 		local templates_raw = templates_file:read("*all")
 		io.close(templates_file)
 		if templates_raw
 		and templates_raw ~= "" then
-		for name,t in pairs(minetest.deserialize(minetest.decompress(templates_raw))) do
+			local data = minetest.deserialize(minetest.decompress(templates_raw))
+			for name,t in pairs(data) do
 				templates[name] = t
 			end
 		end
+	end
 end
 
 -- the save function

moremesecons_luacontroller_tool/mod.conf

@@ -0,0 +1,2 @@
+name = moremesecons_luacontroller_tool
+depends = mesecons,mesecons_luacontroller,moremesecons_utils

moremesecons_mesechest/depends.txt

@@ -1,2 +0,0 @@
-default
-mesecons

moremesecons_mesechest/init.lua

@@ -2,66 +2,15 @@ local function mesechest_get_output_rules(node)
 	local rules = {{x=-1, y=0, z=0},
 			{x=0, y=0, z=-1},
 			{x=0, y=0, z=1}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
 end
 
-
+-- default.chest.register_chest() doesn't allow to register most of the callbacks we need
-local open_chests = {}
+-- we have to override the chest node we registered again
-
+default.chest.register_chest("moremesecons_mesechest:mesechest", {
--- Override minetest.register_node so it adds a prefix ":"
-local old_minetest_register_node = minetest.register_node
-minetest.register_node = function(name, def)
-	local old_on_metadata_inventory_put = def.on_metadata_inventory_put
-	local old_on_metadata_inventory_take = def.on_metadata_inventory_take
-	local old_on_rightclick = def.on_rightclick
-
-	def.on_metadata_inventory_put = function(pos, ...)
-		old_on_metadata_inventory_put(pos, ...)
-		mesecon.receptor_on(pos, {mesechest_get_output_rules(minetest.get_node(pos))[2]})
-		minetest.after(1, function(pos)
-			mesecon.receptor_off(pos, {mesechest_get_output_rules(minetest.get_node(pos))[2]})
-		end, pos)
-	end
-	def.on_metadata_inventory_take = function(pos, ...)
-		old_on_metadata_inventory_take(pos, ...)
-		mesecon.receptor_on(pos, {mesechest_get_output_rules(minetest.get_node(pos))[3]})
-		minetest.after(1, function(pos)
-			mesecon.receptor_off(pos, {mesechest_get_output_rules(minetest.get_node(pos))[3]})
-		end, pos)
-	end
-	def.on_rightclick = function(pos, node, clicker, ...)
-		if old_on_rightclick(pos, node, clicker, ...) == nil then
-			mesecon.receptor_on(pos, {mesechest_get_output_rules(node)[1]})
-			open_chests[clicker:get_player_name()] = pos
-		end
-	end
-
-	old_minetest_register_node(":"..name, def)
-end
-local old_minetest_register_lbm = minetest.register_lbm
-minetest.register_lbm = function() end
-
--- Get the on_player_receive_fields function. That's a huge hack
-for i, f in ipairs(minetest.registered_on_player_receive_fields) do
-	local serialized = minetest.serialize(f)
-	if string.find(serialized, "default:chest") then
-		minetest.registered_on_player_receive_fields[i] = function(player, formname, fields)
-			if f(player, formname, fields) == true then
-				local pn = player:get_player_name()
-				if open_chests[pn] then
-					mesecon.receptor_off(open_chests[pn], {mesechest_get_output_rules(minetest.get_node(open_chests[pn]))[1]})
-					open_chests[pn] = nil
-				end
-			end
-		end
-		break
-	end
-end
-
-default.register_chest("mesechest", {
 	description = "Mese Chest",
 	tiles = {
 		"default_chest_top.png^[colorize:#d8e002:70",
@@ -82,7 +31,7 @@ default.register_chest("mesechest", {
 	}
 })
 
-default.register_chest("mesechest_locked", {
+default.chest.register_chest("moremesecons_mesechest:mesechest_locked", {
 	description = "Locked Mese Chest",
 	tiles = {
 		"default_chest_top.png^[colorize:#d8e002:70",
@@ -104,15 +53,68 @@ default.register_chest("mesechest_locked", {
 	}
 })
 
-minetest.register_node = old_minetest_register_node
+local moremesecons_chests = {}
-minetest.register_lbm = old_minetest_register_lbm
+
+for _, chest in ipairs({"moremesecons_mesechest:mesechest", "moremesecons_mesechest:mesechest_locked",
+						"moremesecons_mesechest:mesechest_open", "moremesecons_mesechest:mesechest_locked_open"}) do
+	local old_def = minetest.registered_nodes[chest]
+
+	local old_on_metadata_inventory_put = old_def.on_metadata_inventory_put
+	local old_on_metadata_inventory_take = old_def.on_metadata_inventory_take
+	local old_on_rightclick = old_def.on_rightclick
+
+	local override = {}
+	override.on_metadata_inventory_put = function(pos, ...)
+		old_on_metadata_inventory_put(pos, ...)
+		mesecon.receptor_on(pos, {mesechest_get_output_rules(minetest.get_node(pos))[2]})
+		minetest.after(1, function(pos)
+			mesecon.receptor_off(pos, {mesechest_get_output_rules(minetest.get_node(pos))[2]})
+		end, pos)
+	end
+	override.on_metadata_inventory_take = function(pos, ...)
+		old_on_metadata_inventory_take(pos, ...)
+		mesecon.receptor_on(pos, {mesechest_get_output_rules(minetest.get_node(pos))[3]})
+		minetest.after(1, function(pos)
+			mesecon.receptor_off(pos, {mesechest_get_output_rules(minetest.get_node(pos))[3]})
+		end, pos)
+	end
+	override.on_rightclick = function(pos, node, clicker, ...)
+		if old_on_rightclick(pos, node, clicker, ...) == nil then
+			mesecon.receptor_on(pos, {mesechest_get_output_rules(node)[1]})
+		end
+	end
+
+	minetest.override_item(chest, override)
+	moremesecons_chests[chest] = true
+end
+
+-- if the chest is getting closed, turn the signal off
+-- luacheck: ignore 122
+local old_lid_close = default.chest.chest_lid_close
+function default.chest.chest_lid_close(pn)
+	local pos = default.chest.open_chests[pn].pos
+	-- old_lid_close will return true if the chest won't be closed
+	if old_lid_close(pn) then
+		return true
+	end
+	local node = minetest.get_node(pos)
+	if moremesecons_chests[node.name] then
+		mesecon.receptor_off(pos, {mesechest_get_output_rules(node)[1]})
+	end
+end
 
 minetest.register_craft({
-	output = "default:mesechest",
+	output = "moremesecons_mesechest:mesechest",
 	recipe = {{"group:mesecon_conductor_craftable", "default:chest", "group:mesecon_conductor_craftable"}}
 })
 
 minetest.register_craft({
-	output = "default:mesechest_locked",
+	output = "moremesecons_mesechest:mesechest_locked",
 	recipe = {{"group:mesecon_conductor_craftable", "default:chest_locked", "group:mesecon_conductor_craftable"}}
 })
+
+-- Legacy
+minetest.register_alias("default:mesechest", "moremesecons_mesechest:mesechest")
+minetest.register_alias("mesechest", "moremesecons_mesechest:mesechest")
+minetest.register_alias("default:mesechest_locked", "moremesecons_mesechest:mesechest")
+minetest.register_alias("mesechest_locked", "moremesecons_mesechest:mesechest_locked")

moremesecons_mesechest/mod.conf

@@ -0,0 +1,2 @@
+name = moremesecons_mesechest
+depends = default,mesecons

moremesecons_playerkiller/depends.txt

@@ -1,4 +0,0 @@
-mesecons
-mesecons_materials
-moremesecons_utils
-craft_guide?

moremesecons_playerkiller/init.lua

@@ -4,7 +4,7 @@ local kill_nearest_player = function(pos)
 	-- Search the nearest player
 	local nearest
 	local min_distance = MAX_DISTANCE
-	for index, player in pairs(minetest.get_connected_players()) do
+	for _, player in pairs(minetest.get_connected_players()) do
 		local distance = vector.distance(pos, player:getpos())
 		if distance < min_distance then
 			min_distance = distance

moremesecons_playerkiller/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_playerkiller
+depends = mesecons,mesecons_materials,moremesecons_utils
+optional_depends = craft_guide

moremesecons_sayer/depends.txt

@@ -1,5 +0,0 @@
-mesecons
-mesecons_noteblock
-moremesecons_utils
-default
-craft_guide?

moremesecons_sayer/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_sayer
+depends = mesecons,mesecons_noteblock,moremesecons_utils,default
+optional_depends = craft_guide

moremesecons_signalchanger/depends.txt

@@ -1,2 +0,0 @@
-mesecons
-craft_guide?

moremesecons_signalchanger/init.lua

@@ -6,7 +6,7 @@ local nodebox = {
 local function signalchanger_get_output_rules(node)
 	local rules = {{x=-1, y=0, z=0},
 			{x=1, y=0, z=0}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -14,7 +14,7 @@ end
 
 local function signalchanger_get_input_rules(node)
 	local rules = {{x=0, y=0, z=-1, name="input_on"}, {x=0, y=0, z=1, name="input_off"}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules

moremesecons_signalchanger/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_signalchanger
+depends = mesecons
+optional_depends = craft_guide

moremesecons_switchtorch/depends.txt

@@ -1,2 +0,0 @@
-mesecons
-craft_guide?

moremesecons_switchtorch/init.lua

@@ -80,7 +80,7 @@ minetest.register_node("moremesecons_switchtorch:switchtorch_on", {
 	selection_box = torch_selectionbox,
 	groups = {dig_immediate=3, not_in_creative_inventory = 1},
 	drop = "moremesecons_switchtorch:switchtorch_off",
-	light_source = LIGHT_MAX-5,
+	light_source = 9,
 	mesecons = {receptor = {
 		state = mesecon.state.on,
 		rules = torch_get_output_rules

moremesecons_switchtorch/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_switchtorch
+depends = mesecons
+optional_depends = craft_guide

moremesecons_teleporter/depends.txt

@@ -1,3 +0,0 @@
-mesecons
-moremesecons_utils
-craft_guide?

moremesecons_teleporter/init.lua

@@ -24,12 +24,12 @@ local function teleport_nearest(pos)
 
 	-- Search for the nearest player
 	local nearest = nil
-	local min_distance = MAX_PLAYER_DISTANCE
+	local min_distance_player = MAX_PLAYER_DISTANCE
 	local players = minetest.get_connected_players()
-	for index, player in pairs(players) do
+	for _, player in pairs(players) do
 		local distance = vector.distance(pos, player:getpos())
-		if distance <= min_distance then
+		if distance <= min_distance_player then
-			min_distance = distance
+			min_distance_player = distance
 			nearest = player
 		end
 	end

moremesecons_teleporter/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_teleporter
+depends = mesecons,moremesecons_utils
+optional_depends = craft_guide

moremesecons_timegate/depends.txt

@@ -1,2 +0,0 @@
-mesecons
-craft_guide?

moremesecons_timegate/init.lua

@@ -1,6 +1,6 @@
 local timegate_get_output_rules = function(node)
 	local rules = {{x = 0, y = 0, z = 1}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -8,7 +8,7 @@ end
 
 local timegate_get_input_rules = function(node)
 	local rules = {{x = 0, y = 0, z = -1}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -35,7 +35,7 @@ local function timegate_activate(pos, node)
 	end)
 end
 
-boxes = {{ -6/16, -8/16, -6/16, 6/16, -7/16, 6/16 },		-- the main slab
+local boxes = {{ -6/16, -8/16, -6/16, 6/16, -7/16, 6/16 },		-- the main slab
 
 	 { -2/16, -7/16, -4/16, 2/16, -26/64, -3/16 },		-- the jeweled "on" indicator
 	 { -3/16, -7/16, -3/16, 3/16, -26/64, -2/16 },
@@ -47,6 +47,10 @@ boxes = {{ -6/16, -8/16, -6/16, 6/16, -7/16, 6/16 },		-- the main slab
 	 { -8/16, -8/16, -1/16, -6/16, -7/16, 1/16 },		-- the two wire stubs
 	 { 6/16, -8/16, -1/16, 8/16, -7/16, 1/16 }}
 
+local use_texture_alpha
+if minetest.features.use_texture_alpha_string_modes then
+	use_texture_alpha = "opaque"
+end
 mesecon.register_node("moremesecons_timegate:timegate", {
 	description = "Time Gate",
 	drawtype = "nodebox",
@@ -84,6 +88,7 @@ mesecon.register_node("moremesecons_timegate:timegate", {
 			"moremesecons_timegate_sides_off.png",
 			"moremesecons_timegate_sides_off.png"
 		},
+		use_texture_alpha = use_texture_alpha,
 		groups = {bendy=2,snappy=1,dig_immediate=2},
 		mesecons = {
 			receptor =
@@ -106,6 +111,7 @@ mesecon.register_node("moremesecons_timegate:timegate", {
 			"moremesecons_timegate_sides_on.png",
 			"moremesecons_timegate_sides_on.png"
 		},
+		use_texture_alpha = use_texture_alpha,
 		groups = {bendy=2,snappy=1,dig_immediate=2, not_in_creative_inventory=1},
 		mesecons = {
 			receptor = {

moremesecons_timegate/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_timegate
+depends = mesecons
+optional_depends = craft_guide

moremesecons_utils/init.lua

@@ -243,12 +243,11 @@ MapDataStorage.__index = {
 			indices[i] = ("%.17g"):format(vi)
 			values[i] = v
 		end
-		result = {
+		return minetest.serialize({
 			version = "MapDataStorage_v1",
 			indices = "return {" .. table.concat(indices, ",") .. "}",
 			values = minetest.serialize(values),
-		}
+		})
-		return minetest.serialize(result)
 	end,
 }
 MapDataStorage.deserialize = function(txtdata)
@@ -317,6 +316,7 @@ end
 
 
 
+--[[
 -- This testing code shows an example usage of the MapDataStorage code
 local function do_test()
 	print("Test if iter returns correct positions when a lot is set")
@@ -339,14 +339,14 @@ local function do_test()
 		end
 	end
 	local i = 0
-	for pos, v in data:iter({x=-4, y=-4, z=-4}, {x=2, y=2, z=2}) do
+	for pos in data:iter({x=-4, y=-4, z=-4}, {x=2, y=2, z=2}) do
 		i = i + 1
 		assert(vector.equals(pos, expected_positions[i]))
 	end
 
 	print("Test if iter works correctly on a corner")
 	local found = false
-	for pos, v in data:iter({x=-8, y=-7, z=-80}, {x=-5, y=-5, z=-5}) do
+	for pos in data:iter({x=-8, y=-7, z=-80}, {x=-5, y=-5, z=-5}) do
 		assert(not found)
 		found = true
 		assert(vector.equals(pos, {x=-5, y=-5, z=-5}))
@@ -377,5 +377,5 @@ local function do_test()
 
 	--~ data:iterAll()
 end
---~ do_test()
+do_test()
-
+--]]

moremesecons_utils/mod.conf

@@ -0,0 +1,2 @@
+name = moremesecons_utils
+description = Various helping functions for moremesecons

moremesecons_wireless/depends.txt

@@ -1,4 +0,0 @@
-mesecons
-moremesecons_utils
-digilines?
-craft_guide?

moremesecons_wireless/init.lua

@@ -186,10 +186,10 @@ function wireless_receptor_off(pos, id, network, check)
 	end
 end
 
-function activate_network(owner, channel)
+local function activate_network(owner, channel)
 	local network = wireless[owner][channel]
 	for i, wl_pos in pairs(network.members) do
-		wireless_receptor_on(wl_pos, id, network)
+		wireless_receptor_on(wl_pos, i, network)
 	end
 end
 
@@ -253,22 +253,35 @@ function wireless_effector_off(pos)
 	update_mod_storage()
 end
 
+-- This table is required to prevent a message from being sent in loop between wireless nodes
+local sending_digilines = {}
+
 local function on_digiline_receive(pos, node, channel, msg)
 	if is_jammed(pos) then
 		return
 	end
 
 	local wls = moremesecons.get_data_from_pos(wireless_meta, pos)
+	if not wls then
+		return
+	end
 
 	if wls.owner == "" or not wireless[wls.owner] or channel == "" or not wireless[wls.owner][wls.channel] then
 		return
 	end
 
+	local pos_hash = minetest.hash_node_position(pos)
+	if sending_digilines[pos_hash] then
+		return
+	end
+
+	sending_digilines[pos_hash] = true
 	for i, wl_pos in pairs(wireless[wls.owner][wls.channel].members) do
-		if i ~= wls.id and check_wireless_exists(wl_pos) then
+		if i ~= wls.id then
 			digiline:receptor_send(wl_pos, digiline.rules.default, channel, msg)
 		end
 	end
+	sending_digilines[pos_hash] = nil
 end
 
 mesecon.register_node("moremesecons_wireless:wireless", {
@@ -290,7 +303,6 @@ mesecon.register_node("moremesecons_wireless:wireless", {
 		mesecon.receptor_off(pos)
 	end,
 	after_place_node = function(pos, placer)
-		local placername = placer:get_player_name()
 		set_owner(pos, placer:get_player_name())
 	end,
 	on_receive_fields = function(pos, _, fields, player)
@@ -327,6 +339,15 @@ mesecon.register_node("moremesecons_wireless:wireless", {
 
 minetest.register_alias("moremesecons_wireless:wireless", "moremesecons_wireless:wireless_off")
 
+minetest.register_craft({
+	output = "moremesecons_wireless:wireless_off 2",
+	recipe = {
+		{"group:mesecon_conductor_craftable", "", "group:mesecon_conductor_craftable"},
+		{"", "mesecons_torch:mesecon_torch_on", ""},
+		{"group:mesecon_conductor_craftable", "", "group:mesecon_conductor_craftable"},
+	}
+})
+
 local function remove_jammer(pos)
 	moremesecons.remove_data_from_pos(jammers, pos)
 end
@@ -354,11 +375,12 @@ function is_jammed(pos)
 	return false
 end
 
-mesecon.register_node("moremesecons_wireless:jammer", {
+if moremesecons.setting("wireless", "enable_jammer", true) then
+	mesecon.register_node("moremesecons_wireless:jammer", {
 		description = "Wireless Jammer",
 		paramtype = "light",
 		drawtype = "nodebox",
-},{
+	},{
 		tiles = {"mesecons_wire_off.png^moremesecons_jammer_top.png", "moremesecons_jammer_bottom.png", "mesecons_wire_off.png^moremesecons_jammer_side_off.png"},
 		node_box = {
 			type = "fixed",
@@ -385,7 +407,7 @@ mesecon.register_node("moremesecons_wireless:jammer", {
 				minetest.swap_node(pos, {name="moremesecons_wireless:jammer_on"})
 			end
 		}}
-},{
+	},{
 		tiles = {"mesecons_wire_on.png^moremesecons_jammer_top.png", "moremesecons_jammer_bottom.png", "mesecons_wire_on.png^moremesecons_jammer_side_on.png"},
 		node_box = {
 			type = "fixed",
@@ -414,23 +436,15 @@ mesecon.register_node("moremesecons_wireless:jammer", {
 		}},
 		on_destruct = remove_jammer,
 		on_construct = add_jammer,
-})
+	})
 
-minetest.register_craft({
+	minetest.register_craft({
 		output = "moremesecons_wireless:jammer_off",
 		recipe = {
 			{"moremesecons_wireless:wireless", "mesecons_torch:mesecon_torch_on", "moremesecons_wireless:wireless"}
 		}
-})
+	})
-
+end
-minetest.register_craft({
-	output = "moremesecons_wireless:wireless_off 2",
-	recipe = {
-		{"group:mesecon_conductor_craftable", "", "group:mesecon_conductor_craftable"},
-		{"", "mesecons_torch:mesecon_torch_on", ""},
-		{"group:mesecon_conductor_craftable", "", "group:mesecon_conductor_craftable"},
-	}
-})
 
 if moremesecons.setting("wireless", "enable_lbm", false) then
 	minetest.register_lbm({

moremesecons_wireless/mod.conf

@@ -0,0 +1,3 @@
+name = moremesecons_wireless
+depends = mesecons,moremesecons_utils
+optional_depends = digilines,craft_guide

settingtypes.txt

@@ -3,6 +3,10 @@
 # Minimal interval authorized. Any lower will be set to it.
 moremesecons_adjustable_blinky_plant.min_interval (Minimum Interval) float 0.5
 
+[Adjustable Player Detector]
+
+moremesecons_adjustable_player_detector.max_radius (Maximum adjustable player detector radius) float 16 0
+
 [Craftable Commandblock]
 
 # Space-separated list of authorized commands
@@ -13,6 +17,10 @@ moremesecons_commandblock.authorized_commands (Authorized commands) string tell
 # Any value less than or equal to 0 will be changed to 1 and a NaN value will be changed to the default value
 moremesecons_commandblock.nearest_max_distance (Nearest player maximum distance) float 8
 
+[Entity Detector]
+
+moremesecons_entity_detector.max_radius (Maximum entity detector radius) float 16 0
+
 [Signal Jammer]
 
 # Jammer action range
@@ -63,6 +71,9 @@ moremesecons_teleporter.enable_lbm (Enable Registration LBM) bool false
 
 [Wireless]
 
+# Whether to enable the wireless jammer node
+moremesecons_wireless.enable_jammer (Enable wireless jammer) bool true
+
 # Wireless Jammer action range
 # Any value less than or equal to 0 will be changed to 1 and a NaN value will be changed to the default value
 moremesecons_wireless.jammer_max_distance (Wireless Jammer action range) float 15