Remove unused loop variables

Fixes #17

moremesecons_commandblock/init.lua

@@ -55,7 +55,7 @@ local function resolve_commands(commands, pos)
 	local nearest = nil
 	local min_distance = math.huge
 	local players = minetest.get_connected_players()
-	for index, player in pairs(players) do
+	for _, player in pairs(players) do
 		local distance = vector.distance(pos, player:getpos())
 		if distance < min_distance then
 			min_distance = distance

moremesecons_conductor_signalchanger/init.lua

@@ -5,7 +5,7 @@ local nodebox = {
 
 local function signalchanger_get_output_rules(node)
 	local rules = {{x=-1, y=0, z=0}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -13,7 +13,7 @@ end
 
 local function signalchanger_get_input_rules(node)
 	local rules = {{x=0, y=0, z=-1, name="input_on"}, {x=0, y=0, z=1, name="input_off"}, {x=1, y=0, z=0, name="input_signal"}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules

moremesecons_dual_delayer/init.lua

@@ -1,6 +1,6 @@
 local function dual_delayer_get_input_rules(node)
 	local rules = {{x=1, y=0, z=0}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -8,7 +8,7 @@ end
 
 local function dual_delayer_get_output_rules(node)
 	local rules = {{x=0, y=0, z=1}, {x=0, y=0, z=-1}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules

moremesecons_injector_controller/init.lua

@@ -1,6 +1,6 @@
 local injector_controller_get_output_rules = function(node)
 	local rules = {{x = 0, y = 0, z = 1}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -10,7 +10,7 @@ local injector_controller_get_input_rules = function(node)
 	local rules = {{x = 0, y = 0, z = -1},
 			{x = 1, y = 0, z = 0},
 			{x = -1, y = 0, z = 0}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules

moremesecons_luablock/init.lua

@@ -120,25 +120,30 @@ minetest.register_node("moremesecons_luablock:luablock", {
 				minetest.log("warning", "[moremesecons_luablock] Metadata of LuaBlock at pos "..minetest.pos_to_string(npos).." does not match its mod storage data!")
 				return
 			end
-			-- We do absolutely no check there.
-			-- There is no limitation in the number of instruction the LuaBlock can execute
-			-- or the usage it can make of loops.
-			-- It is executed in the global namespace.
-			-- Remember: *The LuaBlock is highly dangerous and should be manipulated cautiously!*
-			local func, err = loadstring(code)
+
+			local env = {}
+			for k, v in pairs(_G) do
+				env[k] = v
+			end
+			env.pos = table.copy(npos)
+			env.mem = minetest.deserialize(meta:get_string("mem")) or {}
+
+			local func, err
+			if _VERSION == "Lua 5.1" then
+				func, err = loadstring(code)
+				if func then
+					setfenv(func, env)
+				end
+			else
+				func, err = load(code, nil, "t", env)
+			end
 			if not func then
 				meta:set_string("errmsg", err)
 				make_formspec(meta, pos)
 				return
 			end
-			-- Set the "pos" global
-			local old_pos
-			if minetest.global_exists("pos") then
-				old_pos = pos -- In case there's already an existing "pos" global
-			end
-			pos = table.copy(npos)
+
 			local good, err = pcall(func)
-			pos = old_pos
 
 			if not good then -- Runtime error
 				meta:set_string("errmsg", err)
@@ -146,6 +151,8 @@ minetest.register_node("moremesecons_luablock:luablock", {
 				return
 			end
 
+			meta:set_string("mem", minetest.serialize(env.mem))
+
 			meta:set_string("errmsg", "")
 			make_formspec(meta, pos)
 		end

moremesecons_mesechest/init.lua

@@ -2,7 +2,7 @@ local function mesechest_get_output_rules(node)
 	local rules = {{x=-1, y=0, z=0},
 			{x=0, y=0, z=-1},
 			{x=0, y=0, z=1}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules

moremesecons_playerkiller/init.lua

@@ -4,7 +4,7 @@ local kill_nearest_player = function(pos)
 	-- Search the nearest player
 	local nearest
 	local min_distance = MAX_DISTANCE
-	for index, player in pairs(minetest.get_connected_players()) do
+	for _, player in pairs(minetest.get_connected_players()) do
 		local distance = vector.distance(pos, player:getpos())
 		if distance < min_distance then
 			min_distance = distance

moremesecons_signalchanger/init.lua

@@ -6,7 +6,7 @@ local nodebox = {
 local function signalchanger_get_output_rules(node)
 	local rules = {{x=-1, y=0, z=0},
 			{x=1, y=0, z=0}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -14,7 +14,7 @@ end
 
 local function signalchanger_get_input_rules(node)
 	local rules = {{x=0, y=0, z=-1, name="input_on"}, {x=0, y=0, z=1, name="input_off"}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules

moremesecons_teleporter/init.lua

@@ -26,7 +26,7 @@ local function teleport_nearest(pos)
 	local nearest = nil
 	local min_distance = MAX_PLAYER_DISTANCE
 	local players = minetest.get_connected_players()
-	for index, player in pairs(players) do
+	for _, player in pairs(players) do
 		local distance = vector.distance(pos, player:getpos())
 		if distance <= min_distance then
 			min_distance = distance

moremesecons_timegate/init.lua

@@ -1,6 +1,6 @@
 local timegate_get_output_rules = function(node)
 	local rules = {{x = 0, y = 0, z = 1}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -8,7 +8,7 @@ end
 
 local timegate_get_input_rules = function(node)
 	local rules = {{x = 0, y = 0, z = -1}}
-	for i = 0, node.param2 do
+	for _ = 0, node.param2 do
 		rules = mesecon.rotate_rules_left(rules)
 	end
 	return rules
@@ -25,11 +25,14 @@ local function timegate_activate(pos, node)
 	node.name = "moremesecons_timegate:timegate_on"
 	minetest.swap_node(pos, node)
 	mesecon.receptor_on(pos)
-	minetest.after(time, function(pos, node)
-		mesecon.receptor_off(pos)
-		node.name = "moremesecons_timegate:timegate_off"
-		minetest.swap_node(pos, node)
-	end, pos, node)
+	minetest.after(time, function()
+		local node = minetest.get_node(pos)
+		if node.name == "moremesecons_timegate:timegate_on" then
+			mesecon.receptor_off(pos)
+			node.name = "moremesecons_timegate:timegate_off"
+			minetest.swap_node(pos, node)
+		end
+	end)
 end
 
 boxes = {{ -6/16, -8/16, -6/16, 6/16, -7/16, 6/16 },		-- the main slab

moremesecons_utils/init.lua

@@ -233,7 +233,6 @@ MapDataStorage.__index = {
 		return iterfunc
 	end,
 	serialize = function(self)
-		local serialize_data = minetest.serialize
 		local indices = {}
 		local values = {}
 		local i = 1
@@ -241,13 +240,13 @@ MapDataStorage.__index = {
 			local vi = node_position_key(pos)
 			-- Convert the double reversible to a string;
 			-- minetest.serialize does not (yet) do this
-			indices[i] = ("%a"):format(vi)
-			values[i] = serialize_data(v)
+			indices[i] = ("%.17g"):format(vi)
+			values[i] = v
 		end
 		result = {
 			version = "MapDataStorage_v1",
 			indices = "return {" .. table.concat(indices, ",") .. "}",
-			values = "return {" .. table.concat(values, ",") .. "}",
+			values = minetest.serialize(values),
 		}
 		return minetest.serialize(result)
 	end,
@@ -260,8 +259,11 @@ MapDataStorage.deserialize = function(txtdata)
 	end
 	-- I assume that minetest.deserialize correctly deserializes the indices,
 	-- which are in the %a format
-	indices = minetest.deserialize(data.indices)
-	values = minetest.deserialize(data.values)
+	local indices = minetest.deserialize(data.indices)
+	local values = minetest.deserialize(data.values)
+	if not indices or not values then
+		return MapDataStorage()
+	end
 	data = MapDataStorage()
 	for i = 1,#indices do
 		local vi = indices[i]
@@ -306,7 +308,7 @@ function moremesecons.load_MapDataStorage_legacy(modstorage, name, oldname)
 		modstorage:set_string(oldname, nil)
 		return t
 	end
-	t = modstorage:get_string("teleporters_rids_v2")
+	t = modstorage:get_string(name)
 	if t and t ~= "" then
 		return MapDataStorage.deserialize(t)
 	end
@@ -337,14 +339,14 @@ local function do_test()
 		end
 	end
 	local i = 0
-	for pos, v in data:iter({x=-4, y=-4, z=-4}, {x=2, y=2, z=2}) do
+	for pos in data:iter({x=-4, y=-4, z=-4}, {x=2, y=2, z=2}) do
 		i = i + 1
 		assert(vector.equals(pos, expected_positions[i]))
 	end
 
 	print("Test if iter works correctly on a corner")
 	local found = false
-	for pos, v in data:iter({x=-8, y=-7, z=-80}, {x=-5, y=-5, z=-5}) do
+	for pos in data:iter({x=-8, y=-7, z=-80}, {x=-5, y=-5, z=-5}) do
 		assert(not found)
 		found = true
 		assert(vector.equals(pos, {x=-5, y=-5, z=-5}))

moremesecons_wireless/init.lua

@@ -188,7 +188,7 @@ end
 
 function activate_network(owner, channel)
 	local network = wireless[owner][channel]
-	for i, wl_pos in pairs(network.members) do
+	for _, wl_pos in pairs(network.members) do
 		wireless_receptor_on(wl_pos, id, network)
 	end
 end
@@ -253,6 +253,9 @@ function wireless_effector_off(pos)
 	update_mod_storage()
 end
 
+-- This table is required to prevent a message from being sent in loop between wireless nodes
+local sending_digilines = {}
+
 local function on_digiline_receive(pos, node, channel, msg)
 	if is_jammed(pos) then
 		return
@@ -264,11 +267,18 @@ local function on_digiline_receive(pos, node, channel, msg)
 		return
 	end
 
+	local pos_hash = minetest.hash_node_position(pos)
+	if sending_digilines[pos_hash] then
+		return
+	end
+
+	sending_digilines[pos_hash] = true
 	for i, wl_pos in pairs(wireless[wls.owner][wls.channel].members) do
 		if i ~= wls.id and check_wireless_exists(wl_pos) then
 			digiline:receptor_send(wl_pos, digiline.rules.default, channel, msg)
 		end
 	end
+	sending_digilines[pos_hash] = nil
 end
 
 mesecon.register_node("moremesecons_wireless:wireless", {
@@ -327,6 +337,15 @@ mesecon.register_node("moremesecons_wireless:wireless", {
 
 minetest.register_alias("moremesecons_wireless:wireless", "moremesecons_wireless:wireless_off")
 
+minetest.register_craft({
+	output = "moremesecons_wireless:wireless_off 2",
+	recipe = {
+		{"group:mesecon_conductor_craftable", "", "group:mesecon_conductor_craftable"},
+		{"", "mesecons_torch:mesecon_torch_on", ""},
+		{"group:mesecon_conductor_craftable", "", "group:mesecon_conductor_craftable"},
+	}
+})
+
 local function remove_jammer(pos)
 	moremesecons.remove_data_from_pos(jammers, pos)
 end
@@ -354,83 +373,76 @@ function is_jammed(pos)
 	return false
 end
 
-mesecon.register_node("moremesecons_wireless:jammer", {
-	description = "Wireless Jammer",
-	paramtype = "light",
-	drawtype = "nodebox",
-},{
-	tiles = {"mesecons_wire_off.png^moremesecons_jammer_top.png", "moremesecons_jammer_bottom.png", "mesecons_wire_off.png^moremesecons_jammer_side_off.png"},
-	node_box = {
-		type = "fixed",
-		fixed = {
-			-- connection
-			{-1/16, -0.5, -0.5, 1/16, -7/16, 0.5},
-			{-0.5, -0.5, -1/16, 0.5, -7/16, 1/16},
+if moremesecons.setting("wireless", "enable_jammer", true) then
+	mesecon.register_node("moremesecons_wireless:jammer", {
+		description = "Wireless Jammer",
+		paramtype = "light",
+		drawtype = "nodebox",
+	},{
+		tiles = {"mesecons_wire_off.png^moremesecons_jammer_top.png", "moremesecons_jammer_bottom.png", "mesecons_wire_off.png^moremesecons_jammer_side_off.png"},
+		node_box = {
+			type = "fixed",
+			fixed = {
+				-- connection
+				{-1/16, -0.5, -0.5, 1/16, -7/16, 0.5},
+				{-0.5, -0.5, -1/16, 0.5, -7/16, 1/16},
 
-			--stabilization
-			{-1/16, -7/16, -1/16, 1/16, -6/16, 1/16},
+				--stabilization
+				{-1/16, -7/16, -1/16, 1/16, -6/16, 1/16},
 
-			-- fields
-			{-7/16, -6/16, -7/16, 7/16, -4/16, 7/16},
-			{-5/16, -4/16, -5/16, 5/16, -3/16, 5/16},
-			{-3/16, -3/16, -3/16, 3/16, -2/16, 3/16},
-			{-1/16, -2/16, -1/16, 1/16, -1/16, 1/16},
+				-- fields
+				{-7/16, -6/16, -7/16, 7/16, -4/16, 7/16},
+				{-5/16, -4/16, -5/16, 5/16, -3/16, 5/16},
+				{-3/16, -3/16, -3/16, 3/16, -2/16, 3/16},
+				{-1/16, -2/16, -1/16, 1/16, -1/16, 1/16},
+			},
 		},
-	},
-	groups = {dig_immediate=2},
-	mesecons = {effector = {
-		rules = mesecon.rules.flat,
-		action_on = function(pos)
-			add_jammer(pos)
-			minetest.swap_node(pos, {name="moremesecons_wireless:jammer_on"})
-		end
-	}}
-},{
-	tiles = {"mesecons_wire_on.png^moremesecons_jammer_top.png", "moremesecons_jammer_bottom.png", "mesecons_wire_on.png^moremesecons_jammer_side_on.png"},
-	node_box = {
-		type = "fixed",
-		fixed = {
-			-- connection
-			{-1/16, -0.5, -0.5, 1/16, -7/16, 0.5},
-			{-0.5, -0.5, -1/16, 0.5, -7/16, 1/16},
+		groups = {dig_immediate=2},
+		mesecons = {effector = {
+			rules = mesecon.rules.flat,
+			action_on = function(pos)
+				add_jammer(pos)
+				minetest.swap_node(pos, {name="moremesecons_wireless:jammer_on"})
+			end
+		}}
+	},{
+		tiles = {"mesecons_wire_on.png^moremesecons_jammer_top.png", "moremesecons_jammer_bottom.png", "mesecons_wire_on.png^moremesecons_jammer_side_on.png"},
+		node_box = {
+			type = "fixed",
+			fixed = {
+				-- connection
+				{-1/16, -0.5, -0.5, 1/16, -7/16, 0.5},
+				{-0.5, -0.5, -1/16, 0.5, -7/16, 1/16},
 
-			--stabilization
-			{-1/16, -7/16, -1/16, 1/16, 5/16, 1/16},
+				--stabilization
+				{-1/16, -7/16, -1/16, 1/16, 5/16, 1/16},
 
-			-- fields
-			{-7/16, -6/16, -7/16, 7/16, -4/16, 7/16},
-			{-5/16, -3/16, -5/16, 5/16, -1/16, 5/16},
-			{-3/16, 0, -3/16, 3/16, 2/16, 3/16},
-			{-1/16, 3/16, -1/16, 1/16, 5/16, 1/16},
+				-- fields
+				{-7/16, -6/16, -7/16, 7/16, -4/16, 7/16},
+				{-5/16, -3/16, -5/16, 5/16, -1/16, 5/16},
+				{-3/16, 0, -3/16, 3/16, 2/16, 3/16},
+				{-1/16, 3/16, -1/16, 1/16, 5/16, 1/16},
+			},
 		},
-	},
-	groups = {dig_immediate=2, not_in_creative_inventory=1},
-	mesecons = {effector = {
-		rules = mesecon.rules.flat,
-		action_off = function(pos)
-			remove_jammer(pos)
-			minetest.swap_node(pos, {name="moremesecons_wireless:jammer_off"})
-		end
-	}},
-	on_destruct = remove_jammer,
-	on_construct = add_jammer,
-})
+		groups = {dig_immediate=2, not_in_creative_inventory=1},
+		mesecons = {effector = {
+			rules = mesecon.rules.flat,
+			action_off = function(pos)
+				remove_jammer(pos)
+				minetest.swap_node(pos, {name="moremesecons_wireless:jammer_off"})
+			end
+		}},
+		on_destruct = remove_jammer,
+		on_construct = add_jammer,
+	})
 
-minetest.register_craft({
-	output = "moremesecons_wireless:jammer_off",
-	recipe = {
-		{"moremesecons_wireless:wireless", "mesecons_torch:mesecon_torch_on", "moremesecons_wireless:wireless"}
-	}
-})
-
-minetest.register_craft({
-	output = "moremesecons_wireless:wireless_off 2",
-	recipe = {
-		{"group:mesecon_conductor_craftable", "", "group:mesecon_conductor_craftable"},
-		{"", "mesecons_torch:mesecon_torch_on", ""},
-		{"group:mesecon_conductor_craftable", "", "group:mesecon_conductor_craftable"},
-	}
-})
+	minetest.register_craft({
+		output = "moremesecons_wireless:jammer_off",
+		recipe = {
+			{"moremesecons_wireless:wireless", "mesecons_torch:mesecon_torch_on", "moremesecons_wireless:wireless"}
+		}
+	})
+end
 
 if moremesecons.setting("wireless", "enable_lbm", false) then
 	minetest.register_lbm({

settingtypes.txt

@@ -63,6 +63,9 @@ moremesecons_teleporter.enable_lbm (Enable Registration LBM) bool false
 
 [Wireless]
 
+# Whether to enable the wireless jammer node
+moremesecons_wireless.enable_jammer (Enable wireless jammer) bool true
+
 # Wireless Jammer action range
 # Any value less than or equal to 0 will be changed to 1 and a NaN value will be changed to the default value
 moremesecons_wireless.jammer_max_distance (Wireless Jammer action range) float 15