Replace Travis CI with GitHub Actions (#12)

Co-authored-by: sys4 <bricassa@sys4.fr>

.github/workflows/build.yml

@@ -0,0 +1,20 @@
+name: build
+on: [push, pull_request]
+
+jobs:
+  luacheck:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - name: Install dependencies
+      run: |
+        sudo apt-get update -qq
+        sudo apt-get install -qqq luarocks
+    - name: Install LuaCheck and pre-commit
+      run: |
+        pip3 install pre-commit
+        luarocks install --local luacheck
+    - name: Run LuaCheck with pre-commit
+      run: |
+        export PATH="$HOME/.luarocks/bin:$PATH"
+        pre-commit run --all-files

.luacheckrc

@@ -21,6 +21,11 @@ stds.minetest = {
 				"copy",
 			},
 		},
+		math = {
+			fields = {
+				"round",
+			},
+		}
 	}
 }
 

.travis.yml

@@ -1,16 +0,0 @@
-dist: bionic
-language: python
-
-python:
-  - 3.7.1
-
-install:
-  - sudo apt-get update -qq
-  - sudo apt-get install -qqq luarocks
-  - pip3 install pre-commit
-  - luarocks install --local luacheck
-
-script:
-  # All linters are run with pre-commit hooks
-  - export PATH="$HOME/.luarocks/bin:$PATH"
-  - pre-commit run --all-files

CHANGELOG.md

@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Changed
+
+- [Health and breath bars now adapt to custom maximum values instead of being hardcoded to 20 and 11 respectively.](https://github.com/minetest-mods/gauges/pull/9)
+
+### Fixed
+
+- [The health bar entity is no longer lost when a player teleports.](https://github.com/minetest-mods/gauges/pull/10)
+  - A side effect is that health bar entities are no longer saved in map metadata.
+
 ## [1.0.4] - 2020-09-27
 
 ### Added

init.lua

@@ -3,6 +3,10 @@
 -- Copyright © 2014-2020 4aiman, Hugo Locurcio and contributors - MIT License
 -- See `LICENSE.md` included in the source distribution for details.
 
+local function round(v)
+	return math.floor(v + 0.5)
+end
+
 local enabled = minetest.settings:get_bool("health_bars") ~= false
 if enabled then
 	enabled = minetest.settings:get_bool("enable_damage")
@@ -11,8 +15,10 @@ end
 -- Localize this functions for better performance,
 -- as it's called on every step
 local vector_distance = vector.distance
-local min = math.min
-local max_breath = minetest.PLAYER_MAX_BREATH_DEFAULT or 11
+local max = {
+	breath = 11,
+	hp = 20,
+}
 
 local mt_5 = minetest.features.object_independent_selectionbox
 
@@ -29,12 +35,22 @@ local function add_gauge(player)
 	end
 end
 
+-- credit:
+-- https://github.com/minetest/minetest/blob/master/builtin/game/statbars.lua#L31-L37
+local function scaleToDefault(player, field)
+	-- Scale "hp" or "breath" to supported amount
+	local current = player["get_" .. field](player)
+	local max_display = math.max(player:get_properties()[field .. "_max"], current)
+	return round(current / max_display * max[field])
+end
+
 minetest.register_entity("gauges:hp_bar", {
 	visual = "sprite",
 	visual_size = {x=1, y=1/16, z=1},
 	textures = {"blank.png"},
 	collisionbox = {0},
 	physical = false,
+	static_save = false,
 
 	on_step = function(self)
 		local player = self.wielder
@@ -50,8 +66,8 @@ minetest.register_entity("gauges:hp_bar", {
 			return
 		end
 
-		local hp = min(player:get_hp(), 20)
-		local breath = min(player:get_breath(), max_breath)
+		local hp = scaleToDefault(player, "hp")
+		local breath = scaleToDefault(player, "breath")
 
 		if self.hp ~= hp or self.breath ~= breath then
 			local health_t = "health_"..hp..".png"
@@ -61,7 +77,7 @@ minetest.register_entity("gauges:hp_bar", {
 				health_t = "blank.png"
 			end
 
-			if breath == max_breath then
+			if breath == max.breath then
 				breath_t = "blank.png"
 			end